Blob Blame History Raw
From 2b3c17a1036e1b0db85fef8b1033505949cf7079 Mon Sep 17 00:00:00 2001
From: Cathy Avery <cavery@redhat.com>
Date: Thu, 25 Jul 2019 12:32:26 +0200
Subject: [PATCH 03/16] Fix a leak if VGAuth setup fails. Coverity issue

RH-Author: Cathy Avery <cavery@redhat.com>
Message-id: <20190725123239.18274-4-cavery@redhat.com>
Patchwork-id: 89709
O-Subject: [RHEL8.1 open-vm-tools PATCH 03/16] Fix a leak if VGAuth setup fails. Coverity issue
Bugzilla: 1602648
RH-Acked-by: Vitaly Kuznetsov <vkuznets@redhat.com>
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>

commit 82169f198925c9aa27bd04fd665eac67396adbe7
Author: Oliver Kurth <okurth@vmware.com>
Date:   Mon Apr 15 11:33:00 2019 -0700

    Fix a leak if VGAuth setup fails.  Coverity issue

Signed-off-by: Cathy Avery <cavery@redhat.com>
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
---
 open-vm-tools/vgauth/serviceImpl/service.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/vgauth/serviceImpl/service.c b/vgauth/serviceImpl/service.c
index 6779530..d471652 100644
--- a/vgauth/serviceImpl/service.c
+++ b/vgauth/serviceImpl/service.c
@@ -1,5 +1,5 @@
 /*********************************************************
- * Copyright (C) 2011-2016 VMware, Inc. All rights reserved.
+ * Copyright (C) 2011-2016,2019 VMware, Inc. All rights reserved.
  *
  * This program is free software; you can redistribute it and/or modify it
  * under the terms of the GNU Lesser General Public License as published
@@ -173,6 +173,7 @@ ServiceCreatePublicConnection(ServiceConnection **returnConn) // OUT
 
    if (VGAUTH_E_OK != err) {
       Warning("%s: failed to setup public listen channel\n", __FUNCTION__);
+      ServiceConnectionShutdown(newConn);
       return err;
    }
 
-- 
1.8.3.1