From 13fe79c0a78028ccfe8e3d4e5ee16cfb9e143924 Mon Sep 17 00:00:00 2001
From: Sumit Bose <sbose@redhat.com>
Date: Wed, 2 Jun 2021 13:39:31 +0200
Subject: [PATCH 1/2] coverity: add missing NULL checks

---
 library/adenroll.c | 2 ++
 library/adldap.c   | 7 +++++++
 2 files changed, 9 insertions(+)

diff --git a/library/adenroll.c b/library/adenroll.c
index f693e58..c726093 100644
--- a/library/adenroll.c
+++ b/library/adenroll.c
@@ -3046,6 +3046,8 @@ adcli_enroll_set_keytab_enctypes (adcli_enroll *enroll,
 	krb5_enctype *newval = NULL;
 	int len;
 
+	return_if_fail (enroll != NULL);
+
 	if (value) {
 		for (len = 0; value[len] != 0; len++);
 		newval = malloc (sizeof (krb5_enctype) * (len + 1));
diff --git a/library/adldap.c b/library/adldap.c
index d93efb7..b86014c 100644
--- a/library/adldap.c
+++ b/library/adldap.c
@@ -231,6 +231,13 @@ _adcli_ldap_have_in_mod (LDAPMod *mod,
 
 	vals = malloc (sizeof (struct berval) * (count + 1));
 	pvals = malloc (sizeof (struct berval *) * (count + 1));
+	if (vals == NULL || pvals == NULL) {
+		_adcli_err ("Memory allocation failed, assuming attribute must be updated.");
+		free (vals);
+		free (pvals);
+		return 0;
+	}
+
 	for (i = 0; i < count; i++) {
 		vals[i].bv_val = mod->mod_vals.modv_strvals[i];
 		vals[i].bv_len = strlen (vals[i].bv_val);
-- 
2.31.1