|
 |
8fce16 |
From 3eb5445f6f7fa9f86de87adc768105d42bdbcf74 Mon Sep 17 00:00:00 2001
|
|
|
8fce16 |
From: Povilas Kanapickas <povilas@radix.lt>
|
|
|
8fce16 |
Date: Tue, 14 Dec 2021 15:00:01 +0200
|
|
|
8fce16 |
Subject: [PATCH xserver 2/4] xfixes: Fix out of bounds access in
|
|
|
8fce16 |
*ProcXFixesCreatePointerBarrier()
|
|
|
8fce16 |
|
|
|
8fce16 |
ZDI-CAN-14950, CVE-2021-4009
|
|
|
8fce16 |
|
|
|
8fce16 |
This vulnerability was discovered and the fix was suggested by:
|
|
|
8fce16 |
Jan-Niklas Sohn working with Trend Micro Zero Day Initiative
|
|
|
8fce16 |
|
|
|
8fce16 |
Signed-off-by: Povilas Kanapickas <povilas@radix.lt>
|
|
|
8fce16 |
(cherry picked from commit b5196750099ae6ae582e1f46bd0a6dad29550e02)
|
|
|
8fce16 |
---
|
|
|
8fce16 |
xfixes/cursor.c | 6 ++++--
|
|
|
8fce16 |
1 file changed, 4 insertions(+), 2 deletions(-)
|
|
|
8fce16 |
|
|
|
8fce16 |
diff --git a/xfixes/cursor.c b/xfixes/cursor.c
|
|
|
8fce16 |
index 60580b88f..c5d4554b2 100644
|
|
|
8fce16 |
--- a/xfixes/cursor.c
|
|
|
8fce16 |
+++ b/xfixes/cursor.c
|
|
|
8fce16 |
@@ -1010,7 +1010,8 @@ ProcXFixesCreatePointerBarrier(ClientPtr client)
|
|
|
8fce16 |
{
|
|
|
8fce16 |
REQUEST(xXFixesCreatePointerBarrierReq);
|
|
|
8fce16 |
|
|
|
8fce16 |
- REQUEST_FIXED_SIZE(xXFixesCreatePointerBarrierReq, pad_to_int32(stuff->num_devices));
|
|
|
8fce16 |
+ REQUEST_FIXED_SIZE(xXFixesCreatePointerBarrierReq,
|
|
|
8fce16 |
+ pad_to_int32(stuff->num_devices * sizeof(CARD16)));
|
|
|
8fce16 |
LEGAL_NEW_RESOURCE(stuff->barrier, client);
|
|
|
8fce16 |
|
|
|
8fce16 |
return XICreatePointerBarrier(client, stuff);
|
|
|
8fce16 |
@@ -1027,7 +1028,8 @@ SProcXFixesCreatePointerBarrier(ClientPtr client)
|
|
|
8fce16 |
|
|
|
8fce16 |
swaps(&stuff->length);
|
|
|
8fce16 |
swaps(&stuff->num_devices);
|
|
|
8fce16 |
- REQUEST_FIXED_SIZE(xXFixesCreatePointerBarrierReq, pad_to_int32(stuff->num_devices));
|
|
|
8fce16 |
+ REQUEST_FIXED_SIZE(xXFixesCreatePointerBarrierReq,
|
|
|
8fce16 |
+ pad_to_int32(stuff->num_devices * sizeof(CARD16)));
|
|
|
8fce16 |
|
|
|
8fce16 |
swapl(&stuff->barrier);
|
|
|
8fce16 |
swapl(&stuff->window);
|
|
|
8fce16 |
--
|
|
|
8fce16 |
2.33.1
|
|
|
8fce16 |
|