|
 |
b85204 |
From d6fc11c3f99f2f25b06d36d582d63702be802132 Mon Sep 17 00:00:00 2001
|
|
|
696189 |
From: "Richard W.M. Jones" <rjones@redhat.com>
|
|
|
696189 |
Date: Tue, 5 Jul 2022 11:56:54 +0100
|
|
|
696189 |
Subject: [PATCH] RHEL 9: -oo compressed: Remove nbdcopy version check and test
|
|
|
696189 |
|
|
|
696189 |
In RHEL 9 nbdcopy 1.12.4-2 will be sufficient (vs nbdcopy 1.13.5
|
|
|
696189 |
upstream). We will enforce this through RPM dependencies and test it
|
|
|
696189 |
separately. Thus remove the version check and test.
|
|
|
696189 |
---
|
|
|
696189 |
output/output.ml | 11 -----------
|
|
|
696189 |
tests/Makefile.am | 1 -
|
|
|
696189 |
2 files changed, 12 deletions(-)
|
|
|
696189 |
|
|
|
696189 |
diff --git a/output/output.ml b/output/output.ml
|
|
|
b85204 |
index e419c13d..c8f743c2 100644
|
|
|
696189 |
--- a/output/output.ml
|
|
|
696189 |
+++ b/output/output.ml
|
|
|
b85204 |
@@ -87,17 +87,6 @@ let output_to_local_file ?(changeuid = fun f -> f ()) ?(compressed = false)
|
|
|
696189 |
if output_format <> "qcow2" then
|
|
|
696189 |
error (f_"‘-oo compressed’ is only allowed when the output format \
|
|
|
696189 |
is a local qcow2-format file, i.e. ‘-of qcow2’");
|
|
|
696189 |
-
|
|
|
696189 |
- (* Check nbdcopy is new enough. This assumes that the version of
|
|
|
696189 |
- * libnbd is the same as the version of nbdcopy, but parsing this
|
|
|
696189 |
- * is easier. We can remove this check when we build-depend on
|
|
|
696189 |
- * libnbd >= 1.14.
|
|
|
696189 |
- *)
|
|
|
696189 |
- let version =
|
|
|
696189 |
- NBD.create () |> NBD.get_version |>
|
|
|
696189 |
- String.nsplit "." |> List.map int_of_string in
|
|
|
696189 |
- if version < [1; 13; 5] then
|
|
|
696189 |
- error (f_"-oo compressed option requires nbdcopy >= 1.13.5")
|
|
|
696189 |
);
|
|
|
696189 |
|
|
|
696189 |
let g = open_guestfs () in
|
|
|
696189 |
diff --git a/tests/Makefile.am b/tests/Makefile.am
|
|
|
b85204 |
index 998b871d..8cf17f94 100644
|
|
|
696189 |
--- a/tests/Makefile.am
|
|
|
696189 |
+++ b/tests/Makefile.am
|
|
|
b85204 |
@@ -83,7 +83,6 @@ TESTS = \
|
|
|
696189 |
test-v2v-networks-and-bridges.sh \
|
|
|
696189 |
test-v2v-o-glance.sh \
|
|
|
696189 |
test-v2v-o-libvirt.sh \
|
|
|
696189 |
- test-v2v-o-local-qcow2-compressed.sh \
|
|
|
696189 |
test-v2v-o-null.sh \
|
|
|
696189 |
test-v2v-o-openstack.sh \
|
|
|
696189 |
test-v2v-o-qemu.sh \
|