|
 |
05ad79 |
From bb147e4f4008b5debde0f87282967a5e52d2d50f Mon Sep 17 00:00:00 2001
|
|
|
05ad79 |
From: Karel Zak <kzak@redhat.com>
|
|
|
05ad79 |
Date: Tue, 7 Oct 2014 12:44:34 +0200
|
|
|
05ad79 |
Subject: [PATCH 181/185] libblkid: zeroize errno on blkid_probe_get_buffer()
|
|
|
05ad79 |
success
|
|
|
05ad79 |
|
|
|
05ad79 |
Since 37f4060225df0591ab8e1dd676dbc8115d900d4f prober functions are
|
|
|
05ad79 |
sensitive to errno, it seems more robust to set errno=0 with in
|
|
|
05ad79 |
blkid_probe_get_buffer() on success than set the zero on all places
|
|
|
05ad79 |
where we call blkid_probe_get_buffer().
|
|
|
05ad79 |
|
|
|
05ad79 |
Addresses: https://github.com/karelzak/util-linux/issues/119
|
|
|
05ad79 |
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1632944
|
|
|
05ad79 |
Upstream: http://github.com/karelzak/util-linux/commit/00749bc366fe6106df918660a92a388cfff4f35f
|
|
|
05ad79 |
Signed-off-by: Karel Zak <kzak@redhat.com>
|
|
|
05ad79 |
---
|
|
|
05ad79 |
libblkid/src/probe.c | 5 ++++-
|
|
|
05ad79 |
1 file changed, 4 insertions(+), 1 deletion(-)
|
|
|
05ad79 |
|
|
|
05ad79 |
diff --git a/libblkid/src/probe.c b/libblkid/src/probe.c
|
|
|
05ad79 |
index 07b08441f..ef0a72299 100644
|
|
|
05ad79 |
--- a/libblkid/src/probe.c
|
|
|
05ad79 |
+++ b/libblkid/src/probe.c
|
|
|
05ad79 |
@@ -529,8 +529,10 @@ unsigned char *blkid_probe_get_buffer(blkid_probe pr,
|
|
|
05ad79 |
struct list_head *p;
|
|
|
05ad79 |
struct blkid_bufinfo *bf = NULL;
|
|
|
05ad79 |
|
|
|
05ad79 |
- if (pr->size <= 0)
|
|
|
05ad79 |
+ if (pr->size <= 0) {
|
|
|
05ad79 |
+ errno = EINVAL;
|
|
|
05ad79 |
return NULL;
|
|
|
05ad79 |
+ }
|
|
|
05ad79 |
|
|
|
05ad79 |
if (pr->parent &&
|
|
|
05ad79 |
pr->parent->devno == pr->devno &&
|
|
|
05ad79 |
@@ -598,6 +600,7 @@ unsigned char *blkid_probe_get_buffer(blkid_probe pr,
|
|
|
05ad79 |
list_add_tail(&bf->bufs, &pr->buffers);
|
|
|
05ad79 |
}
|
|
|
05ad79 |
|
|
|
05ad79 |
+ errno = 0;
|
|
|
05ad79 |
return off ? bf->data + (off - bf->off) : bf->data;
|
|
|
05ad79 |
}
|
|
|
05ad79 |
|
|
|
05ad79 |
--
|
|
|
05ad79 |
2.20.1
|
|
|
05ad79 |
|