From 2cc3d747986837d7e7957f5a4baede2dd691348a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Lyson=C4=9Bk?= Date: Thu, 24 Jan 2019 16:28:24 +0100 Subject: [PATCH] plugin_disk: Fix checking the 'removable' attribute on python3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The 'removable' attribute is a bytestring, so it will never be equal to "0" in python3. Check equality with b"0" instead. The patch was originally written by Tomáš Korbař. Signed-off-by: Ondřej Lysoněk --- tuned/plugins/plugin_disk.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tuned/plugins/plugin_disk.py b/tuned/plugins/plugin_disk.py index 1de1257..65504d8 100644 --- a/tuned/plugins/plugin_disk.py +++ b/tuned/plugins/plugin_disk.py @@ -39,7 +39,7 @@ class DiskPlugin(hotplug.Plugin): @classmethod def _device_is_supported(cls, device): return device.device_type == "disk" and \ - device.attributes.get("removable", None) == "0" and \ + device.attributes.get("removable", None) == b"0" and \ (device.parent is None or \ device.parent.subsystem in ["scsi", "virtio", "xen"]) -- 2.20.1