|
 |
ff6046 |
From ac9c51b72213bcea3dc9cea330d4c5fce9c4470e Mon Sep 17 00:00:00 2001
|
|
|
ff6046 |
From: Riccardo Schirone <rschiron@redhat.com>
|
|
|
ff6046 |
Date: Mon, 4 Feb 2019 14:29:09 +0100
|
|
|
ff6046 |
Subject: [PATCH] Refuse dbus message paths longer than BUS_PATH_SIZE_MAX
|
|
|
ff6046 |
limit.
|
|
|
ff6046 |
|
|
|
ff6046 |
Even though the dbus specification does not enforce any length limit on the
|
|
|
ff6046 |
path of a dbus message, having to analyze too long strings in PID1 may be
|
|
|
ff6046 |
time-consuming and it may have security impacts.
|
|
|
ff6046 |
|
|
|
ff6046 |
In any case, the limit is set so high that real-life applications should not
|
|
|
ff6046 |
have a problem with it.
|
|
|
ff6046 |
|
|
|
ff6046 |
(cherry-picked from commit 61397a60d98e368a5720b37e83f3169e3eb511c4)
|
|
|
ff6046 |
|
|
|
ff6046 |
Related: #1678641
|
|
|
ff6046 |
---
|
|
|
ff6046 |
src/libsystemd/sd-bus/bus-internal.c | 2 +-
|
|
|
ff6046 |
src/libsystemd/sd-bus/bus-internal.h | 4 ++++
|
|
|
ff6046 |
2 files changed, 5 insertions(+), 1 deletion(-)
|
|
|
ff6046 |
|
|
|
ff6046 |
diff --git a/src/libsystemd/sd-bus/bus-internal.c b/src/libsystemd/sd-bus/bus-internal.c
|
|
|
ff6046 |
index 7bb653338d..35e0b668ee 100644
|
|
|
ff6046 |
--- a/src/libsystemd/sd-bus/bus-internal.c
|
|
|
ff6046 |
+++ b/src/libsystemd/sd-bus/bus-internal.c
|
|
|
ff6046 |
@@ -45,7 +45,7 @@ bool object_path_is_valid(const char *p) {
|
|
|
ff6046 |
if (slash)
|
|
|
ff6046 |
return false;
|
|
|
ff6046 |
|
|
|
ff6046 |
- return true;
|
|
|
ff6046 |
+ return (q - p) <= BUS_PATH_SIZE_MAX;
|
|
|
ff6046 |
}
|
|
|
ff6046 |
|
|
|
ff6046 |
char* object_path_startswith(const char *a, const char *b) {
|
|
|
ff6046 |
diff --git a/src/libsystemd/sd-bus/bus-internal.h b/src/libsystemd/sd-bus/bus-internal.h
|
|
|
ff6046 |
index 2087ef8eeb..90e6028983 100644
|
|
|
ff6046 |
--- a/src/libsystemd/sd-bus/bus-internal.h
|
|
|
ff6046 |
+++ b/src/libsystemd/sd-bus/bus-internal.h
|
|
|
ff6046 |
@@ -333,6 +333,10 @@ struct sd_bus {
|
|
|
ff6046 |
|
|
|
ff6046 |
#define BUS_MESSAGE_SIZE_MAX (128*1024*1024)
|
|
|
ff6046 |
#define BUS_AUTH_SIZE_MAX (64*1024)
|
|
|
ff6046 |
+/* Note that the D-Bus specification states that bus paths shall have no size limit. We enforce here one
|
|
|
ff6046 |
+ * anyway, since truly unbounded strings are a security problem. The limit we pick is relatively large however,
|
|
|
ff6046 |
+ * to not clash unnecessarily with real-life applications. */
|
|
|
ff6046 |
+#define BUS_PATH_SIZE_MAX (64*1024)
|
|
|
ff6046 |
|
|
|
ff6046 |
#define BUS_CONTAINER_DEPTH 128
|
|
|
ff6046 |
|