|
Harald Hoyer |
db3a9f |
From 2c284b172a7474731df01a7c3280e30de844ba75 Mon Sep 17 00:00:00 2001
|
|
Harald Hoyer |
db3a9f |
From: George McCollister <george.mccollister@gmail.com>
|
|
Harald Hoyer |
db3a9f |
Date: Wed, 4 Sep 2013 07:12:43 -0500
|
|
Harald Hoyer |
db3a9f |
Subject: [PATCH] journald: fix vacuuming of archived journals
|
|
Harald Hoyer |
db3a9f |
|
|
Harald Hoyer |
db3a9f |
d_name is modified on line 227 so if the entire journal name is needed
|
|
Harald Hoyer |
db3a9f |
again p must be used. Before this change when journal_file_empty was called
|
|
Harald Hoyer |
db3a9f |
on archived journals it would always return with -2.
|
|
Harald Hoyer |
db3a9f |
|
|
Harald Hoyer |
db3a9f |
Signed-off-by: George McCollister <george.mccollister@gmail.com>
|
|
Harald Hoyer |
db3a9f |
---
|
|
Harald Hoyer |
db3a9f |
src/journal/journal-vacuum.c | 10 +++++-----
|
|
Harald Hoyer |
db3a9f |
1 file changed, 5 insertions(+), 5 deletions(-)
|
|
Harald Hoyer |
db3a9f |
|
|
Harald Hoyer |
db3a9f |
diff --git a/src/journal/journal-vacuum.c b/src/journal/journal-vacuum.c
|
|
Harald Hoyer |
db3a9f |
index 79572f1..ace7722 100644
|
|
Harald Hoyer |
db3a9f |
--- a/src/journal/journal-vacuum.c
|
|
Harald Hoyer |
db3a9f |
+++ b/src/journal/journal-vacuum.c
|
|
Harald Hoyer |
db3a9f |
@@ -265,18 +265,18 @@ int journal_directory_vacuum(
|
|
Harald Hoyer |
db3a9f |
/* We do not vacuum active files or unknown files! */
|
|
Harald Hoyer |
db3a9f |
continue;
|
|
Harald Hoyer |
db3a9f |
|
|
Harald Hoyer |
db3a9f |
- if (journal_file_empty(dirfd(d), de->d_name)) {
|
|
Harald Hoyer |
db3a9f |
+ if (journal_file_empty(dirfd(d), p)) {
|
|
Harald Hoyer |
db3a9f |
|
|
Harald Hoyer |
db3a9f |
/* Always vacuum empty non-online files. */
|
|
Harald Hoyer |
db3a9f |
|
|
Harald Hoyer |
db3a9f |
- if (unlinkat(dirfd(d), de->d_name, 0) >= 0)
|
|
Harald Hoyer |
db3a9f |
- log_debug("Deleted empty journal %s/%s.", directory, de->d_name);
|
|
Harald Hoyer |
db3a9f |
+ if (unlinkat(dirfd(d), p, 0) >= 0)
|
|
Harald Hoyer |
db3a9f |
+ log_debug("Deleted empty journal %s/%s.", directory, p);
|
|
Harald Hoyer |
db3a9f |
else if (errno != ENOENT)
|
|
Harald Hoyer |
db3a9f |
- log_warning("Failed to delete %s/%s: %m", directory, de->d_name);
|
|
Harald Hoyer |
db3a9f |
+ log_warning("Failed to delete %s/%s: %m", directory, p);
|
|
Harald Hoyer |
db3a9f |
continue;
|
|
Harald Hoyer |
db3a9f |
}
|
|
Harald Hoyer |
db3a9f |
|
|
Harald Hoyer |
db3a9f |
- patch_realtime(directory, de->d_name, &st, &realtime);
|
|
Harald Hoyer |
db3a9f |
+ patch_realtime(directory, p, &st, &realtime);
|
|
Harald Hoyer |
db3a9f |
|
|
Harald Hoyer |
db3a9f |
GREEDY_REALLOC(list, n_allocated, n_list + 1);
|
|
Harald Hoyer |
db3a9f |
|