Blame SOURCES/0096-KCM-Return-a-valid-tevent-error-code-if-a-request-ca.patch
|
 |
71e593 |
From 334950e4b352ffa3a672f30f62b478c69690c830 Mon Sep 17 00:00:00 2001
|
|
|
71e593 |
From: Jakub Hrozek <jhrozek@redhat.com>
|
|
|
71e593 |
Date: Wed, 16 Jan 2019 13:06:10 +0100
|
|
|
71e593 |
Subject: [PATCH 96/99] KCM: Return a valid tevent error code if a request
|
|
|
71e593 |
cannot be created
|
|
|
71e593 |
MIME-Version: 1.0
|
|
|
71e593 |
Content-Type: text/plain; charset=UTF-8
|
|
|
71e593 |
Content-Transfer-Encoding: 8bit
|
|
|
71e593 |
|
|
|
71e593 |
Previously we were returning whatever was in 'ret' which is wrong,
|
|
|
71e593 |
typically it would have been EOK as returned from a previous successfull
|
|
|
71e593 |
call or even an uninitialized value.
|
|
|
71e593 |
|
|
|
71e593 |
Reviewed-by: Michal Židek <mzidek@redhat.com>
|
|
|
71e593 |
Reviewed-by: Simo Sorce <simo@redhat.com>
|
|
|
71e593 |
---
|
|
|
71e593 |
src/responder/kcm/kcmsrv_ops.c | 2 +-
|
|
|
71e593 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
71e593 |
|
|
|
71e593 |
diff --git a/src/responder/kcm/kcmsrv_ops.c b/src/responder/kcm/kcmsrv_ops.c
|
|
|
71e593 |
index 9352909f4..60b5677e9 100644
|
|
|
71e593 |
--- a/src/responder/kcm/kcmsrv_ops.c
|
|
|
71e593 |
+++ b/src/responder/kcm/kcmsrv_ops.c
|
|
|
71e593 |
@@ -527,7 +527,7 @@ static void kcm_op_initialize_create_step(struct tevent_req *req)
|
|
|
71e593 |
state->op_ctx->client,
|
|
|
71e593 |
state->new_cc);
|
|
|
71e593 |
if (subreq == NULL) {
|
|
|
71e593 |
- tevent_req_error(req, ret);
|
|
|
71e593 |
+ tevent_req_error(req, ENOMEM);
|
|
|
71e593 |
return;
|
|
|
71e593 |
}
|
|
|
71e593 |
tevent_req_set_callback(subreq, kcm_op_initialize_cc_create_done, req);
|
|
|
71e593 |
--
|
|
|
71e593 |
2.19.1
|
|
|
71e593 |
|