|
 |
bd4b98 |
From a40b25a3af29706c058ce5a02dd0ba294dbb6874 Mon Sep 17 00:00:00 2001
|
|
|
bd4b98 |
From: Alexey Tikhonov <atikhono@redhat.com>
|
|
|
bd4b98 |
Date: Wed, 8 Feb 2023 17:48:52 +0100
|
|
|
bd4b98 |
Subject: [PATCH 3/4] SSS_CLIENT: if poll() returns POLLNVAL then socket is
|
|
|
bd4b98 |
alredy closed (or wasn't open) so it shouldn't be closed again. Otherwise
|
|
|
bd4b98 |
there is a risk to close "foreign" socket opened in another thread.
|
|
|
bd4b98 |
MIME-Version: 1.0
|
|
|
bd4b98 |
Content-Type: text/plain; charset=UTF-8
|
|
|
bd4b98 |
Content-Transfer-Encoding: 8bit
|
|
|
bd4b98 |
|
|
|
bd4b98 |
Reviewed-by: Pavel Březina <pbrezina@redhat.com>
|
|
|
bd4b98 |
Reviewed-by: Sumit Bose <sbose@redhat.com>
|
|
|
bd4b98 |
(cherry picked from commit ef93284b5a1f196425d9a61e8e24de8972240eb3)
|
|
|
bd4b98 |
---
|
|
|
bd4b98 |
src/sss_client/common.c | 18 +++++++++++++++---
|
|
|
bd4b98 |
1 file changed, 15 insertions(+), 3 deletions(-)
|
|
|
bd4b98 |
|
|
|
bd4b98 |
diff --git a/src/sss_client/common.c b/src/sss_client/common.c
|
|
|
bd4b98 |
index 27e09f6f3..c8ade645b 100644
|
|
|
bd4b98 |
--- a/src/sss_client/common.c
|
|
|
bd4b98 |
+++ b/src/sss_client/common.c
|
|
|
bd4b98 |
@@ -159,7 +159,11 @@ static enum sss_status sss_cli_send_req(enum sss_cli_command cmd,
|
|
|
bd4b98 |
*errnop = ETIME;
|
|
|
bd4b98 |
break;
|
|
|
bd4b98 |
case 1:
|
|
|
bd4b98 |
- if (pfd.revents & (POLLERR | POLLHUP | POLLNVAL)) {
|
|
|
bd4b98 |
+ if (pfd.revents & (POLLERR | POLLHUP)) {
|
|
|
bd4b98 |
+ *errnop = EPIPE;
|
|
|
bd4b98 |
+ } else if (pfd.revents & POLLNVAL) {
|
|
|
bd4b98 |
+ /* Invalid request: fd is not opened */
|
|
|
bd4b98 |
+ sss_cli_sd = -1;
|
|
|
bd4b98 |
*errnop = EPIPE;
|
|
|
bd4b98 |
} else if (!(pfd.revents & POLLOUT)) {
|
|
|
bd4b98 |
*errnop = EBUSY;
|
|
|
bd4b98 |
@@ -270,7 +274,11 @@ static enum sss_status sss_cli_recv_rep(enum sss_cli_command cmd,
|
|
|
bd4b98 |
if (pfd.revents & (POLLHUP)) {
|
|
|
bd4b98 |
pollhup = true;
|
|
|
bd4b98 |
}
|
|
|
bd4b98 |
- if (pfd.revents & (POLLERR | POLLNVAL)) {
|
|
|
bd4b98 |
+ if (pfd.revents & POLLERR) {
|
|
|
bd4b98 |
+ *errnop = EPIPE;
|
|
|
bd4b98 |
+ } else if (pfd.revents & POLLNVAL) {
|
|
|
bd4b98 |
+ /* Invalid request: fd is not opened */
|
|
|
bd4b98 |
+ sss_cli_sd = -1;
|
|
|
bd4b98 |
*errnop = EPIPE;
|
|
|
bd4b98 |
} else if (!(pfd.revents & POLLIN)) {
|
|
|
bd4b98 |
*errnop = EBUSY;
|
|
|
bd4b98 |
@@ -721,7 +729,11 @@ static enum sss_status sss_cli_check_socket(int *errnop,
|
|
|
bd4b98 |
*errnop = ETIME;
|
|
|
bd4b98 |
break;
|
|
|
bd4b98 |
case 1:
|
|
|
bd4b98 |
- if (pfd.revents & (POLLERR | POLLHUP | POLLNVAL)) {
|
|
|
bd4b98 |
+ if (pfd.revents & (POLLERR | POLLHUP)) {
|
|
|
bd4b98 |
+ *errnop = EPIPE;
|
|
|
bd4b98 |
+ } else if (pfd.revents & POLLNVAL) {
|
|
|
bd4b98 |
+ /* Invalid request: fd is not opened */
|
|
|
bd4b98 |
+ sss_cli_sd = -1;
|
|
|
bd4b98 |
*errnop = EPIPE;
|
|
|
bd4b98 |
} else if (!(pfd.revents & (POLLIN | POLLOUT))) {
|
|
|
bd4b98 |
*errnop = EBUSY;
|
|
|
bd4b98 |
--
|
|
|
bd4b98 |
2.37.3
|
|
|
bd4b98 |
|