|
 |
bd4b98 |
From f3333b9dbeda33a9344b458accaa4ff372adb660 Mon Sep 17 00:00:00 2001
|
|
|
bd4b98 |
From: Alexey Tikhonov <atikhono@redhat.com>
|
|
|
bd4b98 |
Date: Fri, 3 Feb 2023 11:35:42 +0100
|
|
|
bd4b98 |
Subject: [PATCH 2/4] SSS_CLIENT: fix error codes returned by common
|
|
|
bd4b98 |
read/write/check helpers.
|
|
|
bd4b98 |
MIME-Version: 1.0
|
|
|
bd4b98 |
Content-Type: text/plain; charset=UTF-8
|
|
|
bd4b98 |
Content-Transfer-Encoding: 8bit
|
|
|
bd4b98 |
|
|
|
bd4b98 |
It's kind of expected that in case `(POLLERR | POLLHUP | POLLNVAL)`
|
|
|
bd4b98 |
error condition is detected, regular `POLLIN/POLLOUT` won't be set.
|
|
|
bd4b98 |
Error code set by error condition should have a priority. This enables
|
|
|
bd4b98 |
users of this helper to retry attempt (as designed).
|
|
|
bd4b98 |
|
|
|
bd4b98 |
Reviewed-by: Pavel Březina <pbrezina@redhat.com>
|
|
|
bd4b98 |
Reviewed-by: Sumit Bose <sbose@redhat.com>
|
|
|
bd4b98 |
(cherry picked from commit 0b8638d8de435384562f17d041655887b73523cd)
|
|
|
bd4b98 |
---
|
|
|
bd4b98 |
src/sss_client/common.c | 9 +++------
|
|
|
bd4b98 |
1 file changed, 3 insertions(+), 6 deletions(-)
|
|
|
bd4b98 |
|
|
|
bd4b98 |
diff --git a/src/sss_client/common.c b/src/sss_client/common.c
|
|
|
bd4b98 |
index 2c888faa9..27e09f6f3 100644
|
|
|
bd4b98 |
--- a/src/sss_client/common.c
|
|
|
bd4b98 |
+++ b/src/sss_client/common.c
|
|
|
bd4b98 |
@@ -161,8 +161,7 @@ static enum sss_status sss_cli_send_req(enum sss_cli_command cmd,
|
|
|
bd4b98 |
case 1:
|
|
|
bd4b98 |
if (pfd.revents & (POLLERR | POLLHUP | POLLNVAL)) {
|
|
|
bd4b98 |
*errnop = EPIPE;
|
|
|
bd4b98 |
- }
|
|
|
bd4b98 |
- if (!(pfd.revents & POLLOUT)) {
|
|
|
bd4b98 |
+ } else if (!(pfd.revents & POLLOUT)) {
|
|
|
bd4b98 |
*errnop = EBUSY;
|
|
|
bd4b98 |
}
|
|
|
bd4b98 |
break;
|
|
|
bd4b98 |
@@ -273,8 +272,7 @@ static enum sss_status sss_cli_recv_rep(enum sss_cli_command cmd,
|
|
|
bd4b98 |
}
|
|
|
bd4b98 |
if (pfd.revents & (POLLERR | POLLNVAL)) {
|
|
|
bd4b98 |
*errnop = EPIPE;
|
|
|
bd4b98 |
- }
|
|
|
bd4b98 |
- if (!(pfd.revents & POLLIN)) {
|
|
|
bd4b98 |
+ } else if (!(pfd.revents & POLLIN)) {
|
|
|
bd4b98 |
*errnop = EBUSY;
|
|
|
bd4b98 |
}
|
|
|
bd4b98 |
break;
|
|
|
bd4b98 |
@@ -725,8 +723,7 @@ static enum sss_status sss_cli_check_socket(int *errnop,
|
|
|
bd4b98 |
case 1:
|
|
|
bd4b98 |
if (pfd.revents & (POLLERR | POLLHUP | POLLNVAL)) {
|
|
|
bd4b98 |
*errnop = EPIPE;
|
|
|
bd4b98 |
- }
|
|
|
bd4b98 |
- if (!(pfd.revents & (POLLIN | POLLOUT))) {
|
|
|
bd4b98 |
+ } else if (!(pfd.revents & (POLLIN | POLLOUT))) {
|
|
|
bd4b98 |
*errnop = EBUSY;
|
|
|
bd4b98 |
}
|
|
|
bd4b98 |
break;
|
|
|
bd4b98 |
--
|
|
|
bd4b98 |
2.37.3
|
|
|
bd4b98 |
|