Mark Wielaard 434eb9
From d406bde3e914cae2d794bbaab66aad6b7038b30e Mon Sep 17 00:00:00 2001
Mark Wielaard 434eb9
From: Mark Wielaard <mark@klomp.org>
Mark Wielaard 434eb9
Date: Fri, 17 Mar 2017 10:51:36 +0100
Mark Wielaard 434eb9
Subject: [PATCH] build/files.c (processPackageFiles): Don't call
Mark Wielaard 434eb9
 generateBuildIDs for noarch.
Mark Wielaard 434eb9
Mark Wielaard 434eb9
We don't want to do build-id processing for noarch packages. It might be
Mark Wielaard 434eb9
that noarch packages do contain architecture depended files, but those are
Mark Wielaard 434eb9
already handled by processBinaryFiles.
Mark Wielaard 434eb9
Mark Wielaard 434eb9
Signed-off-by: Mark Wielaard <mark@klomp.org>
Mark Wielaard 434eb9
---
Mark Wielaard 434eb9
 build/files.c | 12 ++++++++----
Mark Wielaard 434eb9
 1 file changed, 8 insertions(+), 4 deletions(-)
Mark Wielaard 434eb9
Mark Wielaard 434eb9
diff --git a/build/files.c b/build/files.c
Mark Wielaard 434eb9
index 6021643..35b2dd0 100644
Mark Wielaard 434eb9
--- a/build/files.c
Mark Wielaard 434eb9
+++ b/build/files.c
Mark Wielaard 434eb9
@@ -2384,10 +2384,14 @@ static rpmRC processPackageFiles(rpmSpec spec, rpmBuildPkgFlags pkgFlags,
Mark Wielaard 434eb9
 	goto exit;
Mark Wielaard 434eb9
 
Mark Wielaard 434eb9
 #if HAVE_LIBDW
Mark Wielaard 434eb9
-    if (generateBuildIDs (&fl) != 0) {
Mark Wielaard 434eb9
-	rpmlog(RPMLOG_ERR, _("Generating build-id links failed\n"));
Mark Wielaard 434eb9
-	fl.processingFailed = 1;
Mark Wielaard 434eb9
-	goto exit;
Mark Wielaard 434eb9
+    /* Check build-ids and add build-ids links for files to package list. */
Mark Wielaard 434eb9
+    const char *arch = headerGetString(pkg->header, RPMTAG_ARCH);
Mark Wielaard 434eb9
+    if (!rstreq(arch, "noarch")) {
Mark Wielaard 434eb9
+	if (generateBuildIDs (&fl) != 0) {
Mark Wielaard 434eb9
+	    rpmlog(RPMLOG_ERR, _("Generating build-id links failed\n"));
Mark Wielaard 434eb9
+	    fl.processingFailed = 1;
Mark Wielaard 434eb9
+	    goto exit;
Mark Wielaard 434eb9
+	}
Mark Wielaard 434eb9
     }
Mark Wielaard 434eb9
 #endif
Mark Wielaard 434eb9
 
Mark Wielaard 434eb9
-- 
Mark Wielaard 434eb9
1.8.3.1
Mark Wielaard 434eb9