|
 |
d9e469 |
From 17f4e17d9870fbd35572ae6bf6c227c787b07fe9 Mon Sep 17 00:00:00 2001
|
|
|
d9e469 |
From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
|
|
|
d9e469 |
Date: Fri, 5 Feb 2016 15:15:18 -0200
|
|
|
d9e469 |
Subject: [PATCH 4/5] mce-intel-knl: Fix CodingStyle
|
|
|
d9e469 |
|
|
|
d9e469 |
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
|
|
|
d9e469 |
---
|
|
|
d9e469 |
mce-intel-knl.c | 43 +++++++++++++++++++++++++++----------------
|
|
|
d9e469 |
1 file changed, 27 insertions(+), 16 deletions(-)
|
|
|
d9e469 |
|
|
|
d9e469 |
diff --git a/mce-intel-knl.c b/mce-intel-knl.c
|
|
|
d9e469 |
index 96b0a59..7062fbb 100644
|
|
|
d9e469 |
--- a/mce-intel-knl.c
|
|
|
d9e469 |
+++ b/mce-intel-knl.c
|
|
|
d9e469 |
@@ -48,32 +48,46 @@ void knl_decode_model(struct ras_events *ras, struct mce_event *e)
|
|
|
d9e469 |
mce_snprintf(e->mcastatus_msg, "VCU Internal Errors");
|
|
|
d9e469 |
break;
|
|
|
d9e469 |
case 0x407:
|
|
|
d9e469 |
- mce_snprintf(e->mcastatus_msg, "Other UBOX Internal Errors");
|
|
|
d9e469 |
+ mce_snprintf(e->mcastatus_msg,
|
|
|
d9e469 |
+ "Other UBOX Internal Errors");
|
|
|
d9e469 |
break;
|
|
|
d9e469 |
}
|
|
|
d9e469 |
break;
|
|
|
d9e469 |
- case 7: case 8: case 9: case 10:
|
|
|
d9e469 |
- case 11: case 12: case 13: case 14:
|
|
|
d9e469 |
- case 15: case 16:
|
|
|
d9e469 |
+ case 7:
|
|
|
d9e469 |
+ case 8:
|
|
|
d9e469 |
+ case 9:
|
|
|
d9e469 |
+ case 10:
|
|
|
d9e469 |
+ case 11:
|
|
|
d9e469 |
+ case 12:
|
|
|
d9e469 |
+ case 13:
|
|
|
d9e469 |
+ case 14:
|
|
|
d9e469 |
+ case 15:
|
|
|
d9e469 |
+ case 16:
|
|
|
d9e469 |
if ((EXTRACT(status, 0, 15)) == 0x5) {
|
|
|
d9e469 |
mce_snprintf(e->mcastatus_msg, "Internal Parity error");
|
|
|
d9e469 |
} else {
|
|
|
d9e469 |
chan = (EXTRACT(status, 0, 3)) + 3 * (e->bank == 15);
|
|
|
d9e469 |
switch (EXTRACT(status, 4, 7)) {
|
|
|
d9e469 |
case 0x0:
|
|
|
d9e469 |
- mce_snprintf(e->mcastatus_msg, "Undefined request on channel %d", chan);
|
|
|
d9e469 |
+ mce_snprintf(e->mcastatus_msg,
|
|
|
d9e469 |
+ "Undefined request on channel %d",
|
|
|
d9e469 |
+ chan);
|
|
|
d9e469 |
break;
|
|
|
d9e469 |
case 0x1:
|
|
|
d9e469 |
- mce_snprintf(e->mcastatus_msg, "Read on channel %d", chan);
|
|
|
d9e469 |
+ mce_snprintf(e->mcastatus_msg,
|
|
|
d9e469 |
+ "Read on channel %d", chan);
|
|
|
d9e469 |
break;
|
|
|
d9e469 |
case 0x2:
|
|
|
d9e469 |
- mce_snprintf(e->mcastatus_msg, "Write on channel %d", chan);
|
|
|
d9e469 |
+ mce_snprintf(e->mcastatus_msg,
|
|
|
d9e469 |
+ "Write on channel %d", chan);
|
|
|
d9e469 |
break;
|
|
|
d9e469 |
case 0x3:
|
|
|
d9e469 |
- mce_snprintf(e->mcastatus_msg, "CA error on channel %d", chan);
|
|
|
d9e469 |
+ mce_snprintf(e->mcastatus_msg,
|
|
|
d9e469 |
+ "CA error on channel %d", chan);
|
|
|
d9e469 |
break;
|
|
|
d9e469 |
case 0x4:
|
|
|
d9e469 |
- mce_snprintf(e->mcastatus_msg, "Scrub error on channel %d", chan);
|
|
|
d9e469 |
+ mce_snprintf(e->mcastatus_msg,
|
|
|
d9e469 |
+ "Scrub error on channel %d", chan);
|
|
|
d9e469 |
break;
|
|
|
d9e469 |
}
|
|
|
d9e469 |
}
|
|
|
d9e469 |
@@ -93,7 +107,7 @@ void knl_decode_model(struct ras_events *ras, struct mce_event *e)
|
|
|
d9e469 |
|
|
|
d9e469 |
/* Ignore unless this is an corrected extended error from an iMC bank */
|
|
|
d9e469 |
if (e->bank < 7 || e->bank > 16 || (status & MCI_STATUS_UC) ||
|
|
|
d9e469 |
- !test_prefix(7, status & 0xefff))
|
|
|
d9e469 |
+ !test_prefix(7, status & 0xefff))
|
|
|
d9e469 |
return;
|
|
|
d9e469 |
|
|
|
d9e469 |
/*
|
|
|
d9e469 |
@@ -101,12 +115,9 @@ void knl_decode_model(struct ras_events *ras, struct mce_event *e)
|
|
|
d9e469 |
*/
|
|
|
d9e469 |
|
|
|
d9e469 |
chan = EXTRACT(status, 0, 3);
|
|
|
d9e469 |
- if (chan == 0xf)
|
|
|
d9e469 |
- {
|
|
|
d9e469 |
+ if (chan == 0xf) {
|
|
|
d9e469 |
mce_snprintf(e->mc_location, "memory_channel=unspecified");
|
|
|
d9e469 |
- }
|
|
|
d9e469 |
- else
|
|
|
d9e469 |
- {
|
|
|
d9e469 |
+ } else {
|
|
|
d9e469 |
chan = chan + 3 * (e->bank == 15);
|
|
|
d9e469 |
mce_snprintf(e->mc_location, "memory_channel=%d", chan);
|
|
|
d9e469 |
|
|
|
d9e469 |
@@ -121,7 +132,7 @@ void knl_decode_model(struct ras_events *ras, struct mce_event *e)
|
|
|
d9e469 |
*/
|
|
|
d9e469 |
if (rank0 != -1 && rank1 != -1)
|
|
|
d9e469 |
mce_snprintf(e->mc_location, "ranks=%d and %d",
|
|
|
d9e469 |
- rank0, rank1);
|
|
|
d9e469 |
+ rank0, rank1);
|
|
|
d9e469 |
else if (rank0 != -1)
|
|
|
d9e469 |
mce_snprintf(e->mc_location, "rank=%d", rank0);
|
|
|
d9e469 |
}
|
|
|
d9e469 |
--
|
|
|
d9e469 |
1.8.3.1
|
|
|
d9e469 |
|