|
 |
298366 |
From 8b4b3a71fd35d67c5c30652a120c0a59dfab7182 Mon Sep 17 00:00:00 2001
|
|
|
9e0a86 |
From: Cole Robinson <crobinso@redhat.com>
|
|
|
298366 |
Date: Sat, 31 Aug 2013 18:36:17 -0400
|
|
|
9e0a86 |
Subject: [PATCH] qapi-types.py: Fix enum struct sizes on i686
|
|
|
9e0a86 |
|
|
|
9e0a86 |
Unlike other list types, enum wasn't adding any padding, which caused
|
|
|
9e0a86 |
a mismatch between the generated struct size and GenericList struct
|
|
|
9e0a86 |
size. More details in a678e26cbe89f7a27cbce794c2c2784571ee9d21
|
|
|
9e0a86 |
|
|
|
9e0a86 |
This crashed qemu if calling qmp query-tpm-types for example, which
|
|
|
9e0a86 |
upsets libvirt capabilities probing. Reproducer on i686:
|
|
|
9e0a86 |
|
|
|
9e0a86 |
(sleep 5; printf '{"execute":"qmp_capabilities"}\n{"execute":"query-tpm-types"}\n') | ./i386-softmmu/qemu-system-i386 -S -nodefaults -nographic -M none -qmp stdio
|
|
|
9e0a86 |
|
|
|
9e0a86 |
https://bugs.launchpad.net/qemu/+bug/1219207
|
|
|
9e0a86 |
|
|
|
9e0a86 |
Cc: qemu-stable@nongnu.org
|
|
|
298366 |
Signed-off-by: Cole Robinson <crobinso@redhat.com>
|
|
|
298366 |
Reviewed-by: Eric Blake <eblake@redhat.com>
|
|
|
298366 |
Tested-by: Richard W.M. Jones <rjones@redhat.com>
|
|
|
298366 |
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
|
|
|
298366 |
(cherry picked from commit 02dc4bf5684d3fb46786fab2ecff98214b1df9fe)
|
|
|
298366 |
|
|
|
298366 |
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
|
|
|
9e0a86 |
---
|
|
|
9e0a86 |
scripts/qapi-types.py | 5 ++++-
|
|
|
9e0a86 |
1 file changed, 4 insertions(+), 1 deletion(-)
|
|
|
9e0a86 |
|
|
|
9e0a86 |
diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py
|
|
|
9e0a86 |
index 5ee46ea..5d31b06 100644
|
|
|
9e0a86 |
--- a/scripts/qapi-types.py
|
|
|
9e0a86 |
+++ b/scripts/qapi-types.py
|
|
|
9e0a86 |
@@ -51,7 +51,10 @@ def generate_fwd_enum_struct(name, members):
|
|
|
9e0a86 |
return mcgen('''
|
|
|
9e0a86 |
typedef struct %(name)sList
|
|
|
9e0a86 |
{
|
|
|
9e0a86 |
- %(name)s value;
|
|
|
9e0a86 |
+ union {
|
|
|
9e0a86 |
+ %(name)s value;
|
|
|
9e0a86 |
+ uint64_t padding;
|
|
|
9e0a86 |
+ };
|
|
|
9e0a86 |
struct %(name)sList *next;
|
|
|
9e0a86 |
} %(name)sList;
|
|
|
9e0a86 |
''',
|