|
 |
9ae3a8 |
From 0dadf0b76c9236d048c203fb5b9baaf3fe6fac15 Mon Sep 17 00:00:00 2001
|
|
|
9ae3a8 |
From: Alex Williamson <alex.williamson@redhat.com>
|
|
|
9ae3a8 |
Date: Fri, 29 Sep 2017 21:45:44 +0200
|
|
|
9ae3a8 |
Subject: [PATCH 12/27] vfio/pci: Fix incorrect error message
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
RH-Author: Alex Williamson <alex.williamson@redhat.com>
|
|
|
9ae3a8 |
Message-id: <20170929214544.16765.85472.stgit@gimli.home>
|
|
|
9ae3a8 |
Patchwork-id: 76770
|
|
|
9ae3a8 |
O-Subject: [RHEL-7.5 qemu-kvm PATCH 12/16] vfio/pci: Fix incorrect error message
|
|
|
9ae3a8 |
Bugzilla: 1494181
|
|
|
9ae3a8 |
RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Auger Eric <eric.auger@redhat.com>
|
|
|
9ae3a8 |
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
From: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Upstream: 6e4e6f0d403b1fb25f9dfdbe17754c643997753d
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
When the "No host device provided" error occurs, the hint message
|
|
|
9ae3a8 |
that starts with "Use -vfio-pci," makes no sense, since "-vfio-pci"
|
|
|
9ae3a8 |
is not a valid command line parameter.
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Correct this by replacing "-vfio-pci" with "-device vfio-pci".
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
Signed-off-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
|
|
|
9ae3a8 |
Reviewed-by: Eric Auger <eric.auger@redhat.com>
|
|
|
9ae3a8 |
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
|
|
|
9ae3a8 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
9ae3a8 |
---
|
|
|
9ae3a8 |
hw/misc/vfio.c | 4 ++--
|
|
|
9ae3a8 |
1 file changed, 2 insertions(+), 2 deletions(-)
|
|
|
9ae3a8 |
|
|
|
9ae3a8 |
diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c
|
|
|
9ae3a8 |
index a95bbaf..e2dc3f5 100644
|
|
|
9ae3a8 |
--- a/hw/misc/vfio.c
|
|
|
9ae3a8 |
+++ b/hw/misc/vfio.c
|
|
|
9ae3a8 |
@@ -3867,8 +3867,8 @@ static int vfio_initfn(PCIDevice *pdev)
|
|
|
9ae3a8 |
if (!(~vdev->host.domain || ~vdev->host.bus ||
|
|
|
9ae3a8 |
~vdev->host.slot || ~vdev->host.function)) {
|
|
|
9ae3a8 |
error_report("No provided host device - "
|
|
|
9ae3a8 |
- "Use -vfio-pci,host=DDDD:BB:DD.F "
|
|
|
9ae3a8 |
- "or -vfio-pci,sysfsdev=PATH_TO_DEVICE");
|
|
|
9ae3a8 |
+ "Use -device vfio-pci,host=DDDD:BB:DD.F "
|
|
|
9ae3a8 |
+ "or -device vfio-pci,sysfsdev=PATH_TO_DEVICE");
|
|
|
9ae3a8 |
return -EINVAL;
|
|
|
9ae3a8 |
}
|
|
|
9ae3a8 |
vdev->vbasedev.sysfsdev =
|
|
|
9ae3a8 |
--
|
|
|
9ae3a8 |
1.8.3.1
|
|
|
9ae3a8 |
|