5d360b
From 0dadf0b76c9236d048c203fb5b9baaf3fe6fac15 Mon Sep 17 00:00:00 2001
5d360b
From: Alex Williamson <alex.williamson@redhat.com>
5d360b
Date: Fri, 29 Sep 2017 21:45:44 +0200
5d360b
Subject: [PATCH 12/27] vfio/pci: Fix incorrect error message
5d360b
5d360b
RH-Author: Alex Williamson <alex.williamson@redhat.com>
5d360b
Message-id: <20170929214544.16765.85472.stgit@gimli.home>
5d360b
Patchwork-id: 76770
5d360b
O-Subject: [RHEL-7.5 qemu-kvm PATCH 12/16] vfio/pci: Fix incorrect error message
5d360b
Bugzilla: 1494181
5d360b
RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>
5d360b
RH-Acked-by: Auger Eric <eric.auger@redhat.com>
5d360b
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
5d360b
5d360b
From: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
5d360b
5d360b
Upstream: 6e4e6f0d403b1fb25f9dfdbe17754c643997753d
5d360b
5d360b
When the "No host device provided" error occurs, the hint message
5d360b
that starts with "Use -vfio-pci," makes no sense, since "-vfio-pci"
5d360b
is not a valid command line parameter.
5d360b
5d360b
Correct this by replacing "-vfio-pci" with "-device vfio-pci".
5d360b
5d360b
Signed-off-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
5d360b
Reviewed-by: Eric Auger <eric.auger@redhat.com>
5d360b
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
5d360b
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
5d360b
---
5d360b
 hw/misc/vfio.c | 4 ++--
5d360b
 1 file changed, 2 insertions(+), 2 deletions(-)
5d360b
5d360b
diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c
5d360b
index a95bbaf..e2dc3f5 100644
5d360b
--- a/hw/misc/vfio.c
5d360b
+++ b/hw/misc/vfio.c
5d360b
@@ -3867,8 +3867,8 @@ static int vfio_initfn(PCIDevice *pdev)
5d360b
         if (!(~vdev->host.domain || ~vdev->host.bus ||
5d360b
               ~vdev->host.slot || ~vdev->host.function)) {
5d360b
             error_report("No provided host device - "
5d360b
-                         "Use -vfio-pci,host=DDDD:BB:DD.F "
5d360b
-                         "or -vfio-pci,sysfsdev=PATH_TO_DEVICE");
5d360b
+                         "Use -device vfio-pci,host=DDDD:BB:DD.F "
5d360b
+                         "or -device vfio-pci,sysfsdev=PATH_TO_DEVICE");
5d360b
             return -EINVAL;
5d360b
         }
5d360b
         vdev->vbasedev.sysfsdev =
5d360b
-- 
5d360b
1.8.3.1
5d360b