|
 |
26ba25 |
From b84814bde02585f990a32f2ebfbdda1de1fce5a8 Mon Sep 17 00:00:00 2001
|
|
|
26ba25 |
From: John Snow <jsnow@redhat.com>
|
|
|
26ba25 |
Date: Wed, 18 Jul 2018 22:55:00 +0200
|
|
|
26ba25 |
Subject: [PATCH 242/268] nbd/server: fix trace
|
|
|
26ba25 |
|
|
|
26ba25 |
RH-Author: John Snow <jsnow@redhat.com>
|
|
|
26ba25 |
Message-id: <20180718225511.14878-25-jsnow@redhat.com>
|
|
|
26ba25 |
Patchwork-id: 81401
|
|
|
26ba25 |
O-Subject: [RHEL-7.6 qemu-kvm-rhev PATCH 24/35] nbd/server: fix trace
|
|
|
26ba25 |
Bugzilla: 1207657
|
|
|
26ba25 |
RH-Acked-by: Eric Blake <eblake@redhat.com>
|
|
|
26ba25 |
RH-Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
|
|
|
26ba25 |
RH-Acked-by: Fam Zheng <famz@redhat.com>
|
|
|
26ba25 |
|
|
|
26ba25 |
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
|
|
|
26ba25 |
|
|
|
26ba25 |
Return code = 1 doesn't mean that we parsed base:allocation. Use
|
|
|
26ba25 |
correct traces in both -parsed and -skipped cases.
|
|
|
26ba25 |
|
|
|
26ba25 |
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
|
|
|
26ba25 |
Message-Id: <20180609151758.17343-2-vsementsov@virtuozzo.com>
|
|
|
26ba25 |
Reviewed-by: Eric Blake <eblake@redhat.com>
|
|
|
26ba25 |
[eblake: comment tweaks]
|
|
|
26ba25 |
Signed-off-by: Eric Blake <eblake@redhat.com>
|
|
|
26ba25 |
(cherry picked from commit dbb8b396bb46388cee92e9094c563297d04c43ed)
|
|
|
26ba25 |
Signed-off-by: John Snow <jsnow@redhat.com>
|
|
|
26ba25 |
|
|
|
26ba25 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
26ba25 |
---
|
|
|
26ba25 |
nbd/server.c | 14 ++++++++++----
|
|
|
26ba25 |
1 file changed, 10 insertions(+), 4 deletions(-)
|
|
|
26ba25 |
|
|
|
26ba25 |
diff --git a/nbd/server.c b/nbd/server.c
|
|
|
26ba25 |
index 493a926..942c016 100644
|
|
|
26ba25 |
--- a/nbd/server.c
|
|
|
26ba25 |
+++ b/nbd/server.c
|
|
|
26ba25 |
@@ -736,12 +736,16 @@ static int nbd_negotiate_send_meta_context(NBDClient *client,
|
|
|
26ba25 |
|
|
|
26ba25 |
/* nbd_meta_base_query
|
|
|
26ba25 |
*
|
|
|
26ba25 |
- * Handle query to 'base' namespace. For now, only base:allocation context is
|
|
|
26ba25 |
- * available in it. 'len' is the amount of text remaining to be read from
|
|
|
26ba25 |
+ * Handle queries to 'base' namespace. For now, only the base:allocation
|
|
|
26ba25 |
+ * context is available. 'len' is the amount of text remaining to be read from
|
|
|
26ba25 |
* the current name, after the 'base:' portion has been stripped.
|
|
|
26ba25 |
*
|
|
|
26ba25 |
* Return -errno on I/O error, 0 if option was completely handled by
|
|
|
26ba25 |
- * sending a reply about inconsistent lengths, or 1 on success. */
|
|
|
26ba25 |
+ * sending a reply about inconsistent lengths, or 1 on success.
|
|
|
26ba25 |
+ *
|
|
|
26ba25 |
+ * Note: return code = 1 doesn't mean that we've parsed the "base:allocation"
|
|
|
26ba25 |
+ * namespace. It only means that there are no errors.
|
|
|
26ba25 |
+ */
|
|
|
26ba25 |
static int nbd_meta_base_query(NBDClient *client, NBDExportMetaContexts *meta,
|
|
|
26ba25 |
uint32_t len, Error **errp)
|
|
|
26ba25 |
{
|
|
|
26ba25 |
@@ -768,10 +772,12 @@ static int nbd_meta_base_query(NBDClient *client, NBDExportMetaContexts *meta,
|
|
|
26ba25 |
}
|
|
|
26ba25 |
|
|
|
26ba25 |
if (strncmp(query, "allocation", alen) == 0) {
|
|
|
26ba25 |
+ trace_nbd_negotiate_meta_query_parse("base:allocation");
|
|
|
26ba25 |
meta->base_allocation = true;
|
|
|
26ba25 |
+ } else {
|
|
|
26ba25 |
+ trace_nbd_negotiate_meta_query_skip("not base:allocation");
|
|
|
26ba25 |
}
|
|
|
26ba25 |
|
|
|
26ba25 |
- trace_nbd_negotiate_meta_query_parse("base:allocation");
|
|
|
26ba25 |
return 1;
|
|
|
26ba25 |
}
|
|
|
26ba25 |
|
|
|
26ba25 |
--
|
|
|
26ba25 |
1.8.3.1
|
|
|
26ba25 |
|