|
 |
26ba25 |
From 1c9e86aac83e91498772885f5223e212337a3ff9 Mon Sep 17 00:00:00 2001
|
|
|
26ba25 |
From: Laurent Vivier <lvivier@redhat.com>
|
|
|
26ba25 |
Date: Thu, 21 Jun 2018 09:45:26 +0200
|
|
|
26ba25 |
Subject: [PATCH 075/268] migration: calculate expected_downtime with
|
|
|
26ba25 |
ram_bytes_remaining()
|
|
|
26ba25 |
|
|
|
26ba25 |
RH-Author: Laurent Vivier <lvivier@redhat.com>
|
|
|
26ba25 |
Message-id: <20180621094526.5714-1-lvivier@redhat.com>
|
|
|
26ba25 |
Patchwork-id: 80931
|
|
|
26ba25 |
O-Subject: [RHEL-7.6 qemu-kvm-rhev PATCH] migration: calculate expected_downtime with ram_bytes_remaining()
|
|
|
26ba25 |
Bugzilla: 1564576
|
|
|
26ba25 |
RH-Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
|
|
|
26ba25 |
RH-Acked-by: Thomas Huth <thuth@redhat.com>
|
|
|
26ba25 |
RH-Acked-by: David Gibson <dgibson@redhat.com>
|
|
|
26ba25 |
|
|
|
26ba25 |
From: Balamuruhan S <bala24@linux.vnet.ibm.com>
|
|
|
26ba25 |
|
|
|
26ba25 |
expected_downtime value is not accurate with dirty_pages_rate * page_size,
|
|
|
26ba25 |
using ram_bytes_remaining() would yeild it resonable.
|
|
|
26ba25 |
|
|
|
26ba25 |
consider to read the remaining ram just after having updated the dirty
|
|
|
26ba25 |
pages count later migration_bitmap_sync_range() in migration_bitmap_sync()
|
|
|
26ba25 |
and reuse the `remaining` field in ram_counters to hold ram_bytes_remaining()
|
|
|
26ba25 |
for calculating expected_downtime.
|
|
|
26ba25 |
|
|
|
26ba25 |
Reported-by: Michael Roth <mdroth@linux.vnet.ibm.com>
|
|
|
26ba25 |
Signed-off-by: Balamuruhan S <bala24@linux.vnet.ibm.com>
|
|
|
26ba25 |
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
|
|
|
26ba25 |
Message-Id: <20180612085009.17594-2-bala24@linux.vnet.ibm.com>
|
|
|
26ba25 |
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
|
|
|
26ba25 |
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
|
|
|
26ba25 |
(cherry picked from commit 650af8907bd567db914b7ce3a7e9df4c323f4619)
|
|
|
26ba25 |
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
|
|
|
26ba25 |
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
|
|
26ba25 |
---
|
|
|
26ba25 |
migration/migration.c | 3 +--
|
|
|
26ba25 |
migration/ram.c | 1 +
|
|
|
26ba25 |
2 files changed, 2 insertions(+), 2 deletions(-)
|
|
|
26ba25 |
|
|
|
26ba25 |
diff --git a/migration/migration.c b/migration/migration.c
|
|
|
26ba25 |
index ef4bb42..43d8a64 100644
|
|
|
26ba25 |
--- a/migration/migration.c
|
|
|
26ba25 |
+++ b/migration/migration.c
|
|
|
26ba25 |
@@ -2239,8 +2239,7 @@ static void migration_update_counters(MigrationState *s,
|
|
|
26ba25 |
* recalculate. 10000 is a small enough number for our purposes
|
|
|
26ba25 |
*/
|
|
|
26ba25 |
if (ram_counters.dirty_pages_rate && transferred > 10000) {
|
|
|
26ba25 |
- s->expected_downtime = ram_counters.dirty_pages_rate *
|
|
|
26ba25 |
- qemu_target_page_size() / bandwidth;
|
|
|
26ba25 |
+ s->expected_downtime = ram_counters.remaining / bandwidth;
|
|
|
26ba25 |
}
|
|
|
26ba25 |
|
|
|
26ba25 |
qemu_file_reset_rate_limit(s->to_dst_file);
|
|
|
26ba25 |
diff --git a/migration/ram.c b/migration/ram.c
|
|
|
26ba25 |
index 0e90efa..00c06b5 100644
|
|
|
26ba25 |
--- a/migration/ram.c
|
|
|
26ba25 |
+++ b/migration/ram.c
|
|
|
26ba25 |
@@ -852,6 +852,7 @@ static void migration_bitmap_sync(RAMState *rs)
|
|
|
26ba25 |
RAMBLOCK_FOREACH(block) {
|
|
|
26ba25 |
migration_bitmap_sync_range(rs, block, 0, block->used_length);
|
|
|
26ba25 |
}
|
|
|
26ba25 |
+ ram_counters.remaining = ram_bytes_remaining();
|
|
|
26ba25 |
rcu_read_unlock();
|
|
|
26ba25 |
qemu_mutex_unlock(&rs->bitmap_mutex);
|
|
|
26ba25 |
|
|
|
26ba25 |
--
|
|
|
26ba25 |
1.8.3.1
|
|
|
26ba25 |
|