|
rdobuilder |
1033c5 |
From b4c39c58746334912f9a89941f967e296f1e0b5b Mon Sep 17 00:00:00 2001
|
|
rdobuilder |
1033c5 |
From: Dirk Mueller <dirk@dmllr.de>
|
|
rdobuilder |
1033c5 |
Date: Tue, 16 Feb 2021 10:29:21 +0100
|
|
rdobuilder |
1033c5 |
Subject: [PATCH] Replace assertItemsEqual with assertCountEqual
|
|
rdobuilder |
1033c5 |
|
|
rdobuilder |
1033c5 |
assertItemsEqual was removed from Python's unittest.TestCase in
|
|
rdobuilder |
1033c5 |
Python 3.3 [1][2]. We have been able to use them since then, because
|
|
rdobuilder |
1033c5 |
testtools required unittest2, which still included it. With testtools
|
|
rdobuilder |
1033c5 |
removing Python 2.7 support [3][4], we will lose support for
|
|
rdobuilder |
1033c5 |
assertItemsEqual, so we should switch to use assertCountEqual.
|
|
rdobuilder |
1033c5 |
|
|
rdobuilder |
1033c5 |
[1] - https://bugs.python.org/issue17866
|
|
rdobuilder |
1033c5 |
[2] - https://hg.python.org/cpython/rev/d9921cb6e3cd
|
|
rdobuilder |
1033c5 |
[3] - testing-cabal/testtools#286
|
|
rdobuilder |
1033c5 |
[4] - testing-cabal/testtools#277
|
|
rdobuilder |
1033c5 |
|
|
rdobuilder |
1033c5 |
Change-Id: I6ebd93aa093caad6f2d3db6e43beb8bc8d9cedb7
|
|
rdobuilder |
1033c5 |
---
|
|
rdobuilder |
1033c5 |
yaql/tests/test_strings.py | 2 +-
|
|
rdobuilder |
1033c5 |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
rdobuilder |
1033c5 |
|
|
rdobuilder |
1033c5 |
diff --git a/yaql/tests/test_strings.py b/yaql/tests/test_strings.py
|
|
rdobuilder |
1033c5 |
index 3e51189..4af8812 100644
|
|
rdobuilder |
1033c5 |
--- a/yaql/tests/test_strings.py
|
|
rdobuilder |
1033c5 |
+++ b/yaql/tests/test_strings.py
|
|
rdobuilder |
1033c5 |
@@ -174,7 +174,7 @@ class TestStrings(yaql.tests.TestCase):
|
|
rdobuilder |
1033c5 |
self.assertEqual(['a', 'b', 'c'], self.eval('abc.toCharArray()'))
|
|
rdobuilder |
1033c5 |
|
|
rdobuilder |
1033c5 |
def test_characters(self):
|
|
rdobuilder |
1033c5 |
- self.assertItemsEqual(
|
|
rdobuilder |
1033c5 |
+ self.assertCountEqual(
|
|
rdobuilder |
1033c5 |
['0', '1', '2', '3', '4', '5', '6', '7', '8', '9'],
|
|
rdobuilder |
1033c5 |
self.eval('characters(octdigits => true, digits => true)'))
|
|
rdobuilder |
1033c5 |
|
|
rdobuilder |
1033c5 |
--
|
|
rdobuilder |
1033c5 |
2.31.1
|
|
rdobuilder |
1033c5 |
|