Norbert Pocs 2341f1
diff --color -ru -x regress -x autom4te.cache -x '*.o' -x '*.lo' -x Makefile -x config.status -x configure~ -x configure.ac openssh-9.0p1/dh.c openssh-9.0p1-patched/dh.c
Norbert Pocs 2341f1
--- openssh-9.0p1/dh.c	2023-05-25 09:24:28.730868316 +0200
Norbert Pocs 2341f1
+++ openssh-9.0p1-patched/dh.c	2023-05-25 09:23:44.841379532 +0200
Norbert Pocs 2341f1
@@ -37,6 +37,9 @@
Norbert Pocs b63272
 #include <openssl/bn.h>
Norbert Pocs b63272
 #include <openssl/dh.h>
Norbert Pocs b63272
 #include <openssl/fips.h>
Norbert Pocs b63272
+#include <openssl/evp.h>
Norbert Pocs b63272
+#include <openssl/core_names.h>
Norbert Pocs b63272
+#include <openssl/param_build.h>
Norbert Pocs b63272
 
Norbert Pocs b63272
 #include "dh.h"
Norbert Pocs b63272
 #include "pathnames.h"
Norbert Pocs 2341f1
@@ -290,10 +293,15 @@
Norbert Pocs b63272
 int
Norbert Pocs b63272
 dh_gen_key(DH *dh, int need)
Norbert Pocs b63272
 {
Norbert Pocs b63272
-	int pbits;
Norbert Pocs b63272
-	const BIGNUM *dh_p, *pub_key;
Norbert Pocs b63272
+	const BIGNUM *dh_p, *dh_g;
Norbert Pocs b63272
+	BIGNUM *pub_key = NULL, *priv_key = NULL;
Norbert Pocs b63272
+	EVP_PKEY *pkey = NULL;
Norbert Pocs b63272
+  	EVP_PKEY_CTX *ctx = NULL;
Norbert Pocs b63272
+  	OSSL_PARAM_BLD *param_bld = NULL;
Norbert Pocs b63272
+  	OSSL_PARAM *params = NULL;
Norbert Pocs b63272
+	int pbits, r = 0;
Norbert Pocs b63272
 
Norbert Pocs b63272
-	DH_get0_pqg(dh, &dh_p, NULL, NULL);
Norbert Pocs b63272
+	DH_get0_pqg(dh, &dh_p, NULL, &dh_g);
Norbert Pocs b63272
 
Norbert Pocs b63272
 	if (need < 0 || dh_p == NULL ||
Norbert Pocs b63272
 	    (pbits = BN_num_bits(dh_p)) <= 0 ||
Norbert Pocs 2341f1
@@ -301,19 +309,85 @@
Norbert Pocs b63272
 		return SSH_ERR_INVALID_ARGUMENT;
Norbert Pocs b63272
 	if (need < 256)
Norbert Pocs b63272
 		need = 256;
Norbert Pocs b63272
+
Norbert Pocs b63272
+	if ((param_bld = OSSL_PARAM_BLD_new()) == NULL ||
Norbert Pocs b63272
+	    (ctx = EVP_PKEY_CTX_new_from_name(NULL, "DH", NULL)) == NULL) {
Norbert Pocs b63272
+		OSSL_PARAM_BLD_free(param_bld);
Norbert Pocs b63272
+		return SSH_ERR_ALLOC_FAIL;
Norbert Pocs b63272
+	}
Norbert Pocs b63272
+
Norbert Pocs b63272
+	if (OSSL_PARAM_BLD_push_BN(param_bld,
Norbert Pocs b63272
+	        OSSL_PKEY_PARAM_FFC_P, dh_p) != 1 ||
Norbert Pocs b63272
+	    OSSL_PARAM_BLD_push_BN(param_bld,
Norbert Pocs b63272
+	        OSSL_PKEY_PARAM_FFC_G, dh_g) != 1) {
Norbert Pocs b63272
+		error_f("Could not set p,q,g parameters");
Norbert Pocs b63272
+		r = SSH_ERR_LIBCRYPTO_ERROR;
Norbert Pocs b63272
+		goto out;
Norbert Pocs b63272
+	}
Norbert Pocs b63272
 	/*
Norbert Pocs b63272
 	 * Pollard Rho, Big step/Little Step attacks are O(sqrt(n)),
Norbert Pocs b63272
 	 * so double requested need here.
Norbert Pocs b63272
 	 */
Norbert Pocs b63272
-	if (!DH_set_length(dh, MINIMUM(need * 2, pbits - 1)))
Norbert Pocs b63272
-		return SSH_ERR_LIBCRYPTO_ERROR;
Norbert Pocs b63272
-
Norbert Pocs b63272
-	if (DH_generate_key(dh) == 0)
Norbert Pocs b63272
-		return SSH_ERR_LIBCRYPTO_ERROR;
Norbert Pocs b63272
-	DH_get0_key(dh, &pub_key, NULL);
Norbert Pocs b63272
-	if (!dh_pub_is_valid(dh, pub_key))
Norbert Pocs b63272
-		return SSH_ERR_INVALID_FORMAT;
Norbert Pocs b63272
-	return 0;
Norbert Pocs b63272
+	if (OSSL_PARAM_BLD_push_int(param_bld,
Norbert Pocs b63272
+	        OSSL_PKEY_PARAM_DH_PRIV_LEN,
Norbert Pocs b63272
+		MINIMUM(need * 2, pbits - 1)) != 1 ||
Norbert Pocs b63272
+	    (params = OSSL_PARAM_BLD_to_param(param_bld)) == NULL) {
Norbert Pocs b63272
+		r = SSH_ERR_LIBCRYPTO_ERROR;
Norbert Pocs b63272
+		goto out;
Norbert Pocs b63272
+	}
Norbert Pocs b63272
+	if (EVP_PKEY_fromdata_init(ctx) != 1) {
Norbert Pocs b63272
+		r = SSH_ERR_LIBCRYPTO_ERROR;
Norbert Pocs b63272
+		goto out;
Norbert Pocs b63272
+	}
Norbert Pocs b63272
+	if (EVP_PKEY_fromdata(ctx, &pkey,
Norbert Pocs b63272
+	        EVP_PKEY_KEY_PARAMETERS, params) != 1) {
Norbert Pocs b63272
+		error_f("Failed key generation");
Norbert Pocs b63272
+		r = SSH_ERR_LIBCRYPTO_ERROR;
Norbert Pocs b63272
+		goto out;
Norbert Pocs b63272
+	}
Norbert Pocs b63272
+
Norbert Pocs b63272
+	/* reuse context for key generation */
Norbert Pocs b63272
+	EVP_PKEY_CTX_free(ctx);
Norbert Pocs b63272
+	ctx = NULL;
Norbert Pocs b63272
+
Norbert Pocs b63272
+	if ((ctx = EVP_PKEY_CTX_new_from_pkey(NULL, pkey, NULL)) == NULL ||
Norbert Pocs b63272
+	    EVP_PKEY_keygen_init(ctx) != 1) {
Norbert Pocs b63272
+		error_f("Could not create or init context");
Norbert Pocs b63272
+		r = SSH_ERR_LIBCRYPTO_ERROR;
Norbert Pocs b63272
+		goto out;
Norbert Pocs b63272
+	}
Norbert Pocs b63272
+	if (EVP_PKEY_generate(ctx, &pkey) != 1) {
Norbert Pocs b63272
+		error_f("Could not generate keys");
Norbert Pocs b63272
+		r = SSH_ERR_LIBCRYPTO_ERROR;
Norbert Pocs b63272
+		goto out;
Norbert Pocs b63272
+	}
Norbert Pocs b63272
+	if (EVP_PKEY_public_check(ctx) != 1) {
Norbert Pocs b63272
+		error_f("The public key is incorrect");
Norbert Pocs b63272
+		r = SSH_ERR_LIBCRYPTO_ERROR;
Norbert Pocs b63272
+		goto out;
Norbert Pocs b63272
+	}
Norbert Pocs b63272
+
Norbert Pocs b63272
+	if (EVP_PKEY_get_bn_param(pkey, OSSL_PKEY_PARAM_PUB_KEY,
Norbert Pocs b63272
+	    &pub_key) != 1 ||
Norbert Pocs b63272
+	    EVP_PKEY_get_bn_param(pkey, OSSL_PKEY_PARAM_PRIV_KEY,
Norbert Pocs b63272
+	    &priv_key) != 1 ||
Norbert Pocs b63272
+	    DH_set0_key(dh, pub_key, priv_key) != 1) {
Norbert Pocs b63272
+		error_f("Could not set pub/priv keys to DH struct");
Norbert Pocs b63272
+		r = SSH_ERR_LIBCRYPTO_ERROR;
Norbert Pocs b63272
+		goto out;
Norbert Pocs b63272
+	}
Norbert Pocs b63272
+
Norbert Pocs b63272
+	/* transferred */
Norbert Pocs b63272
+	pub_key = NULL;
Norbert Pocs b63272
+	priv_key = NULL;
Norbert Pocs b63272
+out:
Norbert Pocs b63272
+	OSSL_PARAM_free(params);
Norbert Pocs b63272
+	OSSL_PARAM_BLD_free(param_bld);
Norbert Pocs b63272
+	EVP_PKEY_CTX_free(ctx);
Norbert Pocs b63272
+	EVP_PKEY_free(pkey);
Norbert Pocs b63272
+	BN_clear_free(pub_key);
Norbert Pocs b63272
+	BN_clear_free(priv_key);
Norbert Pocs b63272
+	return r;
Norbert Pocs b63272
 }
Norbert Pocs b63272
 
Norbert Pocs b63272
 DH *
Norbert Pocs 2341f1
diff --color -ru -x regress -x autom4te.cache -x '*.o' -x '*.lo' -x Makefile -x config.status -x configure~ -x configure.ac openssh-9.0p1/kex.c openssh-9.0p1-patched/kex.c
Norbert Pocs 2341f1
--- openssh-9.0p1/kex.c	2023-05-25 09:24:28.731868327 +0200
Norbert Pocs 2341f1
+++ openssh-9.0p1-patched/kex.c	2023-05-25 09:23:44.841379532 +0200
Dmitry Belyavskiy 07172f
@@ -1623,3 +1623,142 @@
Norbert Pocs b63272
 	return r;
Norbert Pocs b63272
 }
Norbert Pocs b63272
 
Norbert Pocs b63272
+#ifdef WITH_OPENSSL
Norbert Pocs b63272
+/* 
Norbert Pocs b63272
+ * Creates an EVP_PKEY from the given parameters and keys.
Norbert Pocs b63272
+ * The private key can be omitted.
Norbert Pocs b63272
+ */
Dmitry Belyavskiy 07172f
+EVP_PKEY *
Dmitry Belyavskiy 07172f
+sshkey_create_evp(OSSL_PARAM_BLD *param_bld, EVP_PKEY_CTX *ctx)
Dmitry Belyavskiy 07172f
+{
Dmitry Belyavskiy 07172f
+  	EVP_PKEY *ret = NULL;
Dmitry Belyavskiy 07172f
+  	OSSL_PARAM *params = NULL;
Dmitry Belyavskiy 07172f
+  	if (param_bld == NULL || ctx == NULL) {
Dmitry Belyavskiy 07172f
+  		debug2_f("param_bld or ctx is NULL");
Dmitry Belyavskiy 07172f
+  		return NULL;
Dmitry Belyavskiy 07172f
+  	}
Dmitry Belyavskiy 07172f
+  	if ((params = OSSL_PARAM_BLD_to_param(param_bld)) == NULL) {
Dmitry Belyavskiy 07172f
+  		debug2_f("Could not build param list");
Dmitry Belyavskiy 07172f
+  		return NULL;
Dmitry Belyavskiy 07172f
+  	}
Dmitry Belyavskiy 07172f
+  	if (EVP_PKEY_fromdata_init(ctx) != 1 ||
Dmitry Belyavskiy 07172f
+  	    EVP_PKEY_fromdata(ctx, &ret, EVP_PKEY_KEYPAIR, params) != 1) {
Dmitry Belyavskiy 07172f
+  		debug2_f("EVP_PKEY_fromdata failed");
Dmitry Belyavskiy 07172f
+  		OSSL_PARAM_free(params);
Dmitry Belyavskiy 07172f
+  		return NULL;
Dmitry Belyavskiy 07172f
+  	}
Dmitry Belyavskiy 07172f
+  	return ret;
Dmitry Belyavskiy 07172f
+}
Dmitry Belyavskiy 07172f
+
Dmitry Belyavskiy 07172f
+int
Dmitry Belyavskiy 07172f
+kex_create_evp_ec(EC_KEY *k, int ecdsa_nid, EVP_PKEY **pkey)
Dmitry Belyavskiy 07172f
+{
Dmitry Belyavskiy 07172f
+	OSSL_PARAM_BLD *param_bld = NULL;
Dmitry Belyavskiy 07172f
+	EVP_PKEY_CTX *ctx = NULL;
Dmitry Belyavskiy 07172f
+  	BN_CTX *bn_ctx = NULL;
Dmitry Belyavskiy 07172f
+  	uint8_t *pub_ser = NULL;
Dmitry Belyavskiy 07172f
+  	const char *group_name;
Dmitry Belyavskiy 07172f
+  	const EC_POINT *pub = NULL;
Dmitry Belyavskiy 07172f
+  	const BIGNUM *priv = NULL;
Dmitry Belyavskiy 07172f
+  	int ret = 0;
Dmitry Belyavskiy 07172f
+
Dmitry Belyavskiy 07172f
+	if (k == NULL)
Dmitry Belyavskiy 07172f
+    		return SSH_ERR_INVALID_ARGUMENT;
Dmitry Belyavskiy 07172f
+  	if ((ctx = EVP_PKEY_CTX_new_from_name(NULL, "EC", NULL)) == NULL ||
Dmitry Belyavskiy 07172f
+      	    (param_bld = OSSL_PARAM_BLD_new()) == NULL ||
Dmitry Belyavskiy 07172f
+      	    (bn_ctx = BN_CTX_new()) == NULL) {
Dmitry Belyavskiy 07172f
+    		ret = SSH_ERR_ALLOC_FAIL;
Dmitry Belyavskiy 07172f
+    		goto out;
Dmitry Belyavskiy 07172f
+  	}
Dmitry Belyavskiy 07172f
+
Dmitry Belyavskiy 07172f
+	if ((group_name = OSSL_EC_curve_nid2name(ecdsa_nid)) == NULL ||
Dmitry Belyavskiy 07172f
+     	    OSSL_PARAM_BLD_push_utf8_string(param_bld,
Dmitry Belyavskiy 07172f
+                OSSL_PKEY_PARAM_GROUP_NAME,
Dmitry Belyavskiy 07172f
+                group_name,
Dmitry Belyavskiy 07172f
+                strlen(group_name)) != 1) {
Dmitry Belyavskiy 07172f
+    		ret = SSH_ERR_LIBCRYPTO_ERROR;
Dmitry Belyavskiy 07172f
+    		goto out;
Dmitry Belyavskiy 07172f
+	}
Dmitry Belyavskiy 07172f
+  	if ((pub = EC_KEY_get0_public_key(k)) != NULL) {
Dmitry Belyavskiy 07172f
+    		const EC_GROUP *group;
Dmitry Belyavskiy 07172f
+    		size_t len;
Dmitry Belyavskiy 07172f
+
Dmitry Belyavskiy 07172f
+		group = EC_KEY_get0_group(k);
Dmitry Belyavskiy 07172f
+		len = EC_POINT_point2oct(group, pub,
Dmitry Belyavskiy 07172f
+		    POINT_CONVERSION_UNCOMPRESSED, NULL, 0, NULL);
Dmitry Belyavskiy 07172f
+		if ((pub_ser = malloc(len)) == NULL) {
Dmitry Belyavskiy 07172f
+			ret = SSH_ERR_ALLOC_FAIL;
Dmitry Belyavskiy 07172f
+			goto out;
Dmitry Belyavskiy 07172f
+		}
Dmitry Belyavskiy 07172f
+		EC_POINT_point2oct(group,
Dmitry Belyavskiy 07172f
+		    pub,
Dmitry Belyavskiy 07172f
+		    POINT_CONVERSION_UNCOMPRESSED,
Dmitry Belyavskiy 07172f
+		    pub_ser,
Dmitry Belyavskiy 07172f
+		    len,
Dmitry Belyavskiy 07172f
+		    bn_ctx);
Dmitry Belyavskiy 07172f
+		if (OSSL_PARAM_BLD_push_octet_string(param_bld,
Dmitry Belyavskiy 07172f
+		    OSSL_PKEY_PARAM_PUB_KEY,
Dmitry Belyavskiy 07172f
+		    pub_ser,
Dmitry Belyavskiy 07172f
+		    len) != 1) {
Dmitry Belyavskiy 07172f
+			ret = SSH_ERR_LIBCRYPTO_ERROR;
Dmitry Belyavskiy 07172f
+			goto out;
Dmitry Belyavskiy 07172f
+		}
Dmitry Belyavskiy 07172f
+	}
Dmitry Belyavskiy 07172f
+  	if ((priv = EC_KEY_get0_private_key(k)) != NULL &&
Dmitry Belyavskiy 07172f
+	    OSSL_PARAM_BLD_push_BN(param_bld,
Dmitry Belyavskiy 07172f
+               OSSL_PKEY_PARAM_PRIV_KEY, priv) != 1) {
Dmitry Belyavskiy 07172f
+		ret = SSH_ERR_LIBCRYPTO_ERROR;
Dmitry Belyavskiy 07172f
+		goto out;
Dmitry Belyavskiy 07172f
+  	}
Dmitry Belyavskiy 07172f
+  	if ((*pkey = sshkey_create_evp(param_bld, ctx)) == NULL) {
Dmitry Belyavskiy 07172f
+    		ret = SSH_ERR_LIBCRYPTO_ERROR;
Dmitry Belyavskiy 07172f
+    		goto out;
Dmitry Belyavskiy 07172f
+  	}
Dmitry Belyavskiy 07172f
+
Dmitry Belyavskiy 07172f
+out:
Dmitry Belyavskiy 07172f
+  	OSSL_PARAM_BLD_free(param_bld);
Dmitry Belyavskiy 07172f
+  	EVP_PKEY_CTX_free(ctx);
Dmitry Belyavskiy 07172f
+  	BN_CTX_free(bn_ctx);
Dmitry Belyavskiy 07172f
+  	free(pub_ser);
Dmitry Belyavskiy 07172f
+  	return ret;
Dmitry Belyavskiy 07172f
+}
Dmitry Belyavskiy 07172f
+
Norbert Pocs b63272
+int
Norbert Pocs b63272
+kex_create_evp_dh(EVP_PKEY **pkey, const BIGNUM *p, const BIGNUM *q,
Norbert Pocs b63272
+    const BIGNUM *g, const BIGNUM *pub, const BIGNUM *priv)
Norbert Pocs b63272
+{
Norbert Pocs b63272
+	OSSL_PARAM_BLD *param_bld = NULL;
Norbert Pocs b63272
+	EVP_PKEY_CTX *ctx = NULL;
Norbert Pocs b63272
+	int r = 0;
Norbert Pocs b63272
+
Norbert Pocs b63272
+	/* create EVP_PKEY-DH key */
Norbert Pocs b63272
+	if ((ctx = EVP_PKEY_CTX_new_from_name(NULL, "DH", NULL)) == NULL ||
Norbert Pocs b63272
+	    (param_bld = OSSL_PARAM_BLD_new()) == NULL) {
Norbert Pocs b63272
+		error_f("EVP_PKEY_CTX or PARAM_BLD init failed");
Norbert Pocs b63272
+		r = SSH_ERR_ALLOC_FAIL;
Norbert Pocs b63272
+		goto out;
Norbert Pocs b63272
+	}
Norbert Pocs b63272
+	if (OSSL_PARAM_BLD_push_BN(param_bld, OSSL_PKEY_PARAM_FFC_P, p) != 1 ||
Norbert Pocs b63272
+	    OSSL_PARAM_BLD_push_BN(param_bld, OSSL_PKEY_PARAM_FFC_Q, q) != 1 ||
Norbert Pocs b63272
+	    OSSL_PARAM_BLD_push_BN(param_bld, OSSL_PKEY_PARAM_FFC_G, g) != 1 ||
Norbert Pocs b63272
+	    OSSL_PARAM_BLD_push_BN(param_bld,
Norbert Pocs b63272
+	        OSSL_PKEY_PARAM_PUB_KEY, pub) != 1) {
Norbert Pocs b63272
+		error_f("Failed pushing params to OSSL_PARAM_BLD");
Norbert Pocs b63272
+		r = SSH_ERR_LIBCRYPTO_ERROR;
Norbert Pocs b63272
+		goto out;
Norbert Pocs b63272
+	}
Norbert Pocs b63272
+	if (priv != NULL &&
Norbert Pocs b63272
+	    OSSL_PARAM_BLD_push_BN(param_bld,
Norbert Pocs b63272
+	        OSSL_PKEY_PARAM_PRIV_KEY, priv) != 1) {
Norbert Pocs b63272
+		error_f("Failed pushing private key to OSSL_PARAM_BLD");
Norbert Pocs b63272
+		r = SSH_ERR_LIBCRYPTO_ERROR;
Norbert Pocs b63272
+		goto out;
Norbert Pocs b63272
+	}
Norbert Pocs b63272
+	if ((*pkey = sshkey_create_evp(param_bld, ctx)) == NULL)
Norbert Pocs b63272
+		r = SSH_ERR_LIBCRYPTO_ERROR;
Norbert Pocs b63272
+out:
Norbert Pocs b63272
+	OSSL_PARAM_BLD_free(param_bld);
Norbert Pocs b63272
+	EVP_PKEY_CTX_free(ctx);
Norbert Pocs b63272
+	return r;
Norbert Pocs b63272
+}
Norbert Pocs b63272
+#endif /* WITH_OPENSSL */
Norbert Pocs 2341f1
diff --color -ru -x regress -x autom4te.cache -x '*.o' -x '*.lo' -x Makefile -x config.status -x configure~ -x configure.ac openssh-9.0p1/kexdh.c openssh-9.0p1-patched/kexdh.c
Norbert Pocs 2341f1
--- openssh-9.0p1/kexdh.c	2023-05-25 09:24:28.674867692 +0200
Norbert Pocs 2341f1
+++ openssh-9.0p1-patched/kexdh.c	2023-05-25 09:25:28.494533889 +0200
Norbert Pocs 2341f1
@@ -35,6 +35,10 @@
Norbert Pocs b63272
 
Norbert Pocs b63272
 #include "openbsd-compat/openssl-compat.h"
Norbert Pocs b63272
 #include <openssl/dh.h>
Norbert Pocs 2341f1
+#include <openssl/err.h>
Norbert Pocs b63272
+#include <openssl/evp.h>
Norbert Pocs b63272
+#include <openssl/core_names.h>
Norbert Pocs b63272
+#include <openssl/param_build.h>
Norbert Pocs b63272
 
Norbert Pocs b63272
 #include "sshkey.h"
Norbert Pocs b63272
 #include "kex.h"
Norbert Pocs 2341f1
@@ -83,9 +87,12 @@
Norbert Pocs b63272
 kex_dh_compute_key(struct kex *kex, BIGNUM *dh_pub, struct sshbuf *out)
Norbert Pocs b63272
 {
Norbert Pocs b63272
 	BIGNUM *shared_secret = NULL;
Norbert Pocs b63272
+	const BIGNUM *pub, *priv, *p, *q, *g;
Norbert Pocs b63272
+	EVP_PKEY *pkey = NULL, *dh_pkey = NULL;
Norbert Pocs b63272
+	EVP_PKEY_CTX *ctx = NULL;
Norbert Pocs b63272
 	u_char *kbuf = NULL;
Norbert Pocs b63272
 	size_t klen = 0;
Norbert Pocs 2341f1
-	int kout, r;
Dmitry Belyavskiy 089d79
+	int r = 0;
Norbert Pocs 2341f1
 
Norbert Pocs 2341f1
 #ifdef DEBUG_KEXDH
Norbert Pocs 2341f1
 	fprintf(stderr, "dh_pub= ");
Norbert Pocs 2341f1
@@ -100,24 +107,59 @@
Norbert Pocs 2341f1
 		r = SSH_ERR_MESSAGE_INCOMPLETE;
Norbert Pocs b63272
 		goto out;
Norbert Pocs b63272
 	}
Norbert Pocs 2341f1
-	klen = DH_size(kex->dh);
Norbert Pocs b63272
+
Norbert Pocs b63272
+	DH_get0_key(kex->dh, &pub, &priv;;
Norbert Pocs b63272
+	DH_get0_pqg(kex->dh, &p, &q, &g);
Norbert Pocs b63272
+	/* import key */
Norbert Pocs 2341f1
+	r = kex_create_evp_dh(&pkey, p, q, g, pub, priv);
Norbert Pocs 2341f1
+	if (r != 0) {
Norbert Pocs 2341f1
+		error_f("Could not create EVP_PKEY for dh");
Norbert Pocs 2341f1
+		ERR_print_errors_fp(stderr);
Norbert Pocs 2341f1
+		goto out;
Norbert Pocs 2341f1
+	}
Norbert Pocs b63272
+	/* import peer key 
Norbert Pocs b63272
+	 * the parameters should be the same as with pkey
Norbert Pocs b63272
+	 */
Norbert Pocs 2341f1
+	r = kex_create_evp_dh(&dh_pkey, p, q, g, dh_pub, NULL);
Norbert Pocs 2341f1
+	if (r != 0) {
Norbert Pocs 2341f1
+		error_f("Could not import peer key for dh");
Norbert Pocs 2341f1
+		ERR_print_errors_fp(stderr);
Norbert Pocs 2341f1
+		goto out;
Norbert Pocs 2341f1
+	}
Norbert Pocs b63272
+
Norbert Pocs b63272
+	if ((ctx = EVP_PKEY_CTX_new_from_pkey(NULL, pkey, NULL)) == NULL) {
Norbert Pocs b63272
+		error_f("Could not init EVP_PKEY_CTX for dh");
Norbert Pocs b63272
+		r = SSH_ERR_ALLOC_FAIL;
Norbert Pocs b63272
+		goto out;
Norbert Pocs b63272
+	}
Norbert Pocs b63272
+	if (EVP_PKEY_derive_init(ctx) != 1 ||
Norbert Pocs b63272
+	    EVP_PKEY_derive_set_peer(ctx, dh_pkey) != 1 ||
Norbert Pocs 2341f1
+	    EVP_PKEY_derive(ctx, NULL, &klen) != 1) {
Norbert Pocs 2341f1
+		error_f("Could not get key size");
Norbert Pocs 2341f1
+		r = SSH_ERR_LIBCRYPTO_ERROR;
Norbert Pocs 2341f1
+		goto out;
Norbert Pocs 2341f1
+	}
Norbert Pocs 2341f1
 	if ((kbuf = malloc(klen)) == NULL ||
Norbert Pocs 2341f1
 	    (shared_secret = BN_new()) == NULL) {
Norbert Pocs 2341f1
 		r = SSH_ERR_ALLOC_FAIL;
Norbert Pocs 2341f1
 		goto out;
Norbert Pocs 2341f1
 	}
Norbert Pocs 2341f1
-	if ((kout = DH_compute_key(kbuf, dh_pub, kex->dh)) < 0 ||
Norbert Pocs 2341f1
-	    BN_bin2bn(kbuf, kout, shared_secret) == NULL) {
Norbert Pocs 2341f1
+	if (EVP_PKEY_derive(ctx, kbuf, &klen) != 1 ||
Norbert Pocs b63272
+	    BN_bin2bn(kbuf, klen, shared_secret) == NULL) {
Norbert Pocs b63272
+		error_f("Could not derive key");
Norbert Pocs b63272
 		r = SSH_ERR_LIBCRYPTO_ERROR;
Norbert Pocs b63272
 		goto out;
Norbert Pocs b63272
 	}
Norbert Pocs b63272
 #ifdef DEBUG_KEXDH
Norbert Pocs b63272
-	dump_digest("shared secret", kbuf, kout);
Norbert Pocs b63272
+	dump_digest("shared secret", kbuf, klen);
Norbert Pocs b63272
 #endif
Norbert Pocs b63272
 	r = sshbuf_put_bignum2(out, shared_secret);
Norbert Pocs b63272
  out:
Norbert Pocs b63272
 	freezero(kbuf, klen);
Norbert Pocs b63272
 	BN_clear_free(shared_secret);
Norbert Pocs b63272
+	EVP_PKEY_free(pkey);
Norbert Pocs b63272
+	EVP_PKEY_free(dh_pkey);
Norbert Pocs b63272
+	EVP_PKEY_CTX_free(ctx);
Norbert Pocs b63272
 	return r;
Norbert Pocs b63272
 }
Norbert Pocs b63272
 
Norbert Pocs 2341f1
diff --color -ru -x regress -x autom4te.cache -x '*.o' -x '*.lo' -x Makefile -x config.status -x configure~ -x configure.ac openssh-9.0p1/kex.h openssh-9.0p1-patched/kex.h
Norbert Pocs 2341f1
--- openssh-9.0p1/kex.h	2023-05-25 09:24:28.725868260 +0200
Norbert Pocs 2341f1
+++ openssh-9.0p1-patched/kex.h	2023-05-25 09:23:44.841379532 +0200
Norbert Pocs b63272
@@ -33,6 +33,9 @@
Norbert Pocs b63272
 # include <openssl/bn.h>
Norbert Pocs b63272
 # include <openssl/dh.h>
Norbert Pocs b63272
 # include <openssl/ecdsa.h>
Norbert Pocs b63272
+# include <openssl/evp.h>
Norbert Pocs b63272
+# include <openssl/core_names.h>
Norbert Pocs b63272
+# include <openssl/param_build.h>
Norbert Pocs b63272
 # ifdef OPENSSL_HAS_ECC
Norbert Pocs b63272
 #  include <openssl/ec.h>
Norbert Pocs b63272
 # else /* OPENSSL_HAS_ECC */
Dmitry Belyavskiy 07172f
@@ -283,6 +286,9@@
Norbert Pocs b63272
     const u_char pub[CURVE25519_SIZE], struct sshbuf *out, int)
Norbert Pocs b63272
 	__attribute__((__bounded__(__minbytes__, 1, CURVE25519_SIZE)))
Norbert Pocs b63272
 	__attribute__((__bounded__(__minbytes__, 2, CURVE25519_SIZE)));
Norbert Pocs b63272
+int	kex_create_evp_dh(EVP_PKEY **, const BIGNUM *, const BIGNUM *,
Norbert Pocs b63272
+    const BIGNUM *, const BIGNUM *, const BIGNUM *);
Dmitry Belyavskiy 07172f
+int    kex_create_evp_ec(EC_KEY *k, int ecdsa_nid, EVP_PKEY **pkey);
Norbert Pocs b63272
 
Norbert Pocs b63272
 #if defined(DEBUG_KEX) || defined(DEBUG_KEXDH) || defined(DEBUG_KEXECDH)
Norbert Pocs b63272
 void	dump_digest(const char *, const u_char *, int);
Dmitry Belyavskiy 07172f
diff --color -ru -x regress -x autom4te.cache -x '*.o' -x '*.lo' -x Makefile -x config.status -x configure~ -x configure.ac ../openssh-8.7p1/kexecdh.c ./kexecdh.c
Dmitry Belyavskiy 07172f
--- ../openssh-8.7p1/kexecdh.c	2021-08-20 06:03:49.000000000 +0200
Dmitry Belyavskiy 07172f
+++ ./kexecdh.c	2023-04-13 14:30:14.882449593 +0200
Dmitry Belyavskiy 07172f
@@ -35,17 +35,57 @@
Dmitry Belyavskiy 07172f
 #include <signal.h>
Dmitry Belyavskiy 07172f
 
Dmitry Belyavskiy 07172f
 #include <openssl/ecdh.h>
Dmitry Belyavskiy 07172f
+#include <openssl/evp.h>
Dmitry Belyavskiy 07172f
+#include <openssl/core_names.h>
Dmitry Belyavskiy 07172f
+#include <openssl/param_build.h>
Dmitry Belyavskiy 07172f
+#include <openssl/err.h>
Dmitry Belyavskiy 07172f
 
Dmitry Belyavskiy 07172f
 #include "sshkey.h"
Dmitry Belyavskiy 07172f
 #include "kex.h"
Dmitry Belyavskiy 07172f
 #include "sshbuf.h"
Dmitry Belyavskiy 07172f
 #include "digest.h"
Dmitry Belyavskiy 07172f
 #include "ssherr.h"
Dmitry Belyavskiy 07172f
+#include "log.h"
Dmitry Belyavskiy 07172f
 
Dmitry Belyavskiy 07172f
 static int
Dmitry Belyavskiy 07172f
 kex_ecdh_dec_key_group(struct kex *, const struct sshbuf *, EC_KEY *key,
Dmitry Belyavskiy 07172f
     const EC_GROUP *, struct sshbuf **);
Dmitry Belyavskiy 07172f
 
Dmitry Belyavskiy 07172f
+static EC_KEY *
Dmitry Belyavskiy 07172f
+generate_ec_keys(int ec_nid)
Dmitry Belyavskiy 07172f
+{
Dmitry Belyavskiy 07172f
+	EC_KEY *client_key = NULL;
Dmitry Belyavskiy 07172f
+	EVP_PKEY *pkey = NULL;
Dmitry Belyavskiy 07172f
+	EVP_PKEY_CTX *ctx = NULL;
Dmitry Belyavskiy 07172f
+	OSSL_PARAM_BLD *param_bld = NULL;
Dmitry Belyavskiy 07172f
+	OSSL_PARAM *params = NULL;
Dmitry Belyavskiy 07172f
+	const char *group_name;
Dmitry Belyavskiy 07172f
+
Dmitry Belyavskiy 07172f
+	if ((ctx = EVP_PKEY_CTX_new_from_name(NULL, "EC", NULL)) == NULL ||
Dmitry Belyavskiy 07172f
+	    (param_bld = OSSL_PARAM_BLD_new()) == NULL)
Dmitry Belyavskiy 07172f
+		goto out;
Dmitry Belyavskiy 07172f
+	if ((group_name = OSSL_EC_curve_nid2name(ec_nid)) == NULL ||
Dmitry Belyavskiy 07172f
+	    OSSL_PARAM_BLD_push_utf8_string(param_bld,
Dmitry Belyavskiy 07172f
+	        OSSL_PKEY_PARAM_GROUP_NAME, group_name, 0) != 1 ||
Dmitry Belyavskiy 07172f
+	    (params = OSSL_PARAM_BLD_to_param(param_bld)) == NULL) {
Dmitry Belyavskiy 07172f
+		error_f("Could not create OSSL_PARAM");
Dmitry Belyavskiy 07172f
+		goto out;
Dmitry Belyavskiy 07172f
+	}
Dmitry Belyavskiy 07172f
+	if (EVP_PKEY_keygen_init(ctx) != 1 ||
Dmitry Belyavskiy 07172f
+	    EVP_PKEY_CTX_set_params(ctx, params) != 1 ||
Dmitry Belyavskiy 07172f
+	    EVP_PKEY_generate(ctx, &pkey) != 1 ||
Dmitry Belyavskiy 07172f
+	    (client_key = EVP_PKEY_get1_EC_KEY(pkey)) == NULL) {
Dmitry Belyavskiy 07172f
+		error_f("Could not generate ec keys");
Dmitry Belyavskiy 07172f
+		goto out;
Dmitry Belyavskiy 07172f
+	}
Dmitry Belyavskiy 07172f
+out:
Dmitry Belyavskiy 07172f
+	EVP_PKEY_free(pkey);
Dmitry Belyavskiy 07172f
+	EVP_PKEY_CTX_free(ctx);
Dmitry Belyavskiy 07172f
+	OSSL_PARAM_BLD_free(param_bld);
Dmitry Belyavskiy 07172f
+	OSSL_PARAM_free(params);
Dmitry Belyavskiy 07172f
+	return client_key;
Dmitry Belyavskiy 07172f
+}
Dmitry Belyavskiy 07172f
+
Dmitry Belyavskiy 07172f
 int
Dmitry Belyavskiy 07172f
 kex_ecdh_keypair(struct kex *kex)
Dmitry Belyavskiy 07172f
 {
Dmitry Belyavskiy 07172f
@@ -55,11 +95,7 @@
Dmitry Belyavskiy 07172f
 	struct sshbuf *buf = NULL;
Dmitry Belyavskiy 07172f
 	int r;
Dmitry Belyavskiy 07172f
 
Dmitry Belyavskiy 07172f
-	if ((client_key = EC_KEY_new_by_curve_name(kex->ec_nid)) == NULL) {
Dmitry Belyavskiy 07172f
-		r = SSH_ERR_ALLOC_FAIL;
Dmitry Belyavskiy 07172f
-		goto out;
Dmitry Belyavskiy 07172f
-	}
Dmitry Belyavskiy 07172f
-	if (EC_KEY_generate_key(client_key) != 1) {
Dmitry Belyavskiy 07172f
+	if ((client_key = generate_ec_keys(kex->ec_nid)) == NULL) {
Dmitry Belyavskiy 07172f
 		r = SSH_ERR_LIBCRYPTO_ERROR;
Dmitry Belyavskiy 07172f
 		goto out;
Dmitry Belyavskiy 07172f
 	}
Dmitry Belyavskiy 07172f
@@ -101,11 +137,7 @@
Dmitry Belyavskiy 07172f
 	*server_blobp = NULL;
Dmitry Belyavskiy 07172f
 	*shared_secretp = NULL;
Dmitry Belyavskiy 07172f
 
Dmitry Belyavskiy 07172f
-	if ((server_key = EC_KEY_new_by_curve_name(kex->ec_nid)) == NULL) {
Dmitry Belyavskiy 07172f
-		r = SSH_ERR_ALLOC_FAIL;
Dmitry Belyavskiy 07172f
-		goto out;
Dmitry Belyavskiy 07172f
-	}
Dmitry Belyavskiy 07172f
-	if (EC_KEY_generate_key(server_key) != 1) {
Dmitry Belyavskiy 07172f
+	if ((server_key = generate_ec_keys(kex->ec_nid)) == NULL) {
Dmitry Belyavskiy 07172f
 		r = SSH_ERR_LIBCRYPTO_ERROR;
Dmitry Belyavskiy 07172f
 		goto out;
Dmitry Belyavskiy 07172f
 	}
Dmitry Belyavskiy 07172f
@@ -140,11 +172,21 @@
Dmitry Belyavskiy 07172f
 {
Dmitry Belyavskiy 07172f
 	struct sshbuf *buf = NULL;
Dmitry Belyavskiy 07172f
 	BIGNUM *shared_secret = NULL;
Dmitry Belyavskiy 07172f
-	EC_POINT *dh_pub = NULL;
Dmitry Belyavskiy 07172f
-	u_char *kbuf = NULL;
Dmitry Belyavskiy 07172f
-	size_t klen = 0;
Dmitry Belyavskiy 07172f
+	EVP_PKEY_CTX *ctx = NULL;
Dmitry Belyavskiy 07172f
+	EVP_PKEY *pkey = NULL, *dh_pkey = NULL;
Dmitry Belyavskiy 07172f
+	OSSL_PARAM_BLD *param_bld = NULL;
Dmitry Belyavskiy 07172f
+	OSSL_PARAM *params = NULL;
Dmitry Belyavskiy 07172f
+	u_char *kbuf = NULL, *pub = NULL;
Dmitry Belyavskiy 07172f
+	size_t klen = 0, publen;
Dmitry Belyavskiy 07172f
+	const char *group_name;
Dmitry Belyavskiy 07172f
 	int r;
Dmitry Belyavskiy 07172f
 
Dmitry Belyavskiy 07172f
+	/* import EC_KEY to EVP_PKEY */
Dmitry Belyavskiy 07172f
+	if ((r = kex_create_evp_ec(key, kex->ec_nid, &pkey)) != 0) {
Dmitry Belyavskiy 07172f
+		error_f("Could not create EVP_PKEY");
Dmitry Belyavskiy 07172f
+		goto out;
Dmitry Belyavskiy 07172f
+	}
Dmitry Belyavskiy 07172f
+
Dmitry Belyavskiy 07172f
 	*shared_secretp = NULL;
Dmitry Belyavskiy 07172f
 
Dmitry Belyavskiy 07172f
 	if ((buf = sshbuf_new()) == NULL) {
Dmitry Belyavskiy 07172f
@@ -153,45 +195,82 @@
Dmitry Belyavskiy 07172f
 	}
Dmitry Belyavskiy 07172f
 	if ((r = sshbuf_put_stringb(buf, ec_blob)) != 0)
Dmitry Belyavskiy 07172f
 		goto out;
Dmitry Belyavskiy 07172f
-	if ((dh_pub = EC_POINT_new(group)) == NULL) {
Dmitry Belyavskiy 07172f
+
Dmitry Belyavskiy 07172f
+	/* the public key is in the buffer in octet string UNCOMPRESSED
Dmitry Belyavskiy 07172f
+	 * format. See sshbuf_put_ec */
Dmitry Belyavskiy 07172f
+	if ((r = sshbuf_get_string(buf, &pub, &publen)) != 0)
Dmitry Belyavskiy 07172f
+		goto out;
Dmitry Belyavskiy 07172f
+	sshbuf_reset(buf);
Dmitry Belyavskiy 07172f
+	if ((ctx = EVP_PKEY_CTX_new_from_pkey(NULL, pkey, NULL)) == NULL ||
Dmitry Belyavskiy 07172f
+	    (param_bld = OSSL_PARAM_BLD_new()) == NULL) {
Dmitry Belyavskiy 07172f
 		r = SSH_ERR_ALLOC_FAIL;
Dmitry Belyavskiy 07172f
 		goto out;
Dmitry Belyavskiy 07172f
 	}
Dmitry Belyavskiy 07172f
-	if ((r = sshbuf_get_ec(buf, dh_pub, group)) != 0) {
Dmitry Belyavskiy 07172f
+	if ((group_name = OSSL_EC_curve_nid2name(kex->ec_nid)) == NULL) {
Dmitry Belyavskiy 07172f
+		r = SSH_ERR_LIBCRYPTO_ERROR;
Dmitry Belyavskiy 07172f
+		goto out;
Dmitry Belyavskiy 07172f
+	}
Dmitry Belyavskiy 07172f
+	if (OSSL_PARAM_BLD_push_octet_string(param_bld,
Dmitry Belyavskiy 07172f
+	        OSSL_PKEY_PARAM_PUB_KEY, pub, publen) != 1 ||
Dmitry Belyavskiy 07172f
+	    OSSL_PARAM_BLD_push_utf8_string(param_bld,
Dmitry Belyavskiy 07172f
+	        OSSL_PKEY_PARAM_GROUP_NAME, group_name, 0) != 1 ||
Dmitry Belyavskiy 07172f
+	    (params = OSSL_PARAM_BLD_to_param(param_bld)) == NULL) {
Dmitry Belyavskiy 07172f
+		error_f("Failed to set params for dh_pkey");
Dmitry Belyavskiy 07172f
+		r = SSH_ERR_LIBCRYPTO_ERROR;
Dmitry Belyavskiy 07172f
+		goto out;
Dmitry Belyavskiy 07172f
+	}
Dmitry Belyavskiy 07172f
+	if (EVP_PKEY_fromdata_init(ctx) != 1 ||
Dmitry Belyavskiy 07172f
+	    EVP_PKEY_fromdata(ctx, &dh_pkey,
Dmitry Belyavskiy 07172f
+	        EVP_PKEY_PUBLIC_KEY, params) != 1 ||
Dmitry Belyavskiy 07172f
+	    EVP_PKEY_public_check(ctx) != 1) {
Dmitry Belyavskiy 07172f
+		error_f("Peer public key import failed");
Dmitry Belyavskiy 07172f
+		r = SSH_ERR_LIBCRYPTO_ERROR;
Dmitry Belyavskiy 07172f
 		goto out;
Dmitry Belyavskiy 07172f
 	}
Dmitry Belyavskiy 07172f
-	sshbuf_reset(buf);
Dmitry Belyavskiy 07172f
 
Dmitry Belyavskiy 07172f
 #ifdef DEBUG_KEXECDH
Dmitry Belyavskiy 07172f
 	fputs("public key:\n", stderr);
Dmitry Belyavskiy 07172f
-	sshkey_dump_ec_point(group, dh_pub);
Dmitry Belyavskiy 07172f
+	EVP_PKEY_print_public_fp(stderr, dh_pkey, 0, NULL);
Dmitry Belyavskiy 07172f
 #endif
Dmitry Belyavskiy 07172f
-	if (sshkey_ec_validate_public(group, dh_pub) != 0) {
Dmitry Belyavskiy 07172f
-		r = SSH_ERR_MESSAGE_INCOMPLETE;
Dmitry Belyavskiy 07172f
+	EVP_PKEY_CTX_free(ctx);
Dmitry Belyavskiy 07172f
+	ctx = NULL;
Dmitry Belyavskiy 07172f
+	if ((ctx = EVP_PKEY_CTX_new_from_pkey(NULL, pkey, NULL)) == NULL ||
Dmitry Belyavskiy 07172f
+	    EVP_PKEY_derive_init(ctx) != 1 ||
Dmitry Belyavskiy 07172f
+	    EVP_PKEY_derive_set_peer(ctx, dh_pkey) != 1 ||
Dmitry Belyavskiy 07172f
+	    EVP_PKEY_derive(ctx, NULL, &klen) != 1) {
Dmitry Belyavskiy 07172f
+		error_f("Failed to get derive information");
Dmitry Belyavskiy 07172f
+		r = SSH_ERR_LIBCRYPTO_ERROR;
Dmitry Belyavskiy 07172f
 		goto out;
Dmitry Belyavskiy 07172f
 	}
Dmitry Belyavskiy 07172f
-	klen = (EC_GROUP_get_degree(group) + 7) / 8;
Dmitry Belyavskiy 07172f
-	if ((kbuf = malloc(klen)) == NULL ||
Dmitry Belyavskiy 07172f
-	    (shared_secret = BN_new()) == NULL) {
Dmitry Belyavskiy 07172f
+	if ((kbuf = malloc(klen)) == NULL) {
Dmitry Belyavskiy 07172f
 		r = SSH_ERR_ALLOC_FAIL;
Dmitry Belyavskiy 07172f
 		goto out;
Dmitry Belyavskiy 07172f
 	}
Dmitry Belyavskiy 07172f
-	if (ECDH_compute_key(kbuf, klen, dh_pub, key, NULL) != (int)klen ||
Dmitry Belyavskiy 07172f
-	    BN_bin2bn(kbuf, klen, shared_secret) == NULL) {
Dmitry Belyavskiy 07172f
+	if (EVP_PKEY_derive(ctx, kbuf, &klen) != 1) {
Dmitry Belyavskiy 07172f
 		r = SSH_ERR_LIBCRYPTO_ERROR;
Dmitry Belyavskiy 07172f
 		goto out;
Dmitry Belyavskiy 07172f
 	}
Dmitry Belyavskiy 07172f
 #ifdef DEBUG_KEXECDH
Dmitry Belyavskiy 07172f
 	dump_digest("shared secret", kbuf, klen);
Dmitry Belyavskiy 07172f
 #endif
Dmitry Belyavskiy 07172f
+	if ((shared_secret = BN_new()) == NULL ||
Dmitry Belyavskiy 07172f
+	    (BN_bin2bn(kbuf, klen, shared_secret) == NULL)) {
Dmitry Belyavskiy 07172f
+		r = SSH_ERR_ALLOC_FAIL;
Dmitry Belyavskiy 07172f
+		goto out;
Dmitry Belyavskiy 07172f
+	}
Dmitry Belyavskiy 07172f
 	if ((r = sshbuf_put_bignum2(buf, shared_secret)) != 0)
Dmitry Belyavskiy 07172f
 		goto out;
Dmitry Belyavskiy 07172f
 	*shared_secretp = buf;
Dmitry Belyavskiy 07172f
 	buf = NULL;
Dmitry Belyavskiy 07172f
  out:
Dmitry Belyavskiy 07172f
-	EC_POINT_clear_free(dh_pub);
Dmitry Belyavskiy 07172f
+	EVP_PKEY_CTX_free(ctx);
Dmitry Belyavskiy 07172f
+	EVP_PKEY_free(pkey);
Dmitry Belyavskiy 07172f
+	EVP_PKEY_free(dh_pkey);
Dmitry Belyavskiy 07172f
+	OSSL_PARAM_BLD_free(param_bld);
Dmitry Belyavskiy 07172f
+	OSSL_PARAM_free(params);
Dmitry Belyavskiy 07172f
 	BN_clear_free(shared_secret);
Dmitry Belyavskiy 07172f
 	freezero(kbuf, klen);
Dmitry Belyavskiy 07172f
+	freezero(pub, publen);
Dmitry Belyavskiy 07172f
 	sshbuf_free(buf);
Dmitry Belyavskiy 07172f
 	return r;
Dmitry Belyavskiy 07172f
 }