Petr Lautrbach fcef7f
diff --git a/readconf.c b/readconf.c
Petr Lautrbach fcef7f
index 99c04a9..375ca32 100644
Petr Lautrbach fcef7f
--- a/readconf.c
Petr Lautrbach fcef7f
+++ b/readconf.c
Petr Lautrbach fcef7f
@@ -1,4 +1,4 @@
Petr Lautrbach fcef7f
-/* $OpenBSD: readconf.c,v 1.194 2011/09/23 07:45:05 markus Exp $ */
Petr Lautrbach fcef7f
+/* $OpenBSD: readconf.c,v 1.196 2013/02/22 04:45:08 dtucker Exp $ */
Petr Lautrbach fcef7f
 /*
Petr Lautrbach fcef7f
  * Author: Tatu Ylonen <ylo@cs.hut.fi>
Petr Lautrbach fcef7f
  * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
Petr Lautrbach fcef7f
@@ -337,6 +337,26 @@ clear_forwardings(Options *options)
Petr Lautrbach fcef7f
 	options->tun_open = SSH_TUNMODE_NO;
Petr Lautrbach fcef7f
 }
Petr Lautrbach fcef7f
 
Petr Lautrbach fcef7f
+void
Petr Lautrbach fcef7f
+add_identity_file(Options *options, const char *dir, const char *filename,
Petr Lautrbach fcef7f
+    int userprovided)
Petr Lautrbach fcef7f
+{
Petr Lautrbach fcef7f
+	char *path;
Petr Lautrbach fcef7f
+
Petr Lautrbach fcef7f
+	if (options->num_identity_files >= SSH_MAX_IDENTITY_FILES)
Petr Lautrbach fcef7f
+		fatal("Too many identity files specified (max %d)",
Petr Lautrbach fcef7f
+		    SSH_MAX_IDENTITY_FILES);
Petr Lautrbach fcef7f
+
Petr Lautrbach fcef7f
+	if (dir == NULL) /* no dir, filename is absolute */
Petr Lautrbach fcef7f
+		path = xstrdup(filename);
Petr Lautrbach fcef7f
+	else
Petr Lautrbach fcef7f
+		(void)xasprintf(&path, "%.100s%.100s", dir, filename);
Petr Lautrbach fcef7f
+
Petr Lautrbach fcef7f
+	options->identity_file_userprovided[options->num_identity_files] =
Petr Lautrbach fcef7f
+	    userprovided;
Petr Lautrbach fcef7f
+	options->identity_files[options->num_identity_files++] = path;
Petr Lautrbach fcef7f
+}
Petr Lautrbach fcef7f
+
Petr Lautrbach fcef7f
 /*
Petr Lautrbach fcef7f
  * Returns the number of the token pointed to by cp or oBadOption.
Petr Lautrbach fcef7f
  */
Petr Lautrbach fcef7f
@@ -364,7 +384,7 @@ parse_token(const char *cp, const char *filename, int linenum)
Petr Lautrbach fcef7f
 int
Petr Lautrbach fcef7f
 process_config_line(Options *options, const char *host,
Petr Lautrbach fcef7f
 		    char *line, const char *filename, int linenum,
Petr Lautrbach fcef7f
-		    int *activep)
Petr Lautrbach fcef7f
+		    int *activep, int userconfig)
Petr Lautrbach fcef7f
 {
Petr Lautrbach fcef7f
 	char *s, **charptr, *endofnumber, *keyword, *arg, *arg2;
Petr Lautrbach fcef7f
 	char **cpptr, fwdarg[256];
Petr Lautrbach fcef7f
@@ -617,9 +637,7 @@ parse_yesnoask:
Petr Lautrbach fcef7f
 			if (*intptr >= SSH_MAX_IDENTITY_FILES)
Petr Lautrbach fcef7f
 				fatal("%.200s line %d: Too many identity files specified (max %d).",
Petr Lautrbach fcef7f
 				    filename, linenum, SSH_MAX_IDENTITY_FILES);
Petr Lautrbach fcef7f
-			charptr = &options->identity_files[*intptr];
Petr Lautrbach fcef7f
-			*charptr = xstrdup(arg);
Petr Lautrbach fcef7f
-			*intptr = *intptr + 1;
Petr Lautrbach fcef7f
+			add_identity_file(options, NULL, arg, userconfig);
Petr Lautrbach fcef7f
 		}
Petr Lautrbach fcef7f
 		break;
Petr Lautrbach fcef7f
 
Petr Lautrbach fcef7f
@@ -1106,7 +1124,7 @@ parse_int:
Petr Lautrbach fcef7f
 
Petr Lautrbach fcef7f
 int
Petr Lautrbach fcef7f
 read_config_file(const char *filename, const char *host, Options *options,
Petr Lautrbach fcef7f
-    int checkperm)
Petr Lautrbach fcef7f
+    int flags)
Petr Lautrbach fcef7f
 {
Petr Lautrbach fcef7f
 	FILE *f;
Petr Lautrbach fcef7f
 	char line[1024];
Petr Lautrbach fcef7f
@@ -1116,7 +1134,7 @@ read_config_file(const char *filename, const char *host, Options *options,
Petr Lautrbach fcef7f
 	if ((f = fopen(filename, "r")) == NULL)
Petr Lautrbach fcef7f
 		return 0;
Petr Lautrbach fcef7f
 
Petr Lautrbach fcef7f
-	if (checkperm) {
Petr Lautrbach fcef7f
+	if (flags & SSHCONF_CHECKPERM) {
Petr Lautrbach fcef7f
 		struct stat sb;
Petr Lautrbach fcef7f
 
Petr Lautrbach fcef7f
 		if (fstat(fileno(f), &sb) == -1)
Petr Lautrbach fcef7f
@@ -1137,7 +1155,8 @@ read_config_file(const char *filename, const char *host, Options *options,
Petr Lautrbach fcef7f
 	while (fgets(line, sizeof(line), f)) {
Petr Lautrbach fcef7f
 		/* Update line number counter. */
Petr Lautrbach fcef7f
 		linenum++;
Petr Lautrbach fcef7f
-		if (process_config_line(options, host, line, filename, linenum, &active) != 0)
Petr Lautrbach fcef7f
+		if (process_config_line(options, host, line, filename, linenum,
Petr Lautrbach fcef7f
+		    &active, flags & SSHCONF_USERCONF) != 0)
Petr Lautrbach fcef7f
 			bad_options++;
Petr Lautrbach fcef7f
 	}
Petr Lautrbach fcef7f
 	fclose(f);
Petr Lautrbach fcef7f
@@ -1322,30 +1341,17 @@ fill_default_options(Options * options)
Petr Lautrbach fcef7f
 		options->protocol = SSH_PROTO_2;
Petr Lautrbach fcef7f
 	if (options->num_identity_files == 0) {
Petr Lautrbach fcef7f
 		if (options->protocol & SSH_PROTO_1) {
Petr Lautrbach fcef7f
-			len = 2 + strlen(_PATH_SSH_CLIENT_IDENTITY) + 1;
Petr Lautrbach fcef7f
-			options->identity_files[options->num_identity_files] =
Petr Lautrbach fcef7f
-			    xmalloc(len);
Petr Lautrbach fcef7f
-			snprintf(options->identity_files[options->num_identity_files++],
Petr Lautrbach fcef7f
-			    len, "~/%.100s", _PATH_SSH_CLIENT_IDENTITY);
Petr Lautrbach fcef7f
+			add_identity_file(options, "~/",
Petr Lautrbach fcef7f
+			    _PATH_SSH_CLIENT_IDENTITY, 0);
Petr Lautrbach fcef7f
 		}
Petr Lautrbach fcef7f
 		if (options->protocol & SSH_PROTO_2) {
Petr Lautrbach fcef7f
-			len = 2 + strlen(_PATH_SSH_CLIENT_ID_RSA) + 1;
Petr Lautrbach fcef7f
-			options->identity_files[options->num_identity_files] =
Petr Lautrbach fcef7f
-			    xmalloc(len);
Petr Lautrbach fcef7f
-			snprintf(options->identity_files[options->num_identity_files++],
Petr Lautrbach fcef7f
-			    len, "~/%.100s", _PATH_SSH_CLIENT_ID_RSA);
Petr Lautrbach fcef7f
-
Petr Lautrbach fcef7f
-			len = 2 + strlen(_PATH_SSH_CLIENT_ID_DSA) + 1;
Petr Lautrbach fcef7f
-			options->identity_files[options->num_identity_files] =
Petr Lautrbach fcef7f
-			    xmalloc(len);
Petr Lautrbach fcef7f
-			snprintf(options->identity_files[options->num_identity_files++],
Petr Lautrbach fcef7f
-			    len, "~/%.100s", _PATH_SSH_CLIENT_ID_DSA);
Petr Lautrbach fcef7f
+			add_identity_file(options, "~/",
Petr Lautrbach fcef7f
+			    _PATH_SSH_CLIENT_ID_RSA, 0);
Petr Lautrbach fcef7f
+			add_identity_file(options, "~/",
Petr Lautrbach fcef7f
+			    _PATH_SSH_CLIENT_ID_DSA, 0);
Petr Lautrbach fcef7f
 #ifdef OPENSSL_HAS_ECC
Petr Lautrbach fcef7f
-			len = 2 + strlen(_PATH_SSH_CLIENT_ID_ECDSA) + 1;
Petr Lautrbach fcef7f
-			options->identity_files[options->num_identity_files] =
Petr Lautrbach fcef7f
-			    xmalloc(len);
Petr Lautrbach fcef7f
-			snprintf(options->identity_files[options->num_identity_files++],
Petr Lautrbach fcef7f
-			    len, "~/%.100s", _PATH_SSH_CLIENT_ID_ECDSA);
Petr Lautrbach fcef7f
+			add_identity_file(options, "~/",
Petr Lautrbach fcef7f
+			    _PATH_SSH_CLIENT_ID_ECDSA, 0);
Petr Lautrbach fcef7f
 #endif
Petr Lautrbach fcef7f
 		}
Petr Lautrbach fcef7f
 	}
Petr Lautrbach fcef7f
diff --git a/readconf.h b/readconf.h
Petr Lautrbach fcef7f
index 41f1bef..0835cb6 100644
Petr Lautrbach fcef7f
--- a/readconf.h
Petr Lautrbach fcef7f
+++ b/readconf.h
Petr Lautrbach fcef7f
@@ -1,4 +1,4 @@
Petr Lautrbach fcef7f
-/* $OpenBSD: readconf.h,v 1.91 2011/09/23 07:45:05 markus Exp $ */
Petr Lautrbach fcef7f
+/* $OpenBSD: readconf.h,v 1.93 2013/02/22 04:45:09 dtucker Exp $ */
Petr Lautrbach fcef7f
 
Petr Lautrbach fcef7f
 /*
Petr Lautrbach fcef7f
  * Author: Tatu Ylonen <ylo@cs.hut.fi>
Petr Lautrbach fcef7f
@@ -101,6 +101,7 @@ typedef struct {
Petr Lautrbach fcef7f
 
Petr Lautrbach fcef7f
 	int     num_identity_files;	/* Number of files for RSA/DSA identities. */
Petr Lautrbach fcef7f
 	char   *identity_files[SSH_MAX_IDENTITY_FILES];
Petr Lautrbach fcef7f
+	int    identity_file_userprovided[SSH_MAX_IDENTITY_FILES];
Petr Lautrbach fcef7f
 	Key    *identity_keys[SSH_MAX_IDENTITY_FILES];
Petr Lautrbach fcef7f
 
Petr Lautrbach fcef7f
 	/* Local TCP/IP forward requests. */
Petr Lautrbach fcef7f
@@ -153,15 +154,20 @@ typedef struct {
Petr Lautrbach fcef7f
 #define REQUEST_TTY_YES		2
Petr Lautrbach fcef7f
 #define REQUEST_TTY_FORCE	3
Petr Lautrbach fcef7f
 
Petr Lautrbach fcef7f
+#define SSHCONF_CHECKPERM	1  /* check permissions on config file */
Petr Lautrbach fcef7f
+#define SSHCONF_USERCONF	2  /* user provided config file not system */
Petr Lautrbach fcef7f
+
Petr Lautrbach fcef7f
 void     initialize_options(Options *);
Petr Lautrbach fcef7f
 void     fill_default_options(Options *);
Petr Lautrbach fcef7f
 int	 read_config_file(const char *, const char *, Options *, int);
Petr Lautrbach fcef7f
 int	 parse_forward(Forward *, const char *, int, int);
Petr Lautrbach fcef7f
 
Petr Lautrbach fcef7f
 int
Petr Lautrbach fcef7f
-process_config_line(Options *, const char *, char *, const char *, int, int *);
Petr Lautrbach fcef7f
+process_config_line(Options *, const char *, char *, const char *, int, int *,
Petr Lautrbach fcef7f
+    int);
Petr Lautrbach fcef7f
 
Petr Lautrbach fcef7f
 void	 add_local_forward(Options *, const Forward *);
Petr Lautrbach fcef7f
 void	 add_remote_forward(Options *, const Forward *);
Petr Lautrbach fcef7f
+void	 add_identity_file(Options *, const char *, const char *, int);
Petr Lautrbach fcef7f
 
Petr Lautrbach fcef7f
 #endif				/* READCONF_H */
Petr Lautrbach fcef7f
diff --git a/ssh.c b/ssh.c
Petr Lautrbach fcef7f
index 21b3fc7..606d449 100644
Petr Lautrbach fcef7f
--- a/ssh.c
Petr Lautrbach fcef7f
+++ b/ssh.c
Petr Lautrbach fcef7f
@@ -1,4 +1,4 @@
Petr Lautrbach fcef7f
-/* $OpenBSD: ssh.c,v 1.370 2012/07/06 01:47:38 djm Exp $ */
Petr Lautrbach fcef7f
+/* $OpenBSD: ssh.c,v 1.372 2013/02/22 04:45:09 dtucker Exp $ */
Petr Lautrbach fcef7f
 /*
Petr Lautrbach fcef7f
  * Author: Tatu Ylonen <ylo@cs.hut.fi>
Petr Lautrbach fcef7f
  * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
Petr Lautrbach fcef7f
@@ -414,12 +414,7 @@ main(int ac, char **av)
Petr Lautrbach fcef7f
 				    strerror(errno));
Petr Lautrbach fcef7f
 				break;
Petr Lautrbach fcef7f
 			}
Petr Lautrbach fcef7f
-			if (options.num_identity_files >=
Petr Lautrbach fcef7f
-			    SSH_MAX_IDENTITY_FILES)
Petr Lautrbach fcef7f
-				fatal("Too many identity files specified "
Petr Lautrbach fcef7f
-				    "(max %d)", SSH_MAX_IDENTITY_FILES);
Petr Lautrbach fcef7f
-			options.identity_files[options.num_identity_files++] =
Petr Lautrbach fcef7f
-			    xstrdup(optarg);
Petr Lautrbach fcef7f
+			add_identity_file(&options, NULL, optarg, 1);
Petr Lautrbach fcef7f
 			break;
Petr Lautrbach fcef7f
 		case 'I':
Petr Lautrbach fcef7f
 #ifdef ENABLE_PKCS11
Petr Lautrbach fcef7f
@@ -593,7 +588,8 @@ main(int ac, char **av)
Petr Lautrbach fcef7f
 			dummy = 1;
Petr Lautrbach fcef7f
 			line = xstrdup(optarg);
Petr Lautrbach fcef7f
 			if (process_config_line(&options, host ? host : "",
Petr Lautrbach fcef7f
-			    line, "command-line", 0, &dummy) != 0)
Petr Lautrbach fcef7f
+			    line, "command-line", 0, &dummy, SSHCONF_USERCONF)
Petr Lautrbach fcef7f
+			    != 0)
Petr Lautrbach fcef7f
 				exit(255);
Petr Lautrbach fcef7f
 			xfree(line);
Petr Lautrbach fcef7f
 			break;
Petr Lautrbach fcef7f
@@ -686,14 +682,15 @@ main(int ac, char **av)
Petr Lautrbach fcef7f
 	 * file if the user specifies a config file on the command line.
Petr Lautrbach fcef7f
 	 */
Petr Lautrbach fcef7f
 	if (config != NULL) {
Petr Lautrbach fcef7f
-		if (!read_config_file(config, host, &options, 0))
Petr Lautrbach fcef7f
+		if (!read_config_file(config, host, &options, SSHCONF_USERCONF))
Petr Lautrbach fcef7f
 			fatal("Can't open user config file %.100s: "
Petr Lautrbach fcef7f
 			    "%.100s", config, strerror(errno));
Petr Lautrbach fcef7f
 	} else {
Petr Lautrbach fcef7f
 		r = snprintf(buf, sizeof buf, "%s/%s", pw->pw_dir,
Petr Lautrbach fcef7f
 		    _PATH_SSH_USER_CONFFILE);
Petr Lautrbach fcef7f
 		if (r > 0 && (size_t)r < sizeof(buf))
Petr Lautrbach fcef7f
-			(void)read_config_file(buf, host, &options, 1);
Petr Lautrbach fcef7f
+			(void)read_config_file(buf, host, &options,
Petr Lautrbach fcef7f
+			     SSHCONF_CHECKPERM|SSHCONF_USERCONF);
Petr Lautrbach fcef7f
 
Petr Lautrbach fcef7f
 		/* Read systemwide configuration file after user config. */
Petr Lautrbach fcef7f
 		(void)read_config_file(_PATH_HOST_CONFIG_FILE, host,
Petr Lautrbach fcef7f
diff --git a/sshconnect2.c b/sshconnect2.c
Petr Lautrbach fcef7f
index 350abb5..a8b6276 100644
Petr Lautrbach fcef7f
--- a/sshconnect2.c
Petr Lautrbach fcef7f
+++ b/sshconnect2.c
Petr Lautrbach fcef7f
@@ -1,4 +1,4 @@
Petr Lautrbach fcef7f
-/* $OpenBSD: sshconnect2.c,v 1.191 2013/02/15 00:21:01 dtucker Exp $ */
Petr Lautrbach fcef7f
+/* $OpenBSD: sshconnect2.c,v 1.192 2013/02/17 23:16:57 dtucker Exp $ */
Petr Lautrbach fcef7f
 /*
Petr Lautrbach fcef7f
  * Copyright (c) 2000 Markus Friedl.  All rights reserved.
Petr Lautrbach fcef7f
  * Copyright (c) 2008 Damien Miller.  All rights reserved.
Petr Lautrbach fcef7f
@@ -1515,7 +1515,7 @@ pubkey_prepare(Authctxt *authctxt)
Petr Lautrbach fcef7f
 		id = xcalloc(1, sizeof(*id));
Petr Lautrbach fcef7f
 		id->key = key;
Petr Lautrbach fcef7f
 		id->filename = xstrdup(options.identity_files[i]);
Petr Lautrbach fcef7f
-		id->userprovided = 1;
Petr Lautrbach fcef7f
+		id->userprovided = options.identity_file_userprovided[i];
Petr Lautrbach fcef7f
 		TAILQ_INSERT_TAIL(&files, id, next);
Petr Lautrbach fcef7f
 	}
Petr Lautrbach fcef7f
 	/* Prefer PKCS11 keys that are explicitly listed */