|
 |
1a3082 |
From 9a8bb8a205656ca1089444a041c99c5591477642 Mon Sep 17 00:00:00 2001
|
|
|
1a3082 |
From: =?UTF-8?q?Marco=20Trevisan=20=28Trevi=C3=B1o=29?= <mail@3v1n0.net>
|
|
|
1a3082 |
Date: Fri, 3 May 2019 18:10:47 +0000
|
|
|
1a3082 |
Subject: [PATCH 2/2] window: Emit an error and return when trying to activate
|
|
|
1a3082 |
an unmanaged
|
|
|
1a3082 |
|
|
|
1a3082 |
If something (i.e. gnome-shell or an extension) tries to activate an unmanaged
|
|
|
1a3082 |
window, we should warn about this and avoid to perform further actions as this
|
|
|
1a3082 |
could lead to a crash of mutter, since the window has not valid flags (like
|
|
|
1a3082 |
workspace) set anymore at this stage.
|
|
|
1a3082 |
|
|
|
1a3082 |
Fixes https://gitlab.gnome.org/GNOME/mutter/issues/580
|
|
|
1a3082 |
|
|
|
1a3082 |
https://gitlab.gnome.org/GNOME/mutter/merge_requests/564
|
|
|
1a3082 |
|
|
|
1a3082 |
|
|
|
1a3082 |
(cherry picked from commit a6fc656e917fd48b8708b8d9f4bf9f8b15581313)
|
|
|
1a3082 |
---
|
|
|
1a3082 |
src/core/window.c | 7 +++++++
|
|
|
1a3082 |
1 file changed, 7 insertions(+)
|
|
|
1a3082 |
|
|
|
1a3082 |
diff --git a/src/core/window.c b/src/core/window.c
|
|
|
1a3082 |
index d2c24506b..725cca7ce 100644
|
|
|
1a3082 |
--- a/src/core/window.c
|
|
|
1a3082 |
+++ b/src/core/window.c
|
|
|
1a3082 |
@@ -3683,6 +3683,13 @@ meta_window_activate_full (MetaWindow *window,
|
|
|
1a3082 |
{
|
|
|
1a3082 |
MetaWorkspaceManager *workspace_manager = window->display->workspace_manager;
|
|
|
1a3082 |
gboolean allow_workspace_switch;
|
|
|
1a3082 |
+
|
|
|
1a3082 |
+ if (window->unmanaging)
|
|
|
1a3082 |
+ {
|
|
|
1a3082 |
+ g_warning ("Trying to activate unmanaged window '%s'", window->desc);
|
|
|
1a3082 |
+ return;
|
|
|
1a3082 |
+ }
|
|
|
1a3082 |
+
|
|
|
1a3082 |
meta_topic (META_DEBUG_FOCUS,
|
|
|
1a3082 |
"_NET_ACTIVE_WINDOW message sent for %s at time %u "
|
|
|
1a3082 |
"by client type %u.\n",
|
|
|
1a3082 |
--
|
|
|
1a3082 |
2.21.0
|
|
|
1a3082 |
|