|
 |
9501a8 |
From ad1a395707f7c37b26ce446f0fd73ac7fbb9d0fd Mon Sep 17 00:00:00 2001
|
|
|
9501a8 |
From: =?UTF-8?q?Florian=20M=C3=BCllner?= <fmuellner@gnome.org>
|
|
|
9501a8 |
Date: Tue, 9 Oct 2018 00:40:33 +0200
|
|
|
9501a8 |
Subject: [PATCH 1/2] x11/window-props: Do not convert WM_NAME
|
|
|
9501a8 |
|
|
|
9501a8 |
The WM_NAME property is of type TEXT_PROPERTY, which is supposed to be
|
|
|
9501a8 |
returned as UTF-8. Commit 840378ae68 broke that assumption, resulting
|
|
|
9501a8 |
in crashes with non-UTF8 locales; however the "fix" of converting from
|
|
|
9501a8 |
LATIN1 to UTF8 is wrong as well, as the conversion will spit out garbage
|
|
|
9501a8 |
when the input encoding isn't actually LATIN1.
|
|
|
9501a8 |
|
|
|
9501a8 |
Now that the original issue in text_property_to_utf8() has been fixed,
|
|
|
9501a8 |
we can simply revert the relevant bits of commit d62491f46eba748e.
|
|
|
9501a8 |
|
|
|
9501a8 |
https://gitlab.gnome.org/GNOME/mutter/merge_requests/227
|
|
|
9501a8 |
---
|
|
|
9501a8 |
src/x11/window-props.c | 5 +----
|
|
|
9501a8 |
1 file changed, 1 insertion(+), 4 deletions(-)
|
|
|
9501a8 |
|
|
|
9501a8 |
diff --git a/src/x11/window-props.c b/src/x11/window-props.c
|
|
|
9501a8 |
index 2f4dfeb31..7c6b25fdb 100644
|
|
|
9501a8 |
--- a/src/x11/window-props.c
|
|
|
9501a8 |
+++ b/src/x11/window-props.c
|
|
|
9501a8 |
@@ -645,10 +645,7 @@ reload_wm_name (MetaWindow *window,
|
|
|
9501a8 |
|
|
|
9501a8 |
if (value->type != META_PROP_VALUE_INVALID)
|
|
|
9501a8 |
{
|
|
|
9501a8 |
- g_autofree gchar *title = g_convert (value->v.str, -1,
|
|
|
9501a8 |
- "UTF-8", "LATIN1",
|
|
|
9501a8 |
- NULL, NULL, NULL);
|
|
|
9501a8 |
- set_window_title (window, title);
|
|
|
9501a8 |
+ set_window_title (window, value->v.str);
|
|
|
9501a8 |
|
|
|
9501a8 |
meta_verbose ("Using WM_NAME for new title of %s: \"%s\"\n",
|
|
|
9501a8 |
window->desc, window->title);
|
|
|
9501a8 |
--
|
|
|
9501a8 |
2.21.0
|
|
|
9501a8 |
|