|
 |
8156c2 |
From 376225cea044d050f8fc2923e7149d320150bab7 Mon Sep 17 00:00:00 2001
|
|
|
8156c2 |
From: Ray Strode <rstrode@redhat.com>
|
|
|
8156c2 |
Date: Mon, 29 Apr 2019 13:46:37 -0400
|
|
|
8156c2 |
Subject: [PATCH] window: free close dialog before unmanaging window from
|
|
|
8156c2 |
compositor
|
|
|
8156c2 |
|
|
|
8156c2 |
When an application stops responding, the shell darkens its windows.
|
|
|
8156c2 |
|
|
|
8156c2 |
If a window from a not-responding application gets unmanaged
|
|
|
8156c2 |
then the shell will currently throw an exception trying to retrieve
|
|
|
8156c2 |
the now-dissociated window actor.
|
|
|
8156c2 |
|
|
|
8156c2 |
That leads to a "stuck window" ghost on screen and a traceback
|
|
|
8156c2 |
in the log.
|
|
|
8156c2 |
|
|
|
8156c2 |
This commit addresses the problem by making sure the effect is cleaned
|
|
|
8156c2 |
up before the actor is disocciated from its window.
|
|
|
8156c2 |
|
|
|
8156c2 |
https://gitlab.gnome.org/GNOME/mutter/issues/575
|
|
|
8156c2 |
---
|
|
|
8156c2 |
src/core/window.c | 3 ++-
|
|
|
8156c2 |
1 file changed, 2 insertions(+), 1 deletion(-)
|
|
|
8156c2 |
|
|
|
8156c2 |
diff --git a/src/core/window.c b/src/core/window.c
|
|
|
8156c2 |
index cc0813ac4..aa85806f1 100644
|
|
|
8156c2 |
--- a/src/core/window.c
|
|
|
8156c2 |
+++ b/src/core/window.c
|
|
|
8156c2 |
@@ -1388,6 +1388,8 @@ meta_window_unmanage (MetaWindow *window,
|
|
|
8156c2 |
meta_verbose ("Unmanaging %s\n", window->desc);
|
|
|
8156c2 |
window->unmanaging = TRUE;
|
|
|
8156c2 |
|
|
|
8156c2 |
+ meta_window_free_delete_dialog (window);
|
|
|
8156c2 |
+
|
|
|
8156c2 |
#ifdef HAVE_WAYLAND
|
|
|
8156c2 |
/* This needs to happen for both Wayland and XWayland clients,
|
|
|
8156c2 |
* so it can't be in MetaWindowWayland. */
|
|
|
8156c2 |
@@ -1510,7 +1512,6 @@ meta_window_unmanage (MetaWindow *window,
|
|
|
8156c2 |
meta_window_unqueue (window, META_QUEUE_CALC_SHOWING |
|
|
|
8156c2 |
META_QUEUE_MOVE_RESIZE |
|
|
|
8156c2 |
META_QUEUE_UPDATE_ICON);
|
|
|
8156c2 |
- meta_window_free_delete_dialog (window);
|
|
|
8156c2 |
|
|
|
8156c2 |
set_workspace_state (window, FALSE, NULL);
|
|
|
8156c2 |
|
|
|
8156c2 |
--
|
|
|
8156c2 |
2.23.0
|
|
|
8156c2 |
|