Robert Scheck 15fe7b
From 5908af4c19188cb17b62f23368b6ef462831a0cb Mon Sep 17 00:00:00 2001
Robert Scheck 15fe7b
From: Marcus Meissner <meissner@suse.de>
Robert Scheck 15fe7b
Date: Tue, 11 Apr 2023 16:05:36 +0200
Robert Scheck 15fe7b
Subject: [PATCH] fixed the sizes passed into snprintf
Robert Scheck 15fe7b
Robert Scheck 15fe7b
---
Robert Scheck 15fe7b
 ui/report.c | 6 +++---
Robert Scheck 15fe7b
 1 file changed, 3 insertions(+), 3 deletions(-)
Robert Scheck 15fe7b
Robert Scheck 15fe7b
diff --git a/ui/report.c b/ui/report.c
Robert Scheck 15fe7b
index 9301480..61f2c74 100644
Robert Scheck 15fe7b
--- a/ui/report.c
Robert Scheck 15fe7b
+++ b/ui/report.c
Robert Scheck 15fe7b
@@ -140,7 +140,7 @@ void report_close(
Robert Scheck 15fe7b
             continue;
Robert Scheck 15fe7b
 
Robert Scheck 15fe7b
         snprintf(fmt, sizeof(fmt), "%%%ds", data_fields[j].length);
Robert Scheck 15fe7b
-        snprintf(buf + len, sizeof(buf), fmt, data_fields[j].title);
Robert Scheck 15fe7b
+        snprintf(buf + len, sizeof(buf) - len, fmt, data_fields[j].title);
Robert Scheck 15fe7b
         len += data_fields[j].length;
Robert Scheck 15fe7b
     }
Robert Scheck 15fe7b
     printf("%s\n", buf);
Robert Scheck 15fe7b
@@ -172,10 +172,10 @@ void report_close(
Robert Scheck 15fe7b
 
Robert Scheck 15fe7b
             /* 1000.0 is a temporary hack for stats usec to ms, impacted net_loss. */
Robert Scheck 15fe7b
             if (strchr(data_fields[j].format, 'f')) {
Robert Scheck 15fe7b
-                snprintf(buf + len, sizeof(buf), data_fields[j].format,
Robert Scheck 15fe7b
+                snprintf(buf + len, sizeof(buf) - len, data_fields[j].format,
Robert Scheck 15fe7b
                          data_fields[j].net_xxx(at) / 1000.0);
Robert Scheck 15fe7b
             } else {
Robert Scheck 15fe7b
-                snprintf(buf + len, sizeof(buf), data_fields[j].format,
Robert Scheck 15fe7b
+                snprintf(buf + len, sizeof(buf) - len, data_fields[j].format,
Robert Scheck 15fe7b
                          data_fields[j].net_xxx(at));
Robert Scheck 15fe7b
             }
Robert Scheck 15fe7b
             len += data_fields[j].length;