|
 |
b7f731 |
From b75805662e7208799207a8e5f8a61f69a44888f0 Mon Sep 17 00:00:00 2001
|
|
|
b7f731 |
From: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
|
|
|
b7f731 |
Date: Mon, 24 Apr 2017 16:03:26 +0200
|
|
|
b7f731 |
Subject: [RHEL7.5 PATCH 094/169] Don't use UnSet with consistency_policy
|
|
|
b7f731 |
|
|
|
b7f731 |
Use CONSISTENCY_POLICY_UNKNOWN instead. Simplify some checks because
|
|
|
b7f731 |
since 5e8e35fb7e17 ("maps: Use keyvalue for null terminator to indicate
|
|
|
b7f731 |
'unset' value") map_name() can return this default directly.
|
|
|
b7f731 |
|
|
|
b7f731 |
Suggested-by: Jes Sorensen <Jes.Sorensen@gmail.com>
|
|
|
b7f731 |
Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
|
|
|
b7f731 |
---
|
|
|
b7f731 |
maps.c | 2 +-
|
|
|
b7f731 |
mdadm.c | 12 ++++++------
|
|
|
b7f731 |
super-intel.c | 4 +---
|
|
|
b7f731 |
sysfs.c | 10 ++++------
|
|
|
b7f731 |
4 files changed, 12 insertions(+), 16 deletions(-)
|
|
|
b7f731 |
|
|
|
b7f731 |
diff --git a/maps.c b/maps.c
|
|
|
b7f731 |
index bb28ba6..02a0474 100644
|
|
|
b7f731 |
--- a/maps.c
|
|
|
b7f731 |
+++ b/maps.c
|
|
|
b7f731 |
@@ -137,7 +137,7 @@ mapping_t consistency_policies[] = {
|
|
|
b7f731 |
{ "bitmap", CONSISTENCY_POLICY_BITMAP},
|
|
|
b7f731 |
{ "journal", CONSISTENCY_POLICY_JOURNAL},
|
|
|
b7f731 |
{ "ppl", CONSISTENCY_POLICY_PPL},
|
|
|
b7f731 |
- { NULL, UnSet }
|
|
|
b7f731 |
+ { NULL, CONSISTENCY_POLICY_UNKNOWN }
|
|
|
b7f731 |
};
|
|
|
b7f731 |
|
|
|
b7f731 |
mapping_t sysfs_array_states[] = {
|
|
|
b7f731 |
diff --git a/mdadm.c b/mdadm.c
|
|
|
b7f731 |
index 41dae1d..b689e32 100644
|
|
|
b7f731 |
--- a/mdadm.c
|
|
|
b7f731 |
+++ b/mdadm.c
|
|
|
b7f731 |
@@ -78,7 +78,7 @@ int main(int argc, char *argv[])
|
|
|
b7f731 |
.level = UnSet,
|
|
|
b7f731 |
.layout = UnSet,
|
|
|
b7f731 |
.bitmap_chunk = UnSet,
|
|
|
b7f731 |
- .consistency_policy = UnSet,
|
|
|
b7f731 |
+ .consistency_policy = CONSISTENCY_POLICY_UNKNOWN,
|
|
|
b7f731 |
};
|
|
|
b7f731 |
|
|
|
b7f731 |
char sys_hostname[256];
|
|
|
b7f731 |
@@ -1228,8 +1228,7 @@ int main(int argc, char *argv[])
|
|
|
b7f731 |
case O(GROW, 'k'):
|
|
|
b7f731 |
s.consistency_policy = map_name(consistency_policies,
|
|
|
b7f731 |
optarg);
|
|
|
b7f731 |
- if (s.consistency_policy == UnSet ||
|
|
|
b7f731 |
- s.consistency_policy < CONSISTENCY_POLICY_RESYNC) {
|
|
|
b7f731 |
+ if (s.consistency_policy < CONSISTENCY_POLICY_RESYNC) {
|
|
|
b7f731 |
pr_err("Invalid consistency policy: %s\n",
|
|
|
b7f731 |
optarg);
|
|
|
b7f731 |
exit(2);
|
|
|
b7f731 |
@@ -1267,7 +1266,7 @@ int main(int argc, char *argv[])
|
|
|
b7f731 |
pr_err("--write-journal is only supported for RAID level 4/5/6.\n");
|
|
|
b7f731 |
exit(2);
|
|
|
b7f731 |
}
|
|
|
b7f731 |
- if (s.consistency_policy != UnSet &&
|
|
|
b7f731 |
+ if (s.consistency_policy != CONSISTENCY_POLICY_UNKNOWN &&
|
|
|
b7f731 |
s.consistency_policy != CONSISTENCY_POLICY_JOURNAL) {
|
|
|
b7f731 |
pr_err("--write-journal is not supported with consistency policy: %s\n",
|
|
|
b7f731 |
map_num(consistency_policies, s.consistency_policy));
|
|
|
b7f731 |
@@ -1275,7 +1274,8 @@ int main(int argc, char *argv[])
|
|
|
b7f731 |
}
|
|
|
b7f731 |
}
|
|
|
b7f731 |
|
|
|
b7f731 |
- if (mode == CREATE && s.consistency_policy != UnSet) {
|
|
|
b7f731 |
+ if (mode == CREATE &&
|
|
|
b7f731 |
+ s.consistency_policy != CONSISTENCY_POLICY_UNKNOWN) {
|
|
|
b7f731 |
if (s.level <= 0) {
|
|
|
b7f731 |
pr_err("--consistency-policy not meaningful with level %s.\n",
|
|
|
b7f731 |
map_num(pers, s.level));
|
|
|
b7f731 |
@@ -1687,7 +1687,7 @@ int main(int argc, char *argv[])
|
|
|
b7f731 |
rv = Grow_reshape(devlist->devname, mdfd,
|
|
|
b7f731 |
devlist->next,
|
|
|
b7f731 |
data_offset, &c, &s);
|
|
|
b7f731 |
- } else if (s.consistency_policy != UnSet) {
|
|
|
b7f731 |
+ } else if (s.consistency_policy != CONSISTENCY_POLICY_UNKNOWN) {
|
|
|
b7f731 |
rv = Grow_consistency_policy(devlist->devname, mdfd, &c, &s);
|
|
|
b7f731 |
} else if (array_size == 0)
|
|
|
b7f731 |
pr_err("no changes to --grow\n");
|
|
|
b7f731 |
diff --git a/super-intel.c b/super-intel.c
|
|
|
b7f731 |
index 0aed57c..fbff215 100644
|
|
|
b7f731 |
--- a/super-intel.c
|
|
|
b7f731 |
+++ b/super-intel.c
|
|
|
b7f731 |
@@ -5369,9 +5369,7 @@ static int init_super_imsm_volume(struct supertype *st, mdu_array_info_t *info,
|
|
|
b7f731 |
}
|
|
|
b7f731 |
mpb->num_raid_devs++;
|
|
|
b7f731 |
|
|
|
b7f731 |
- if (s->consistency_policy == UnSet ||
|
|
|
b7f731 |
- s->consistency_policy == CONSISTENCY_POLICY_RESYNC ||
|
|
|
b7f731 |
- s->consistency_policy == CONSISTENCY_POLICY_NONE) {
|
|
|
b7f731 |
+ if (s->consistency_policy <= CONSISTENCY_POLICY_RESYNC) {
|
|
|
b7f731 |
dev->rwh_policy = RWH_OFF;
|
|
|
b7f731 |
} else if (s->consistency_policy == CONSISTENCY_POLICY_PPL) {
|
|
|
b7f731 |
dev->rwh_policy = RWH_DISTRIBUTED;
|
|
|
b7f731 |
diff --git a/sysfs.c b/sysfs.c
|
|
|
b7f731 |
index 712f8b3..aa30de5 100644
|
|
|
b7f731 |
--- a/sysfs.c
|
|
|
b7f731 |
+++ b/sysfs.c
|
|
|
b7f731 |
@@ -254,13 +254,11 @@ struct mdinfo *sysfs_read(int fd, char *devnm, unsigned long options)
|
|
|
b7f731 |
|
|
|
b7f731 |
if (options & GET_CONSISTENCY_POLICY) {
|
|
|
b7f731 |
strcpy(base, "consistency_policy");
|
|
|
b7f731 |
- if (load_sys(fname, buf, sizeof(buf))) {
|
|
|
b7f731 |
+ if (load_sys(fname, buf, sizeof(buf)))
|
|
|
b7f731 |
sra->consistency_policy = CONSISTENCY_POLICY_UNKNOWN;
|
|
|
b7f731 |
- } else {
|
|
|
b7f731 |
- sra->consistency_policy = map_name(consistency_policies, buf);
|
|
|
b7f731 |
- if (sra->consistency_policy == UnSet)
|
|
|
b7f731 |
- sra->consistency_policy = CONSISTENCY_POLICY_UNKNOWN;
|
|
|
b7f731 |
- }
|
|
|
b7f731 |
+ else
|
|
|
b7f731 |
+ sra->consistency_policy = map_name(consistency_policies,
|
|
|
b7f731 |
+ buf);
|
|
|
b7f731 |
}
|
|
|
b7f731 |
|
|
|
b7f731 |
if (! (options & GET_DEVS))
|
|
|
b7f731 |
--
|
|
|
b7f731 |
2.7.4
|
|
|
b7f731 |
|