|
 |
9c6c51 |
From b99c528bade746897154a3e63c7a53e33becc937 Mon Sep 17 00:00:00 2001
|
|
|
9c6c51 |
Message-Id: <b99c528bade746897154a3e63c7a53e33becc937@dist-git>
|
|
|
9c6c51 |
From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>
|
|
|
9c6c51 |
Date: Fri, 6 Jul 2018 15:46:59 +0100
|
|
|
9c6c51 |
Subject: [PATCH] qemu: remove chardevStdioLogd param from vhostuser code path
|
|
|
9c6c51 |
MIME-Version: 1.0
|
|
|
9c6c51 |
Content-Type: text/plain; charset=UTF-8
|
|
|
9c6c51 |
Content-Transfer-Encoding: 8bit
|
|
|
9c6c51 |
|
|
|
9c6c51 |
https://bugzilla.redhat.com/show_bug.cgi?id=1597940
|
|
|
9c6c51 |
|
|
|
9c6c51 |
The vhostuser network backend is only supported with the UNIX domain
|
|
|
9c6c51 |
socket chardev backend, so passing around chardevStdioLogd is not
|
|
|
9c6c51 |
required.
|
|
|
9c6c51 |
|
|
|
9c6c51 |
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
|
|
|
9c6c51 |
(cherry picked from commit 4c76266baca407ae4981a180aed45193e50a8ade)
|
|
|
9c6c51 |
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
|
|
|
9c6c51 |
---
|
|
|
9c6c51 |
src/qemu/qemu_command.c | 20 +++++++-------------
|
|
|
9c6c51 |
1 file changed, 7 insertions(+), 13 deletions(-)
|
|
|
9c6c51 |
|
|
|
9c6c51 |
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
|
|
|
9c6c51 |
index 4120e4f983..41050bfea3 100644
|
|
|
9c6c51 |
--- a/src/qemu/qemu_command.c
|
|
|
9c6c51 |
+++ b/src/qemu/qemu_command.c
|
|
|
9c6c51 |
@@ -8223,8 +8223,7 @@ qemuBuildVhostuserCommandLine(virQEMUDriverPtr driver,
|
|
|
9c6c51 |
virDomainDefPtr def,
|
|
|
9c6c51 |
virDomainNetDefPtr net,
|
|
|
9c6c51 |
virQEMUCapsPtr qemuCaps,
|
|
|
9c6c51 |
- unsigned int bootindex,
|
|
|
9c6c51 |
- bool chardevStdioLogd)
|
|
|
9c6c51 |
+ unsigned int bootindex)
|
|
|
9c6c51 |
{
|
|
|
9c6c51 |
virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
|
|
|
9c6c51 |
char *chardev = NULL;
|
|
|
9c6c51 |
@@ -8245,7 +8244,7 @@ qemuBuildVhostuserCommandLine(virQEMUDriverPtr driver,
|
|
|
9c6c51 |
cmd, cfg, def,
|
|
|
9c6c51 |
net->data.vhostuser,
|
|
|
9c6c51 |
net->info.alias, qemuCaps, false,
|
|
|
9c6c51 |
- chardevStdioLogd)))
|
|
|
9c6c51 |
+ false)))
|
|
|
9c6c51 |
goto cleanup;
|
|
|
9c6c51 |
break;
|
|
|
9c6c51 |
|
|
|
9c6c51 |
@@ -8319,8 +8318,7 @@ qemuBuildInterfaceCommandLine(virQEMUDriverPtr driver,
|
|
|
9c6c51 |
virNetDevVPortProfileOp vmop,
|
|
|
9c6c51 |
bool standalone,
|
|
|
9c6c51 |
size_t *nnicindexes,
|
|
|
9c6c51 |
- int **nicindexes,
|
|
|
9c6c51 |
- bool chardevStdioLogd)
|
|
|
9c6c51 |
+ int **nicindexes)
|
|
|
9c6c51 |
{
|
|
|
9c6c51 |
int ret = -1;
|
|
|
9c6c51 |
char *nic = NULL, *host = NULL;
|
|
|
9c6c51 |
@@ -8443,8 +8441,7 @@ qemuBuildInterfaceCommandLine(virQEMUDriverPtr driver,
|
|
|
9c6c51 |
|
|
|
9c6c51 |
case VIR_DOMAIN_NET_TYPE_VHOSTUSER:
|
|
|
9c6c51 |
ret = qemuBuildVhostuserCommandLine(driver, logManager, secManager, cmd, def,
|
|
|
9c6c51 |
- net, qemuCaps, bootindex,
|
|
|
9c6c51 |
- chardevStdioLogd);
|
|
|
9c6c51 |
+ net, qemuCaps, bootindex);
|
|
|
9c6c51 |
goto cleanup;
|
|
|
9c6c51 |
break;
|
|
|
9c6c51 |
|
|
|
9c6c51 |
@@ -8628,8 +8625,7 @@ qemuBuildNetCommandLine(virQEMUDriverPtr driver,
|
|
|
9c6c51 |
bool standalone,
|
|
|
9c6c51 |
size_t *nnicindexes,
|
|
|
9c6c51 |
int **nicindexes,
|
|
|
9c6c51 |
- unsigned int *bootHostdevNet,
|
|
|
9c6c51 |
- bool chardevStdioLogd)
|
|
|
9c6c51 |
+ unsigned int *bootHostdevNet)
|
|
|
9c6c51 |
{
|
|
|
9c6c51 |
size_t i;
|
|
|
9c6c51 |
int last_good_net = -1;
|
|
|
9c6c51 |
@@ -8656,8 +8652,7 @@ qemuBuildNetCommandLine(virQEMUDriverPtr driver,
|
|
|
9c6c51 |
if (qemuBuildInterfaceCommandLine(driver, logManager, secManager, cmd, def, net,
|
|
|
9c6c51 |
qemuCaps, bootNet, vmop,
|
|
|
9c6c51 |
standalone, nnicindexes,
|
|
|
9c6c51 |
- nicindexes,
|
|
|
9c6c51 |
- chardevStdioLogd) < 0)
|
|
|
9c6c51 |
+ nicindexes) < 0)
|
|
|
9c6c51 |
goto error;
|
|
|
9c6c51 |
|
|
|
9c6c51 |
last_good_net = i;
|
|
|
9c6c51 |
@@ -10318,8 +10313,7 @@ qemuBuildCommandLine(virQEMUDriverPtr driver,
|
|
|
9c6c51 |
|
|
|
9c6c51 |
if (qemuBuildNetCommandLine(driver, logManager, secManager, cmd, def,
|
|
|
9c6c51 |
qemuCaps, vmop, standalone,
|
|
|
9c6c51 |
- nnicindexes, nicindexes, &bootHostdevNet,
|
|
|
9c6c51 |
- chardevStdioLogd) < 0)
|
|
|
9c6c51 |
+ nnicindexes, nicindexes, &bootHostdevNet) < 0)
|
|
|
9c6c51 |
goto error;
|
|
|
9c6c51 |
|
|
|
9c6c51 |
if (qemuBuildSmartcardCommandLine(logManager, secManager, cmd, cfg, def, qemuCaps,
|
|
|
9c6c51 |
--
|
|
|
9c6c51 |
2.18.0
|
|
|
9c6c51 |
|