From 1cf501e2f4cb1e6840ddb8a8f7b051936f0f8b18 Mon Sep 17 00:00:00 2001

Message-Id: <1cf501e2f4cb1e6840ddb8a8f7b051936f0f8b18@dist-git>

From: Peter Krempa <pkrempa@redhat.com>

Date: Thu, 20 Apr 2017 11:33:10 +0200

Subject: [PATCH] qemu: hotplug: Don't save status XML when monitor is closed

In the vcpu hotplug code if exit from the monitor failed we would still

attempt to save the status XML. When the daemon is terminated the

monitor socket is closed. In such case, the written status XML would not

contain the monitor path and thus be invalid.

Avoid this issue by only saving status XML on success of the monitor

command.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1439452

(cherry picked from commit 355f5ab998994d40e011cec491483506bbefe04f)

---

 src/qemu/qemu_hotplug.c | 29 ++++++++++++++++-------------

 1 file changed, 16 insertions(+), 13 deletions(-)

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c

index 79d0dc94e..120bcdc62 100644

--- a/src/qemu/qemu_hotplug.c

+++ b/src/qemu/qemu_hotplug.c

@@ -5386,6 +5386,7 @@ qemuDomainRemoveVcpuAlias(virQEMUDriverPtr driver,

 static int

 qemuDomainHotplugDelVcpu(virQEMUDriverPtr driver,

+                         virQEMUDriverConfigPtr cfg,

                          virDomainObjPtr vm,

                          unsigned int vcpu)

 {

@@ -5427,6 +5428,11 @@ qemuDomainHotplugDelVcpu(virQEMUDriverPtr driver,

     if (qemuDomainRemoveVcpu(driver, vm, vcpu) < 0)

         goto cleanup;

+    qemuDomainVcpuPersistOrder(vm->def);

+

+    if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps) < 0)

+        goto cleanup;

+

     ret = 0;

  cleanup:

@@ -5437,6 +5443,7 @@ qemuDomainHotplugDelVcpu(virQEMUDriverPtr driver,

 static int

 qemuDomainHotplugAddVcpu(virQEMUDriverPtr driver,

+                         virQEMUDriverConfigPtr cfg,

                          virDomainObjPtr vm,

                          unsigned int vcpu)

 {

@@ -5497,6 +5504,11 @@ qemuDomainHotplugAddVcpu(virQEMUDriverPtr driver,

     if (qemuDomainValidateVcpuInfo(vm) < 0)

         goto cleanup;

+    qemuDomainVcpuPersistOrder(vm->def);

+

+    if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps) < 0)

+        goto cleanup;

+

     ret = 0;

  cleanup:

@@ -5611,7 +5623,6 @@ qemuDomainSetVcpusLive(virQEMUDriverPtr driver,

     qemuDomainObjPrivatePtr priv = vm->privateData;

     qemuCgroupEmulatorAllNodesDataPtr emulatorCgroup = NULL;

     ssize_t nextvcpu = -1;

-    int rc = 0;

     int ret = -1;

     if (qemuCgroupEmulatorAllNodesAllow(priv->cgroup, &emulatorCgroup) < 0)

@@ -5619,27 +5630,19 @@ qemuDomainSetVcpusLive(virQEMUDriverPtr driver,

     if (enable) {

         while ((nextvcpu = virBitmapNextSetBit(vcpumap, nextvcpu)) != -1) {

-            if ((rc = qemuDomainHotplugAddVcpu(driver, vm, nextvcpu)) < 0)

-                break;

+            if (qemuDomainHotplugAddVcpu(driver, cfg, vm, nextvcpu) < 0)

+                goto cleanup;

         }

     } else {

         for (nextvcpu = virDomainDefGetVcpusMax(vm->def) - 1; nextvcpu >= 0; nextvcpu--) {

             if (!virBitmapIsBitSet(vcpumap, nextvcpu))

                 continue;

-            if ((rc = qemuDomainHotplugDelVcpu(driver, vm, nextvcpu)) < 0)

-                break;

+            if (qemuDomainHotplugDelVcpu(driver, cfg, vm, nextvcpu) < 0)

+                goto cleanup;

         }

     }

-    qemuDomainVcpuPersistOrder(vm->def);

-

-    if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps) < 0)

-        goto cleanup;

-

-    if (rc < 0)

-        goto cleanup;

-

     ret = 0;

  cleanup:

-- 

2.12.2