From 0fcbd4b6e8027c5d6df0a6f8900596832b4f9faa Mon Sep 17 00:00:00 2001

Message-Id: <0fcbd4b6e8027c5d6df0a6f8900596832b4f9faa@dist-git>

From: Stefan Berger <stefanb@linux.vnet.ibm.com>

Date: Thu, 17 Apr 2014 06:30:08 -0400

Subject: [PATCH] qemu: Unlock the NWFilter update lock by leaving via the

 cleanup label

Fix a locking problem by leaving the function via the cleanup label.

Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>

https://bugzilla.redhat.com/show_bug.cgi?id=1112690

(cherry picked from commit a4209f53795290ff9f2173092800eb3f767fff3e)

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>

---

 src/qemu/qemu_driver.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c

index 89be90c..475b752 100644

--- a/src/qemu/qemu_driver.c

+++ b/src/qemu/qemu_driver.c

@@ -6173,7 +6173,7 @@ qemuDomainCreateWithFlags(virDomainPtr dom, unsigned int flags)

     virNWFilterReadLockFilterUpdates();

     if (!(vm = qemuDomObjFromDomain(dom)))

-        return -1;

+        goto cleanup;

     if (virDomainCreateWithFlagsEnsureACL(dom->conn, vm->def) < 0)

         goto cleanup;

-- 

2.0.0