Pablo Greco 40546a
From 088d9da6e6c4f3edc0293f78ba7270941d2e7fd0 Mon Sep 17 00:00:00 2001
Pablo Greco 40546a
Message-Id: <088d9da6e6c4f3edc0293f78ba7270941d2e7fd0@dist-git>
Pablo Greco 40546a
From: Jiri Denemark <jdenemar@redhat.com>
Pablo Greco 40546a
Date: Fri, 21 Jun 2019 09:25:23 +0200
Pablo Greco 40546a
Subject: [PATCH] cpu_x86: Rename virCPUx86Vendor.cpuid
Pablo Greco 40546a
MIME-Version: 1.0
Pablo Greco 40546a
Content-Type: text/plain; charset=UTF-8
Pablo Greco 40546a
Content-Transfer-Encoding: 8bit
Pablo Greco 40546a
Pablo Greco 40546a
Although vendor string is always reported by CPUID, the container struct
Pablo Greco 40546a
is used for consistency and thus "cpuid" name is not a good fit anymore.
Pablo Greco 40546a
Pablo Greco 40546a
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Pablo Greco 40546a
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Pablo Greco 40546a
(cherry picked from commit c02d70d52efc4b7af09e68847ef72ad47a6bdcf1)
Pablo Greco 40546a
Pablo Greco 40546a
https://bugzilla.redhat.com/show_bug.cgi?id=1697627
Pablo Greco 40546a
Pablo Greco 40546a
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Pablo Greco 40546a
Message-Id: <0b6fccb50f2ce2b5d926a75c90a8107a300c8d57.1561068591.git.jdenemar@redhat.com>
Pablo Greco 40546a
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Pablo Greco 40546a
---
Pablo Greco 40546a
 src/cpu/cpu_x86.c | 18 +++++++++---------
Pablo Greco 40546a
 1 file changed, 9 insertions(+), 9 deletions(-)
Pablo Greco 40546a
Pablo Greco 40546a
diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
Pablo Greco 40546a
index 2e953eaa12..6e1fb37d20 100644
Pablo Greco 40546a
--- a/src/cpu/cpu_x86.c
Pablo Greco 40546a
+++ b/src/cpu/cpu_x86.c
Pablo Greco 40546a
@@ -49,7 +49,7 @@ typedef struct _virCPUx86Vendor virCPUx86Vendor;
Pablo Greco 40546a
 typedef virCPUx86Vendor *virCPUx86VendorPtr;
Pablo Greco 40546a
 struct _virCPUx86Vendor {
Pablo Greco 40546a
     char *name;
Pablo Greco 40546a
-    virCPUx86DataItem cpuid;
Pablo Greco 40546a
+    virCPUx86DataItem data;
Pablo Greco 40546a
 };
Pablo Greco 40546a
 
Pablo Greco 40546a
 typedef struct _virCPUx86Feature virCPUx86Feature;
Pablo Greco 40546a
@@ -514,9 +514,9 @@ x86DataToVendor(const virCPUx86Data *data,
Pablo Greco 40546a
 
Pablo Greco 40546a
     for (i = 0; i < map->nvendors; i++) {
Pablo Greco 40546a
         virCPUx86VendorPtr vendor = map->vendors[i];
Pablo Greco 40546a
-        if ((cpuid = x86DataCpuid(data, &vendor->cpuid)) &&
Pablo Greco 40546a
-            x86cpuidMatchMasked(&cpuid->cpuid, &vendor->cpuid.cpuid)) {
Pablo Greco 40546a
-            x86cpuidClearBits(&cpuid->cpuid, &vendor->cpuid.cpuid);
Pablo Greco 40546a
+        if ((cpuid = x86DataCpuid(data, &vendor->data)) &&
Pablo Greco 40546a
+            x86cpuidMatchMasked(&cpuid->cpuid, &vendor->data.cpuid)) {
Pablo Greco 40546a
+            x86cpuidClearBits(&cpuid->cpuid, &vendor->data.cpuid);
Pablo Greco 40546a
             return vendor;
Pablo Greco 40546a
         }
Pablo Greco 40546a
     }
Pablo Greco 40546a
@@ -759,7 +759,7 @@ x86VendorParse(xmlXPathContextPtr ctxt,
Pablo Greco 40546a
         goto cleanup;
Pablo Greco 40546a
     }
Pablo Greco 40546a
 
Pablo Greco 40546a
-    if (virCPUx86VendorToCPUID(string, &vendor->cpuid) < 0)
Pablo Greco 40546a
+    if (virCPUx86VendorToCPUID(string, &vendor->data) < 0)
Pablo Greco 40546a
         goto cleanup;
Pablo Greco 40546a
 
Pablo Greco 40546a
     if (VIR_APPEND_ELEMENT(map->vendors, map->nvendors, vendor) < 0)
Pablo Greco 40546a
@@ -1665,7 +1665,7 @@ x86Compute(virCPUDefPtr host,
Pablo Greco 40546a
 
Pablo Greco 40546a
         if (cpu->vendor && host_model->vendor &&
Pablo Greco 40546a
             virCPUx86DataAddCPUIDInt(&guest_model->data,
Pablo Greco 40546a
-                                     &host_model->vendor->cpuid) < 0)
Pablo Greco 40546a
+                                     &host_model->vendor->data) < 0)
Pablo Greco 40546a
             goto error;
Pablo Greco 40546a
 
Pablo Greco 40546a
         if (host_model->signatures &&
Pablo Greco 40546a
@@ -2153,7 +2153,7 @@ x86Encode(virArch arch,
Pablo Greco 40546a
         if (!(data_vendor = virCPUDataNew(arch)))
Pablo Greco 40546a
             goto error;
Pablo Greco 40546a
 
Pablo Greco 40546a
-        if (v && virCPUx86DataAddCPUID(data_vendor, &v->cpuid) < 0)
Pablo Greco 40546a
+        if (v && virCPUx86DataAddCPUID(data_vendor, &v->data) < 0)
Pablo Greco 40546a
             goto error;
Pablo Greco 40546a
     }
Pablo Greco 40546a
 
Pablo Greco 40546a
@@ -2650,7 +2650,7 @@ virCPUx86Baseline(virCPUDefPtr *cpus,
Pablo Greco 40546a
     }
Pablo Greco 40546a
 
Pablo Greco 40546a
     if (vendor &&
Pablo Greco 40546a
-        virCPUx86DataAddCPUIDInt(&base_model->data, &vendor->cpuid) < 0)
Pablo Greco 40546a
+        virCPUx86DataAddCPUIDInt(&base_model->data, &vendor->data) < 0)
Pablo Greco 40546a
         goto error;
Pablo Greco 40546a
 
Pablo Greco 40546a
     if (x86Decode(cpu, &base_model->data, models, modelName, migratable) < 0)
Pablo Greco 40546a
@@ -2949,7 +2949,7 @@ virCPUx86Translate(virCPUDefPtr cpu,
Pablo Greco 40546a
         goto cleanup;
Pablo Greco 40546a
 
Pablo Greco 40546a
     if (model->vendor &&
Pablo Greco 40546a
-        virCPUx86DataAddCPUIDInt(&model->data, &model->vendor->cpuid) < 0)
Pablo Greco 40546a
+        virCPUx86DataAddCPUIDInt(&model->data, &model->vendor->data) < 0)
Pablo Greco 40546a
         goto cleanup;
Pablo Greco 40546a
 
Pablo Greco 40546a
     if (model->signatures &&
Pablo Greco 40546a
-- 
Pablo Greco 40546a
2.22.0
Pablo Greco 40546a