|
 |
9c6c51 |
From 2d4b19613c462e876ee1327d600f5cbbb998c540 Mon Sep 17 00:00:00 2001
|
|
|
9c6c51 |
Message-Id: <2d4b19613c462e876ee1327d600f5cbbb998c540@dist-git>
|
|
|
9c6c51 |
From: John Ferlan <jferlan@redhat.com>
|
|
|
9c6c51 |
Date: Mon, 17 Dec 2018 20:42:30 -0500
|
|
|
9c6c51 |
Subject: [PATCH] RHEL: qemu: Add ability to set sgio values for hostdev
|
|
|
9c6c51 |
MIME-Version: 1.0
|
|
|
9c6c51 |
Content-Type: text/plain; charset=UTF-8
|
|
|
9c6c51 |
Content-Transfer-Encoding: 8bit
|
|
|
9c6c51 |
|
|
|
9c6c51 |
https://bugzilla.redhat.com/show_bug.cgi?id=1582424
|
|
|
9c6c51 |
|
|
|
9c6c51 |
RHEL-only
|
|
|
9c6c51 |
|
|
|
9c6c51 |
Add necessary checks in order to allow setting sgio values for a scsi
|
|
|
9c6c51 |
host device
|
|
|
9c6c51 |
|
|
|
9c6c51 |
Signed-off-by: John Ferlan <jferlan@redhat.com>
|
|
|
9c6c51 |
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
|
|
|
9c6c51 |
(cherry picked from commit f2cf0ae7bc371c75f6c0e79192711f2b1d201b10)
|
|
|
9c6c51 |
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
|
9c6c51 |
---
|
|
|
9c6c51 |
src/qemu/qemu_conf.c | 16 +++++++++-------
|
|
|
9c6c51 |
1 file changed, 9 insertions(+), 7 deletions(-)
|
|
|
9c6c51 |
|
|
|
9c6c51 |
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
|
|
|
9c6c51 |
index a4f545ef92..3ea9784854 100644
|
|
|
9c6c51 |
--- a/src/qemu/qemu_conf.c
|
|
|
9c6c51 |
+++ b/src/qemu/qemu_conf.c
|
|
|
9c6c51 |
@@ -1633,6 +1633,7 @@ qemuSetUnprivSGIO(virDomainDeviceDefPtr dev)
|
|
|
9c6c51 |
virDomainDiskDefPtr disk = NULL;
|
|
|
9c6c51 |
virDomainHostdevDefPtr hostdev = NULL;
|
|
|
9c6c51 |
char *sysfs_path = NULL;
|
|
|
9c6c51 |
+ char *hostdev_path = NULL;
|
|
|
9c6c51 |
const char *path = NULL;
|
|
|
9c6c51 |
int val = -1;
|
|
|
9c6c51 |
int ret = -1;
|
|
|
9c6c51 |
@@ -1654,14 +1655,10 @@ qemuSetUnprivSGIO(virDomainDeviceDefPtr dev)
|
|
|
9c6c51 |
if (!qemuIsSharedHostdev(hostdev))
|
|
|
9c6c51 |
return 0;
|
|
|
9c6c51 |
|
|
|
9c6c51 |
- if (hostdev->source.subsys.u.scsi.sgio) {
|
|
|
9c6c51 |
- virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
|
9c6c51 |
- _("'sgio' is not supported for SCSI "
|
|
|
9c6c51 |
- "generic device yet "));
|
|
|
9c6c51 |
+ if (!(hostdev_path = qemuGetHostdevPath(hostdev)))
|
|
|
9c6c51 |
goto cleanup;
|
|
|
9c6c51 |
- }
|
|
|
9c6c51 |
|
|
|
9c6c51 |
- return 0;
|
|
|
9c6c51 |
+ path = hostdev_path;
|
|
|
9c6c51 |
} else {
|
|
|
9c6c51 |
return 0;
|
|
|
9c6c51 |
}
|
|
|
9c6c51 |
@@ -1670,7 +1667,11 @@ qemuSetUnprivSGIO(virDomainDeviceDefPtr dev)
|
|
|
9c6c51 |
goto cleanup;
|
|
|
9c6c51 |
|
|
|
9c6c51 |
/* By default, filter the SG_IO commands, i.e. set unpriv_sgio to 0. */
|
|
|
9c6c51 |
- val = (disk->sgio == VIR_DOMAIN_DEVICE_SGIO_UNFILTERED);
|
|
|
9c6c51 |
+ if (dev->type == VIR_DOMAIN_DEVICE_DISK)
|
|
|
9c6c51 |
+ val = (disk->sgio == VIR_DOMAIN_DEVICE_SGIO_UNFILTERED);
|
|
|
9c6c51 |
+ else
|
|
|
9c6c51 |
+ val = (hostdev->source.subsys.u.scsi.sgio ==
|
|
|
9c6c51 |
+ VIR_DOMAIN_DEVICE_SGIO_UNFILTERED);
|
|
|
9c6c51 |
|
|
|
9c6c51 |
/* Do not do anything if unpriv_sgio is not supported by the kernel and the
|
|
|
9c6c51 |
* whitelist is enabled. But if requesting unfiltered access, always call
|
|
|
9c6c51 |
@@ -1683,6 +1684,7 @@ qemuSetUnprivSGIO(virDomainDeviceDefPtr dev)
|
|
|
9c6c51 |
ret = 0;
|
|
|
9c6c51 |
|
|
|
9c6c51 |
cleanup:
|
|
|
9c6c51 |
+ VIR_FREE(hostdev_path);
|
|
|
9c6c51 |
VIR_FREE(sysfs_path);
|
|
|
9c6c51 |
return ret;
|
|
|
9c6c51 |
}
|
|
|
9c6c51 |
--
|
|
|
9c6c51 |
2.20.1
|
|
|
9c6c51 |
|