From 8c2c611df31d3b37f149385e4597c47300ae1489 Mon Sep 17 00:00:00 2001

From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= <berrange@redhat.com>

Date: Tue, 30 Apr 2019 16:51:37 +0100

Subject: [PATCH 2/3] locking: restrict sockets to mode 0600

MIME-Version: 1.0

Content-Type: text/plain; charset=UTF-8

Content-Transfer-Encoding: 8bit

The virtlockd daemon's only intended client is the libvirtd daemon. As

such it should never allow clients from other user accounts to connect.

The code already enforces this and drops clients from other UIDs, but

we can get earlier (and thus stronger) protection against DoS by setting

the socket permissions to 0600

Fixes CVE-2019-10132

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

(cherry picked from commit f111e09468693909b1f067aa575efdafd9a262a1)

---

 src/locking/virtlockd-admin.socket.in | 1 +

 src/locking/virtlockd.socket.in       | 1 +

 2 files changed, 2 insertions(+)

diff --git a/src/locking/virtlockd-admin.socket.in b/src/locking/virtlockd-admin.socket.in

index 2a7500f3d0..f674c492f7 100644

--- a/src/locking/virtlockd-admin.socket.in

+++ b/src/locking/virtlockd-admin.socket.in

@@ -5,6 +5,7 @@ Before=libvirtd.service

 [Socket]

 ListenStream=@localstatedir@/run/libvirt/virtlockd-admin-sock

 Service=virtlockd.service

+SocketMode=0600

 [Install]

 WantedBy=sockets.target

diff --git a/src/locking/virtlockd.socket.in b/src/locking/virtlockd.socket.in

index 45e0f20235..d701b27516 100644

--- a/src/locking/virtlockd.socket.in

+++ b/src/locking/virtlockd.socket.in

@@ -4,6 +4,7 @@ Before=libvirtd.service

 [Socket]

 ListenStream=@localstatedir@/run/libvirt/virtlockd-sock

+SocketMode=0600

 [Install]

 WantedBy=sockets.target

-- 

2.21.0