|
 |
f325b2 |
From 388129064d30cd28ce9011ca459b19c238b9d005 Mon Sep 17 00:00:00 2001
|
|
|
f325b2 |
Message-Id: <388129064d30cd28ce9011ca459b19c238b9d005.1462273102.git.erack@redhat.com>
|
|
|
f325b2 |
From: Eike Rathke <erack@redhat.com>
|
|
|
f325b2 |
Date: Mon, 2 May 2016 16:25:01 +0200
|
|
|
f325b2 |
Subject: [PATCH] Resolves: tdf#99417 explicitly track formula cells for
|
|
|
f325b2 |
BROADCAST_BROADCASTERS
|
|
|
f325b2 |
MIME-Version: 1.0
|
|
|
f325b2 |
Content-Type: multipart/mixed; boundary="------------erAck-patch-parts"
|
|
|
f325b2 |
|
|
|
f325b2 |
This is a multi-part message in MIME format.
|
|
|
f325b2 |
--------------erAck-patch-parts
|
|
|
f325b2 |
Content-Type: text/plain; charset=UTF-8; format=fixed
|
|
|
f325b2 |
Content-Transfer-Encoding: 8bit
|
|
|
f325b2 |
|
|
|
f325b2 |
|
|
|
f325b2 |
Change-Id: I717fc6d1d7c2bc01ed2a256f6fc08a055be24e4b
|
|
|
f325b2 |
(cherry picked from commit a0b9fa819c9193dee1405cee13690adf00e2d9b9)
|
|
|
f325b2 |
Reviewed-on: https://gerrit.libreoffice.org/24592
|
|
|
f325b2 |
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
|
f325b2 |
Tested-by: Jenkins <ci@libreoffice.org>
|
|
|
f325b2 |
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
|
f325b2 |
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
|
f325b2 |
---
|
|
|
f325b2 |
sc/source/core/data/column.cxx | 9 ++++++++-
|
|
|
f325b2 |
1 file changed, 8 insertions(+), 1 deletion(-)
|
|
|
f325b2 |
|
|
|
f325b2 |
|
|
|
f325b2 |
--------------erAck-patch-parts
|
|
|
f325b2 |
Content-Type: text/x-patch; name="0001-Resolves-tdf-99417-explicitly-track-formula-cells-fo.patch"
|
|
|
f325b2 |
Content-Transfer-Encoding: 8bit
|
|
|
f325b2 |
Content-Disposition: attachment; filename="0001-Resolves-tdf-99417-explicitly-track-formula-cells-fo.patch"
|
|
|
f325b2 |
|
|
|
f325b2 |
diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx
|
|
|
f325b2 |
index 3a7daf1..48fb280 100644
|
|
|
f325b2 |
--- a/sc/source/core/data/column.cxx
|
|
|
f325b2 |
+++ b/sc/source/core/data/column.cxx
|
|
|
f325b2 |
@@ -3165,7 +3165,14 @@ void ScColumn::SetDirty( SCROW nRow1, SCROW nRow2, BroadcastMode eMode )
|
|
|
f325b2 |
sc::ProcessFormula(maCells.begin(), maCells, nRow1, nRow2, aHdl);
|
|
|
f325b2 |
// Broadcast all broadcasters in range.
|
|
|
f325b2 |
ScHint aHint( SC_HINT_DATACHANGED, ScAddress( nCol, nRow1, nTab));
|
|
|
f325b2 |
- BroadcastBroadcasters( nRow1, nRow2, aHint);
|
|
|
f325b2 |
+ if (BroadcastBroadcasters( nRow1, nRow2, aHint))
|
|
|
f325b2 |
+ {
|
|
|
f325b2 |
+ // SetDirtyOnRangeHandler implicitly tracks notified
|
|
|
f325b2 |
+ // formulas via ScDocument::Broadcast(), which
|
|
|
f325b2 |
+ // BroadcastBroadcastersHandler doesn't, so explicitly
|
|
|
f325b2 |
+ // track them here.
|
|
|
f325b2 |
+ pDocument->TrackFormulas();
|
|
|
f325b2 |
+ }
|
|
|
f325b2 |
}
|
|
|
f325b2 |
break;
|
|
|
f325b2 |
}
|
|
|
f325b2 |
|
|
|
f325b2 |
--------------erAck-patch-parts--
|
|
|
f325b2 |
|
|
|
f325b2 |
|