|
 |
e09bf5 |
diff -up libgcrypt-1.6.1/mpi/mpicoder.c.gccopt libgcrypt-1.6.1/mpi/mpicoder.c
|
|
|
e09bf5 |
--- libgcrypt-1.6.1/mpi/mpicoder.c.gccopt 2014-02-28 15:37:53.983139821 +0100
|
|
|
e09bf5 |
+++ libgcrypt-1.6.1/mpi/mpicoder.c 2014-02-28 15:47:35.312576387 +0100
|
|
|
e09bf5 |
@@ -627,16 +627,16 @@ _gcry_mpi_print (enum gcry_mpi_format fo
|
|
|
e09bf5 |
extra = 1;
|
|
|
e09bf5 |
}
|
|
|
e09bf5 |
|
|
|
e09bf5 |
- if (buffer && n > len)
|
|
|
e09bf5 |
- {
|
|
|
e09bf5 |
- /* The provided buffer is too short. */
|
|
|
e09bf5 |
- xfree (tmp);
|
|
|
e09bf5 |
- return GPG_ERR_TOO_SHORT;
|
|
|
e09bf5 |
- }
|
|
|
e09bf5 |
if (buffer)
|
|
|
e09bf5 |
{
|
|
|
e09bf5 |
unsigned char *s = buffer;
|
|
|
e09bf5 |
|
|
|
e09bf5 |
+ if (n > len)
|
|
|
e09bf5 |
+ {
|
|
|
e09bf5 |
+ /* The provided buffer is too short. */
|
|
|
e09bf5 |
+ xfree (tmp);
|
|
|
e09bf5 |
+ return GPG_ERR_TOO_SHORT;
|
|
|
e09bf5 |
+ }
|
|
|
e09bf5 |
if (extra == 1)
|
|
|
e09bf5 |
*s++ = 0;
|
|
|
e09bf5 |
else if (extra)
|
|
|
e09bf5 |
@@ -654,13 +654,12 @@ _gcry_mpi_print (enum gcry_mpi_format fo
|
|
|
e09bf5 |
/* Note: We ignore the sign for this format. */
|
|
|
e09bf5 |
/* FIXME: for performance reasons we should put this into
|
|
|
e09bf5 |
mpi_aprint because we can then use the buffer directly. */
|
|
|
e09bf5 |
-
|
|
|
e09bf5 |
- if (buffer && n > len)
|
|
|
e09bf5 |
- return GPG_ERR_TOO_SHORT;
|
|
|
e09bf5 |
if (buffer)
|
|
|
e09bf5 |
{
|
|
|
e09bf5 |
unsigned char *tmp;
|
|
|
e09bf5 |
|
|
|
e09bf5 |
+ if (n > len)
|
|
|
e09bf5 |
+ return GPG_ERR_TOO_SHORT;
|
|
|
e09bf5 |
tmp = _gcry_mpi_get_buffer (a, 0, &n, NULL);
|
|
|
e09bf5 |
if (!tmp)
|
|
|
e09bf5 |
return gpg_err_code_from_syserror ();
|
|
|
e09bf5 |
@@ -678,14 +677,14 @@ _gcry_mpi_print (enum gcry_mpi_format fo
|
|
|
e09bf5 |
if (negative)
|
|
|
e09bf5 |
return GPG_ERR_INV_ARG;
|
|
|
e09bf5 |
|
|
|
e09bf5 |
- if (buffer && n+2 > len)
|
|
|
e09bf5 |
- return GPG_ERR_TOO_SHORT;
|
|
|
e09bf5 |
-
|
|
|
e09bf5 |
if (buffer)
|
|
|
e09bf5 |
{
|
|
|
e09bf5 |
unsigned char *tmp;
|
|
|
e09bf5 |
unsigned char *s = buffer;
|
|
|
e09bf5 |
|
|
|
e09bf5 |
+ if (n+2 > len)
|
|
|
e09bf5 |
+ return GPG_ERR_TOO_SHORT;
|
|
|
e09bf5 |
+
|
|
|
e09bf5 |
s[0] = nbits >> 8;
|
|
|
e09bf5 |
s[1] = nbits;
|
|
|
e09bf5 |
|
|
|
e09bf5 |
@@ -724,16 +723,16 @@ _gcry_mpi_print (enum gcry_mpi_format fo
|
|
|
e09bf5 |
extra=1;
|
|
|
e09bf5 |
}
|
|
|
e09bf5 |
|
|
|
e09bf5 |
- if (buffer && n+4 > len)
|
|
|
e09bf5 |
- {
|
|
|
e09bf5 |
- xfree(tmp);
|
|
|
e09bf5 |
- return GPG_ERR_TOO_SHORT;
|
|
|
e09bf5 |
- }
|
|
|
e09bf5 |
-
|
|
|
e09bf5 |
if (buffer)
|
|
|
e09bf5 |
{
|
|
|
e09bf5 |
unsigned char *s = buffer;
|
|
|
e09bf5 |
|
|
|
e09bf5 |
+ if (n+4 > len)
|
|
|
e09bf5 |
+ {
|
|
|
e09bf5 |
+ xfree(tmp);
|
|
|
e09bf5 |
+ return GPG_ERR_TOO_SHORT;
|
|
|
e09bf5 |
+ }
|
|
|
e09bf5 |
+
|
|
|
e09bf5 |
*s++ = n >> 24;
|
|
|
e09bf5 |
*s++ = n >> 16;
|
|
|
e09bf5 |
*s++ = n >> 8;
|
|
|
e09bf5 |
@@ -761,15 +760,15 @@ _gcry_mpi_print (enum gcry_mpi_format fo
|
|
|
e09bf5 |
if (!n || (*tmp & 0x80))
|
|
|
e09bf5 |
extra = 2;
|
|
|
e09bf5 |
|
|
|
e09bf5 |
- if (buffer && 2*n + extra + negative + 1 > len)
|
|
|
e09bf5 |
- {
|
|
|
e09bf5 |
- xfree(tmp);
|
|
|
e09bf5 |
- return GPG_ERR_TOO_SHORT;
|
|
|
e09bf5 |
- }
|
|
|
e09bf5 |
if (buffer)
|
|
|
e09bf5 |
{
|
|
|
e09bf5 |
unsigned char *s = buffer;
|
|
|
e09bf5 |
|
|
|
e09bf5 |
+ if (2*n + extra + negative + 1 > len)
|
|
|
e09bf5 |
+ {
|
|
|
e09bf5 |
+ xfree(tmp);
|
|
|
e09bf5 |
+ return GPG_ERR_TOO_SHORT;
|
|
|
e09bf5 |
+ }
|
|
|
e09bf5 |
if (negative)
|
|
|
e09bf5 |
*s++ = '-';
|
|
|
e09bf5 |
if (extra)
|