|
 |
7dd5c5 |
From bf1e62e59200b2046680d1d3d1599facc88cfe63 Mon Sep 17 00:00:00 2001
|
|
|
7dd5c5 |
From: Jakub Jelen <jjelen@redhat.com>
|
|
|
7dd5c5 |
Date: Tue, 29 Nov 2022 14:04:59 +0100
|
|
|
7dd5c5 |
Subject: [PATCH] rsa: Prevent usage of long salt in FIPS mode
|
|
|
7dd5c5 |
|
|
|
7dd5c5 |
* cipher/rsa-common.c (_gcry_rsa_pss_encode): Prevent usage of large
|
|
|
7dd5c5 |
salt lengths
|
|
|
7dd5c5 |
(_gcry_rsa_pss_verify): Ditto.
|
|
|
7dd5c5 |
* tests/basic.c (check_pubkey_sign): Check longer salt length fails in
|
|
|
7dd5c5 |
FIPS mode
|
|
|
7dd5c5 |
* tests/t-rsa-pss.c (one_test_sexp): Fix function name in error message
|
|
|
7dd5c5 |
---
|
|
|
7dd5c5 |
cipher/rsa-common.c | 14 ++++++++++++++
|
|
|
7dd5c5 |
tests/basic.c | 19 ++++++++++++++++++-
|
|
|
7dd5c5 |
tests/t-rsa-pss.c | 2 +-
|
|
|
7dd5c5 |
3 files changed, 33 insertions(+), 2 deletions(-)
|
|
|
7dd5c5 |
|
|
|
7dd5c5 |
diff --git a/cipher/rsa-common.c b/cipher/rsa-common.c
|
|
|
7dd5c5 |
index 233ddb2d..61cd60a4 100644
|
|
|
7dd5c5 |
--- a/cipher/rsa-common.c
|
|
|
7dd5c5 |
+++ b/cipher/rsa-common.c
|
|
|
7dd5c5 |
@@ -809,6 +809,13 @@ _gcry_rsa_pss_encode (gcry_mpi_t *r_result, unsigned int nbits, int algo,
|
|
|
7dd5c5 |
hlen = _gcry_md_get_algo_dlen (algo);
|
|
|
7dd5c5 |
gcry_assert (hlen); /* We expect a valid ALGO here. */
|
|
|
7dd5c5 |
|
|
|
7dd5c5 |
+ /* The FIPS 186-4 Section 5.5 allows only 0 <= sLen <= hLen */
|
|
|
7dd5c5 |
+ if (fips_mode () && saltlen > hlen)
|
|
|
7dd5c5 |
+ {
|
|
|
7dd5c5 |
+ rc = GPG_ERR_INV_ARG;
|
|
|
7dd5c5 |
+ goto leave;
|
|
|
7dd5c5 |
+ }
|
|
|
7dd5c5 |
+
|
|
|
7dd5c5 |
/* Allocate a help buffer and setup some pointers. */
|
|
|
7dd5c5 |
buflen = 8 + hlen + saltlen + (emlen - hlen - 1);
|
|
|
7dd5c5 |
buf = xtrymalloc (buflen);
|
|
|
7dd5c5 |
@@ -950,6 +957,13 @@ _gcry_rsa_pss_verify (gcry_mpi_t value, int hashed_already,
|
|
|
7dd5c5 |
hlen = _gcry_md_get_algo_dlen (algo);
|
|
|
7dd5c5 |
gcry_assert (hlen); /* We expect a valid ALGO here. */
|
|
|
7dd5c5 |
|
|
|
7dd5c5 |
+ /* The FIPS 186-4 Section 5.5 allows only 0 <= sLen <= hLen */
|
|
|
7dd5c5 |
+ if (fips_mode () && saltlen > hlen)
|
|
|
7dd5c5 |
+ {
|
|
|
7dd5c5 |
+ rc = GPG_ERR_INV_ARG;
|
|
|
7dd5c5 |
+ goto leave;
|
|
|
7dd5c5 |
+ }
|
|
|
7dd5c5 |
+
|
|
|
7dd5c5 |
/* Allocate a help buffer and setup some pointers.
|
|
|
7dd5c5 |
This buffer is used for two purposes:
|
|
|
7dd5c5 |
+------------------------------+-------+
|
|
|
7dd5c5 |
diff --git a/tests/basic.c b/tests/basic.c
|
|
|
7dd5c5 |
index 77e2fd93..429bd237 100644
|
|
|
7dd5c5 |
--- a/tests/basic.c
|
|
|
7dd5c5 |
+++ b/tests/basic.c
|
|
|
7dd5c5 |
@@ -16602,6 +16602,7 @@ check_pubkey_sign (int n, gcry_sexp_t skey, gcry_sexp_t pkey, int algo,
|
|
|
7dd5c5 |
const char *data;
|
|
|
7dd5c5 |
int algo;
|
|
|
7dd5c5 |
int expected_rc;
|
|
|
7dd5c5 |
+ int flags;
|
|
|
7dd5c5 |
} datas[] =
|
|
|
7dd5c5 |
{
|
|
|
7dd5c5 |
{ "(data\n (flags pkcs1)\n"
|
|
|
7dd5c5 |
@@ -16672,6 +16673,22 @@ check_pubkey_sign (int n, gcry_sexp_t skey, gcry_sexp_t pkey, int algo,
|
|
|
7dd5c5 |
" (random-override #4253647587980912233445566778899019283747#))\n",
|
|
|
7dd5c5 |
GCRY_PK_RSA,
|
|
|
7dd5c5 |
0 },
|
|
|
7dd5c5 |
+ { "(data\n (flags pss)\n"
|
|
|
7dd5c5 |
+ " (hash-algo sha256)\n"
|
|
|
7dd5c5 |
+ " (value #11223344556677889900AABBCCDDEEFF#)\n"
|
|
|
7dd5c5 |
+ " (salt-length 2:32)\n"
|
|
|
7dd5c5 |
+ " (random-override #42536475879809122334455667788990192837465564738291"
|
|
|
7dd5c5 |
+ "00122334455667#))\n",
|
|
|
7dd5c5 |
+ GCRY_PK_RSA,
|
|
|
7dd5c5 |
+ 0 },
|
|
|
7dd5c5 |
+ { "(data\n (flags pss)\n"
|
|
|
7dd5c5 |
+ " (hash-algo sha256)\n"
|
|
|
7dd5c5 |
+ " (value #11223344556677889900AABBCCDDEEFF#)\n"
|
|
|
7dd5c5 |
+ " (salt-length 2:33)\n"
|
|
|
7dd5c5 |
+ " (random-override #42536475879809122334455667788990192837465564738291"
|
|
|
7dd5c5 |
+ "0012233445566778#))\n",
|
|
|
7dd5c5 |
+ GCRY_PK_RSA,
|
|
|
7dd5c5 |
+ 0, FLAG_NOFIPS },
|
|
|
7dd5c5 |
{ NULL }
|
|
|
7dd5c5 |
};
|
|
|
7dd5c5 |
|
|
|
7dd5c5 |
@@ -16695,7 +16712,7 @@ check_pubkey_sign (int n, gcry_sexp_t skey, gcry_sexp_t pkey, int algo,
|
|
|
7dd5c5 |
die ("converting data failed: %s\n", gpg_strerror (rc));
|
|
|
7dd5c5 |
|
|
|
7dd5c5 |
rc = gcry_pk_sign (&sig, hash, skey);
|
|
|
7dd5c5 |
- if (in_fips_mode && (flags & FLAG_NOFIPS))
|
|
|
7dd5c5 |
+ if (in_fips_mode && (flags & FLAG_NOFIPS || datas[dataidx].flags & FLAG_NOFIPS))
|
|
|
7dd5c5 |
{
|
|
|
7dd5c5 |
if (!rc)
|
|
|
7dd5c5 |
fail ("gcry_pk_sign did not fail as expected in FIPS mode\n");
|
|
|
7dd5c5 |
diff --git a/tests/t-rsa-pss.c b/tests/t-rsa-pss.c
|
|
|
7dd5c5 |
index c5f90116..82dd54b3 100644
|
|
|
7dd5c5 |
--- a/tests/t-rsa-pss.c
|
|
|
7dd5c5 |
+++ b/tests/t-rsa-pss.c
|
|
|
7dd5c5 |
@@ -340,7 +340,7 @@ one_test_sexp (const char *n, const char *e, const char *d,
|
|
|
7dd5c5 |
snprintf (p, 3, "%02x", out[i]);
|
|
|
7dd5c5 |
if (strcmp (sig_string, s))
|
|
|
7dd5c5 |
{
|
|
|
7dd5c5 |
- fail ("gcry_pkhash_sign failed: %s",
|
|
|
7dd5c5 |
+ fail ("gcry_pk_hash_sign failed: %s",
|
|
|
7dd5c5 |
"wrong value returned");
|
|
|
7dd5c5 |
info (" expected: '%s'", s);
|
|
|
7dd5c5 |
info (" got: '%s'", sig_string);
|
|
|
7dd5c5 |
--
|
|
|
7dd5c5 |
2.39.0
|
|
|
7dd5c5 |
|