|
 |
008921 |
commit 4568188d77815697419c8d0b2c55bcbba7f65929
|
|
|
008921 |
Author: Pete Zaitcev <zaitcev@kotori.zaitcev.us>
|
|
|
008921 |
Date: Wed Feb 5 23:26:31 2020 -0600
|
|
|
008921 |
|
|
|
008921 |
Do not discard a technical return value in tests
|
|
|
008921 |
|
|
|
008921 |
Compilers are getting smarter, and we started getting this:
|
|
|
008921 |
|
|
|
008921 |
libec_slap.c: In function 'test_hd_code':
|
|
|
008921 |
libec_slap.c:285:14: error: 'frags.array' may be used uninitialized
|
|
|
008921 |
in this function [-Werror=maybe-uninitialized]
|
|
|
008921 |
|
|
|
008921 |
The fix is to consume the error code in such a way that the
|
|
|
008921 |
test proceeds further only when frags are indeed initialized.
|
|
|
008921 |
|
|
|
008921 |
Change-Id: I54db0172a36419206d00b22608523a08818f41f6
|
|
|
008921 |
|
|
|
008921 |
diff --git a/test/libec_slap.c b/test/libec_slap.c
|
|
|
008921 |
index 78d34a2..5d029ea 100644
|
|
|
008921 |
--- a/test/libec_slap.c
|
|
|
008921 |
+++ b/test/libec_slap.c
|
|
|
008921 |
@@ -280,8 +280,12 @@ static int test_hd_code(struct ec_args *args,
|
|
|
008921 |
}
|
|
|
008921 |
j++;
|
|
|
008921 |
}
|
|
|
008921 |
- create_frags_array_set(&frags,encoded_data, args->k, encoded_parity,
|
|
|
008921 |
- args->m, mask);
|
|
|
008921 |
+ rc = create_frags_array_set(&frags, encoded_data, args->k,
|
|
|
008921 |
+ encoded_parity, args->m, mask);
|
|
|
008921 |
+ if (rc) {
|
|
|
008921 |
+ fprintf(stderr, "No core\n");
|
|
|
008921 |
+ exit(2);
|
|
|
008921 |
+ }
|
|
|
008921 |
rc = liberasurecode_decode(desc, frags.array, frags.num_fragments,
|
|
|
008921 |
encoded_fragment_len, 1,
|
|
|
008921 |
&out_data, &out_data_len);
|
|
|
008921 |
@@ -305,8 +309,12 @@ static int test_hd_code(struct ec_args *args,
|
|
|
008921 |
mi = mi + 1 % (args->k + args->m);
|
|
|
008921 |
mask = add_item_to_missing_mask(mask, mi);
|
|
|
008921 |
}
|
|
|
008921 |
- create_frags_array_set(&frags,encoded_data, args->k, encoded_parity,
|
|
|
008921 |
- args->m, mask);
|
|
|
008921 |
+ rc = create_frags_array_set(&frags, encoded_data, args->k,
|
|
|
008921 |
+ encoded_parity, args->m, mask);
|
|
|
008921 |
+ if (rc) {
|
|
|
008921 |
+ fprintf(stderr, "No core\n");
|
|
|
008921 |
+ exit(2);
|
|
|
008921 |
+ }
|
|
|
008921 |
rc = liberasurecode_decode(desc, frags.array, frags.num_fragments,
|
|
|
008921 |
encoded_fragment_len, 1,
|
|
|
008921 |
&out_data, &out_data_len);
|