|
 |
b7a013 |
From 7a0e344d0642f76992c943158621d8ee7e5caea3 Mon Sep 17 00:00:00 2001
|
|
|
b7a013 |
From: Vojtech Trefny <vtrefny@redhat.com>
|
|
|
b7a013 |
Date: Tue, 15 Nov 2022 13:21:25 +0100
|
|
|
b7a013 |
Subject: [PATCH 1/2] crypto: Fix GError overwrite from libvolume_key
|
|
|
b7a013 |
|
|
|
b7a013 |
---
|
|
|
b7a013 |
src/plugins/crypto.c | 7 ++++---
|
|
|
b7a013 |
1 file changed, 4 insertions(+), 3 deletions(-)
|
|
|
b7a013 |
|
|
|
b7a013 |
diff --git a/src/plugins/crypto.c b/src/plugins/crypto.c
|
|
|
b7a013 |
index 35c38410..9064c8e3 100644
|
|
|
b7a013 |
--- a/src/plugins/crypto.c
|
|
|
b7a013 |
+++ b/src/plugins/crypto.c
|
|
|
b7a013 |
@@ -2552,13 +2552,14 @@ static gboolean write_escrow_data_file (struct libvk_volume *volume, struct libv
|
|
|
b7a013 |
GIOChannel *out_file = NULL;
|
|
|
b7a013 |
GIOStatus status = G_IO_STATUS_ERROR;
|
|
|
b7a013 |
gsize bytes_written = 0;
|
|
|
b7a013 |
+ GError *l_error = NULL;
|
|
|
b7a013 |
|
|
|
b7a013 |
packet_data = libvk_volume_create_packet_asymmetric_with_format (volume, &packet_data_size, secret_type, cert,
|
|
|
b7a013 |
- ui, LIBVK_PACKET_FORMAT_ASYMMETRIC_WRAP_SECRET_ONLY, error);
|
|
|
b7a013 |
-
|
|
|
b7a013 |
+ ui, LIBVK_PACKET_FORMAT_ASYMMETRIC_WRAP_SECRET_ONLY, &l_error);
|
|
|
b7a013 |
if (!packet_data) {
|
|
|
b7a013 |
g_set_error (error, BD_CRYPTO_ERROR, BD_CRYPTO_ERROR_ESCROW_FAILED,
|
|
|
b7a013 |
- "Failed to get escrow data");
|
|
|
b7a013 |
+ "Failed to get escrow data: %s", l_error->message);
|
|
|
b7a013 |
+ g_clear_error (&l_error);
|
|
|
b7a013 |
libvk_volume_free (volume);
|
|
|
b7a013 |
return FALSE;
|
|
|
b7a013 |
}
|
|
|
b7a013 |
--
|
|
|
b7a013 |
2.38.1
|
|
|
b7a013 |
|
|
|
b7a013 |
|
|
|
b7a013 |
From 25bf34c4c03e37eb3782dfccf459b9a3f795ddb3 Mon Sep 17 00:00:00 2001
|
|
|
b7a013 |
From: Vojtech Trefny <vtrefny@redhat.com>
|
|
|
b7a013 |
Date: Wed, 16 Nov 2022 10:26:06 +0100
|
|
|
b7a013 |
Subject: [PATCH 2/2] crypto: Fix double free in write_escrow_data_file
|
|
|
b7a013 |
|
|
|
b7a013 |
---
|
|
|
b7a013 |
src/plugins/crypto.c | 1 -
|
|
|
b7a013 |
1 file changed, 1 deletion(-)
|
|
|
b7a013 |
|
|
|
b7a013 |
diff --git a/src/plugins/crypto.c b/src/plugins/crypto.c
|
|
|
b7a013 |
index 9064c8e3..2086209e 100644
|
|
|
b7a013 |
--- a/src/plugins/crypto.c
|
|
|
b7a013 |
+++ b/src/plugins/crypto.c
|
|
|
b7a013 |
@@ -2560,7 +2560,6 @@ static gboolean write_escrow_data_file (struct libvk_volume *volume, struct libv
|
|
|
b7a013 |
g_set_error (error, BD_CRYPTO_ERROR, BD_CRYPTO_ERROR_ESCROW_FAILED,
|
|
|
b7a013 |
"Failed to get escrow data: %s", l_error->message);
|
|
|
b7a013 |
g_clear_error (&l_error);
|
|
|
b7a013 |
- libvk_volume_free (volume);
|
|
|
b7a013 |
return FALSE;
|
|
|
b7a013 |
}
|
|
|
b7a013 |
|
|
|
b7a013 |
--
|
|
|
b7a013 |
2.38.1
|
|
|
b7a013 |
|