|
 |
56e3f4 |
From a76d23ad6ef2bf7e7f7f1718d74e799ca7e64c77 Mon Sep 17 00:00:00 2001
|
|
|
56e3f4 |
From: =?UTF-8?q?=C3=8D=C3=B1igo=20Huguet?= <ihuguet@redhat.com>
|
|
|
56e3f4 |
Date: Fri, 21 Jan 2022 08:49:05 +0100
|
|
|
56e3f4 |
Subject: [PATCH 36/36] rtw89: fix maybe-uninitialized error
|
|
|
56e3f4 |
MIME-Version: 1.0
|
|
|
56e3f4 |
Content-Type: text/plain; charset=UTF-8
|
|
|
56e3f4 |
Content-Transfer-Encoding: 8bit
|
|
|
56e3f4 |
|
|
|
56e3f4 |
Bugzilla: http://bugzilla.redhat.com/2033291
|
|
|
56e3f4 |
Upstream-status: Posted https://patchwork.kernel.org/project/linux-wireless/patch/20220113094253.73370-1-ihuguet@redhat.com/
|
|
|
56e3f4 |
|
|
|
56e3f4 |
Author: Íñigo Huguet <ihuguet@redhat.com>
|
|
|
56e3f4 |
|
|
|
56e3f4 |
rtw89: fix maybe-uninitialized error
|
|
|
56e3f4 |
|
|
|
56e3f4 |
Call to dle_dfi_qempty might fail, leaving qempty.qempty untouched, which
|
|
|
56e3f4 |
is latter used to control the for loop. If that happens, it's not
|
|
|
56e3f4 |
initialized anywhere.
|
|
|
56e3f4 |
|
|
|
56e3f4 |
Initialize it so the loop doesn't iterate unless it's modified by the
|
|
|
56e3f4 |
call to dle_dfi_qempty.
|
|
|
56e3f4 |
|
|
|
56e3f4 |
Signed-off-by: Íñigo Huguet <ihuguet@redhat.com>
|
|
|
56e3f4 |
|
|
|
56e3f4 |
Signed-off-by: Íñigo Huguet <ihuguet@redhat.com>
|
|
|
56e3f4 |
---
|
|
|
56e3f4 |
drivers/net/wireless/realtek/rtw89/mac.c | 1 +
|
|
|
56e3f4 |
1 file changed, 1 insertion(+)
|
|
|
56e3f4 |
|
|
|
56e3f4 |
diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c
|
|
|
56e3f4 |
index b98c47e9ecfe..7c3e547006cd 100644
|
|
|
56e3f4 |
--- a/drivers/net/wireless/realtek/rtw89/mac.c
|
|
|
56e3f4 |
+++ b/drivers/net/wireless/realtek/rtw89/mac.c
|
|
|
56e3f4 |
@@ -172,6 +172,7 @@ static void rtw89_mac_dump_qta_lost(struct rtw89_dev *rtwdev)
|
|
|
56e3f4 |
|
|
|
56e3f4 |
qempty.dle_type = DLE_CTRL_TYPE_PLE;
|
|
|
56e3f4 |
qempty.grpsel = 0;
|
|
|
56e3f4 |
+ qempty.qempty = ~(u32)0;
|
|
|
56e3f4 |
ret = dle_dfi_qempty(rtwdev, &qempty);
|
|
|
56e3f4 |
if (ret)
|
|
|
56e3f4 |
rtw89_warn(rtwdev, "%s: query DLE fail\n", __func__);
|
|
|
56e3f4 |
--
|
|
|
56e3f4 |
2.13.6
|
|
|
56e3f4 |
|