From 8241fffae7c8bab5cec5fc8bcaceccd03079e3aa Mon Sep 17 00:00:00 2001

From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>

Date: Tue, 28 Sep 2021 20:04:10 +0300

Subject: [Backport 8241fffae7c8] src: Forbid FALLOC_FL_PUNCH_HOLE for

 normal files

FALLOC_FL_PUNCH_HOLE isn't allowed with normal files.

Filesystem must remember info about hole, but for normal file

we can only zero it and forget.

Fixes: 4342306f0f0d ("src: Add file operations and implementation")

Now xfstests generic/016 generic/021 generic/022 pass.

Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>

---

 src/file.c | 7 +++++--

 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/file.c b/src/file.c

index 5fb3508e5422cc6654381897d6fdb4a204a543a4..43b1451bff539576cd03c0f624708bf65b959270 100644

--- a/src/file.c

+++ b/src/file.c

@@ -587,8 +587,11 @@ static long ntfs_fallocate(struct file *file, int mode, loff_t vbo, loff_t len)

 		truncate_pagecache(inode, vbo_down);

 		if (!is_sparsed(ni) && !is_compressed(ni)) {

-			/* Normal file. */

-			err = ntfs_zero_range(inode, vbo, end);

+			/*

+			 * Normal file, can't make hole.

+			 * TODO: Try to find way to save info about hole.

+			 */

+			err = -EOPNOTSUPP;

 			goto out;

 		}

-- 

2.31.1