From f239b3a95dd4f7daba26ea17f339a5b19a7d40a1 Mon Sep 17 00:00:00 2001

From: Kari Argillander <kari.argillander@gmail.com>

Date: Thu, 2 Sep 2021 19:15:23 +0300

Subject: [Backport f239b3a95dd4] src: Add missing headers and forward

 declarations to ntfs_fs.h

We do not have headers at all in this file. We should have them so that

not every .c file needs to include all of the stuff which this file need

for building. This way we can remove some headers from other files and

get better picture what is needed. This can save some compilation time.

And this can help if we sometimes want to separate this one big header.

Also use forward declarations for structs and enums when it not included

straight with include and it is used in function declarations input.

This will prevent possible compiler warning:

  xxx declared inside parameter list will not be visible

  outside of this definition or declaration

Here is list which I made when parsing this. There is not necessarily

all example from this header file, but this just proofs we need it.

<linux/blkdev.h> SECTOR_SHIFT

<linux/buffer_head.h> sb_bread(), put_bh

<linux/cleancache.h> put_page()

<linux/fs.h> struct inode (Just struct ntfs_inode need it)

<linux/highmem.h> kunmap(), kmap()

<linux/kernel.h> cpu_to_leXX() ALIGN

<linux/mm.h> kvfree()

<linux/mutex.h> struct mutex, mutex_(un/try)lock()

<linux/page-flags.h> PageError()

<linux/pagemap.h> read_mapping_page()

<linux/rbtree.h> struct rb_root

<linux/rwsem.h> struct rw_semaphore

<linux/slab.h> krfree(), kzalloc()

<linux/string.h> memset()

<linux/time64.h> struct timespec64

<linux/types.h> uXX, __leXX

<linux/uidgid.h> kuid_t, kgid_t

<asm/div64.h> do_div()

<asm/page.h> PAGE_SIZE

"debug.h" ntfs_err() (Just one entry. Maybe we can drop this)

"ntfs.h" Do you even ask?

Signed-off-by: Kari Argillander <kari.argillander@gmail.com>

Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>

---

 src/ntfs_fs.h | 31 +++++++++++++++++++++++++++++++

 1 file changed, 31 insertions(+)

diff --git a/src/ntfs_fs.h b/src/ntfs_fs.h

index 372cda697dd4c587a82ed6381a1dd512b700d5c1..dae6dd4ac6198fe735749b8e1405e110da4ddd62 100644

--- a/src/ntfs_fs.h

+++ b/src/ntfs_fs.h

@@ -9,6 +9,37 @@

 #ifndef _LINUX_NTFS3_NTFS_FS_H

 #define _LINUX_NTFS3_NTFS_FS_H

+#include <linux/blkdev.h>

+#include <linux/buffer_head.h>

+#include <linux/cleancache.h>

+#include <linux/fs.h>

+#include <linux/highmem.h>

+#include <linux/kernel.h>

+#include <linux/mm.h>

+#include <linux/mutex.h>

+#include <linux/page-flags.h>

+#include <linux/pagemap.h>

+#include <linux/rbtree.h>

+#include <linux/rwsem.h>

+#include <linux/slab.h>

+#include <linux/string.h>

+#include <linux/time64.h>

+#include <linux/types.h>

+#include <linux/uidgid.h>

+#include <asm/div64.h>

+#include <asm/page.h>

+

+#include "debug.h"

+#include "ntfs.h"

+

+struct dentry;

+struct fiemap_extent_info;

+struct user_namespace;

+struct page;

+struct writeback_control;

+enum utf16_endian;

+

+

 #define MINUS_ONE_T			((size_t)(-1))

 /* Biggest MFT / smallest cluster */

 #define MAXIMUM_BYTES_PER_MFT		4096

-- 

2.31.1