From 2926e4297053c735ab65450192dfba32a4f47fa9 Mon Sep 17 00:00:00 2001

From: Dan Carpenter <dan.carpenter@oracle.com>

Date: Tue, 24 Aug 2021 14:48:58 +0300

Subject: [Backport 2926e4297053] src: fix an error code in

 ntfs_get_acl_ex()

The ntfs_get_ea() function returns negative error codes or on success

it returns the length.  In the original code a zero length return was

treated as -ENODATA and results in a NULL return.  But it should be

treated as an invalid length and result in an PTR_ERR(-EINVAL) return.

Fixes: be71b5cba2e6 ("src: Add attrib operations")

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>

---

 src/xattr.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/xattr.c b/src/xattr.c

index af89e50f7b9f32926e4daaea9f8b729916519526..d3d5b9d331d1f55010843085738cf395b640eb0b 100644

--- a/src/xattr.c

+++ b/src/xattr.c

@@ -521,7 +521,7 @@ static struct posix_acl *ntfs_get_acl_ex(struct user_namespace *mnt_userns,

 		ni_unlock(ni);

 	/* Translate extended attribute to acl */

-	if (err > 0) {

+	if (err >= 0) {

 		acl = posix_acl_from_xattr(mnt_userns, buf, err);

 		if (!IS_ERR(acl))

 			set_cached_acl(inode, type, acl);

-- 

2.31.1