From 035779483072ff7854943dc0cbae82c4e0070d15 Mon Sep 17 00:00:00 2001

From: Eric Sandeen <sandeen@sandeen.net>

Date: Fri, 1 May 2020 20:34:25 -0500

Subject: [Backport 035779483072] exfat: use iter_file_splice_write

Doing copy_file_range() on exfat with a file opened for direct IO leads

to an -EFAULT:

# xfs_io -f -d -c "truncate 32768" \

       -c "copy_range -d 16384 -l 16384 -f 0" /mnt/test/junk

copy_range: Bad address

and the reason seems to be that we go through:

default_file_splice_write

 splice_from_pipe

  __splice_from_pipe

   write_pipe_buf

    __kernel_write

     new_sync_write

      generic_file_write_iter

       generic_file_direct_write

        exfat_direct_IO

         do_blockdev_direct_IO

          iov_iter_get_pages

and land in iterate_all_kinds(), which does "return -EFAULT" for our kvec

iter.

Setting exfat's splice_write to iter_file_splice_write fixes this and lets

fsx (which originally detected the problem) run to success from

the xfstests harness.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>

Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>

---

 src/file.c | 13 +++++++------

 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/file.c b/src/file.c

index 4f76764165cf6f63a99c5e192ab33685e8e987b7..c9db8eb0cfc3ee267d5e3b051974ceae8de861b5 100644

--- a/src/file.c

+++ b/src/file.c

@@ -348,12 +348,13 @@ int exfat_setattr(struct dentry *dentry, struct iattr *attr)

 }

 const struct file_operations exfat_file_operations = {

-	.llseek      = generic_file_llseek,

-	.read_iter   = generic_file_read_iter,

-	.write_iter  = generic_file_write_iter,

-	.mmap        = generic_file_mmap,

-	.fsync       = generic_file_fsync,

-	.splice_read = generic_file_splice_read,

+	.llseek		= generic_file_llseek,

+	.read_iter	= generic_file_read_iter,

+	.write_iter	= generic_file_write_iter,

+	.mmap		= generic_file_mmap,

+	.fsync		= generic_file_fsync,

+	.splice_read	= generic_file_splice_read,

+	.splice_write	= iter_file_splice_write,

 };

 const struct inode_operations exfat_file_inode_operations = {

-- 

2.31.1