Blame SOURCES/rh1860986-disable_tlsv1.3_in_fips_mode.patch

d1af5a
diff --git openjdk/src/java.base/share/classes/java/security/SystemConfigurator.java openjdk/src/java.base/share/classes/java/security/SystemConfigurator.java
d1af5a
index f9baf8c9742..60fa75cab45 100644
d1af5a
--- openjdk/src/java.base/share/classes/java/security/SystemConfigurator.java
d1af5a
+++ openjdk/src/java.base/share/classes/java/security/SystemConfigurator.java
d1af5a
@@ -1,11 +1,13 @@
d1af5a
 /*
d1af5a
- * Copyright (c) 2019, Red Hat, Inc.
d1af5a
+ * Copyright (c) 2019, 2020, Red Hat, Inc.
d1af5a
  *
d1af5a
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
d1af5a
  *
d1af5a
  * This code is free software; you can redistribute it and/or modify it
d1af5a
  * under the terms of the GNU General Public License version 2 only, as
d1af5a
- * published by the Free Software Foundation.
d1af5a
+ * published by the Free Software Foundation.  Oracle designates this
d1af5a
+ * particular file as subject to the "Classpath" exception as provided
d1af5a
+ * by Oracle in the LICENSE file that accompanied this code.
d1af5a
  *
d1af5a
  * This code is distributed in the hope that it will be useful, but WITHOUT
d1af5a
  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
d1af5a
@@ -34,10 +36,10 @@ import java.nio.file.Path;
d1af5a
 import java.util.Iterator;
d1af5a
 import java.util.Map.Entry;
d1af5a
 import java.util.Properties;
d1af5a
-import java.util.function.Consumer;
d1af5a
-import java.util.regex.Matcher;
d1af5a
 import java.util.regex.Pattern;
d1af5a
 
d1af5a
+import jdk.internal.access.JavaSecuritySystemConfiguratorAccess;
d1af5a
+import jdk.internal.access.SharedSecrets;
d1af5a
 import sun.security.util.Debug;
d1af5a
 
d1af5a
 /**
d1af5a
@@ -47,7 +49,7 @@ import sun.security.util.Debug;
d1af5a
  *
d1af5a
  */
d1af5a
 
d1af5a
-class SystemConfigurator {
d1af5a
+final class SystemConfigurator {
d1af5a
 
d1af5a
     private static final Debug sdebug =
d1af5a
             Debug.getInstance("properties");
d1af5a
@@ -61,15 +63,16 @@ class SystemConfigurator {
d1af5a
     private static final String CRYPTO_POLICIES_CONFIG =
d1af5a
             CRYPTO_POLICIES_BASE_DIR + "/config";
d1af5a
 
d1af5a
-    private static final class SecurityProviderInfo {
d1af5a
-        int number;
d1af5a
-        String key;
d1af5a
-        String value;
d1af5a
-        SecurityProviderInfo(int number, String key, String value) {
d1af5a
-            this.number = number;
d1af5a
-            this.key = key;
d1af5a
-            this.value = value;
d1af5a
-        }
d1af5a
+    private static boolean systemFipsEnabled = false;
d1af5a
+
d1af5a
+    static {
d1af5a
+        SharedSecrets.setJavaSecuritySystemConfiguratorAccess(
d1af5a
+            new JavaSecuritySystemConfiguratorAccess() {
d1af5a
+                @Override
d1af5a
+                public boolean isSystemFipsEnabled() {
d1af5a
+                    return SystemConfigurator.isSystemFipsEnabled();
d1af5a
+                }
d1af5a
+            });
d1af5a
     }
d1af5a
 
d1af5a
     /*
d1af5a
@@ -128,9 +131,9 @@ class SystemConfigurator {
d1af5a
                     String nonFipsKeystoreType = props.getProperty("keystore.type");
d1af5a
                     props.put("keystore.type", keystoreTypeValue);
d1af5a
                     if (keystoreTypeValue.equals("PKCS11")) {
d1af5a
-                    	// If keystore.type is PKCS11, javax.net.ssl.keyStore
d1af5a
-                    	// must be "NONE". See JDK-8238264.
d1af5a
-                    	System.setProperty("javax.net.ssl.keyStore", "NONE");
d1af5a
+                        // If keystore.type is PKCS11, javax.net.ssl.keyStore
d1af5a
+                        // must be "NONE". See JDK-8238264.
d1af5a
+                        System.setProperty("javax.net.ssl.keyStore", "NONE");
d1af5a
                     }
d1af5a
                     if (System.getProperty("javax.net.ssl.trustStoreType") == null) {
d1af5a
                         // If no trustStoreType has been set, use the
d1af5a
@@ -144,12 +147,13 @@ class SystemConfigurator {
d1af5a
                         sdebug.println("FIPS mode default keystore.type = " +
d1af5a
                                 keystoreTypeValue);
d1af5a
                         sdebug.println("FIPS mode javax.net.ssl.keyStore = " +
d1af5a
-                        		System.getProperty("javax.net.ssl.keyStore", ""));
d1af5a
+                                System.getProperty("javax.net.ssl.keyStore", ""));
d1af5a
                         sdebug.println("FIPS mode javax.net.ssl.trustStoreType = " +
d1af5a
                                 System.getProperty("javax.net.ssl.trustStoreType", ""));
d1af5a
                     }
d1af5a
                 }
d1af5a
                 loadedProps = true;
d1af5a
+                systemFipsEnabled = true;
d1af5a
             }
d1af5a
         } catch (Exception e) {
d1af5a
             if (sdebug != null) {
d1af5a
@@ -160,13 +164,30 @@ class SystemConfigurator {
d1af5a
         return loadedProps;
d1af5a
     }
d1af5a
 
d1af5a
+    /**
d1af5a
+     * Returns whether or not global system FIPS alignment is enabled.
d1af5a
+     *
d1af5a
+     * Value is always 'false' before java.security.Security class is
d1af5a
+     * initialized.
d1af5a
+     *
d1af5a
+     * Call from out of this package through SharedSecrets:
d1af5a
+     *   SharedSecrets.getJavaSecuritySystemConfiguratorAccess()
d1af5a
+     *           .isSystemFipsEnabled();
d1af5a
+     *
d1af5a
+     * @return  a boolean value indicating whether or not global
d1af5a
+     *          system FIPS alignment is enabled.
d1af5a
+     */
d1af5a
+    static boolean isSystemFipsEnabled() {
d1af5a
+        return systemFipsEnabled;
d1af5a
+    }
d1af5a
+
d1af5a
     /*
d1af5a
      * FIPS is enabled only if crypto-policies are set to "FIPS"
d1af5a
      * and the com.redhat.fips property is true.
d1af5a
      */
d1af5a
     private static boolean enableFips() throws Exception {
d1af5a
-        boolean fipsEnabled = Boolean.valueOf(System.getProperty("com.redhat.fips", "true"));
d1af5a
-        if (fipsEnabled) {
d1af5a
+        boolean shouldEnable = Boolean.valueOf(System.getProperty("com.redhat.fips", "true"));
d1af5a
+        if (shouldEnable) {
d1af5a
             String cryptoPoliciesConfig = new String(Files.readAllBytes(Path.of(CRYPTO_POLICIES_CONFIG)));
d1af5a
             if (sdebug != null) { sdebug.println("Crypto config:\n" + cryptoPoliciesConfig); }
d1af5a
             Pattern pattern = Pattern.compile("^FIPS$", Pattern.MULTILINE);
d1af5a
diff --git openjdk/src/java.base/share/classes/jdk/internal/access/JavaSecuritySystemConfiguratorAccess.java openjdk/src/java.base/share/classes/jdk/internal/access/JavaSecuritySystemConfiguratorAccess.java
d1af5a
new file mode 100644
d1af5a
index 00000000000..a31e93ec02e
d1af5a
--- /dev/null
d1af5a
+++ openjdk/src/java.base/share/classes/jdk/internal/access/JavaSecuritySystemConfiguratorAccess.java
d1af5a
@@ -0,0 +1,30 @@
d1af5a
+/*
d1af5a
+ * Copyright (c) 2020, Red Hat, Inc.
d1af5a
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
d1af5a
+ *
d1af5a
+ * This code is free software; you can redistribute it and/or modify it
d1af5a
+ * under the terms of the GNU General Public License version 2 only, as
d1af5a
+ * published by the Free Software Foundation.  Oracle designates this
d1af5a
+ * particular file as subject to the "Classpath" exception as provided
d1af5a
+ * by Oracle in the LICENSE file that accompanied this code.
d1af5a
+ *
d1af5a
+ * This code is distributed in the hope that it will be useful, but WITHOUT
d1af5a
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
d1af5a
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
d1af5a
+ * version 2 for more details (a copy is included in the LICENSE file that
d1af5a
+ * accompanied this code).
d1af5a
+ *
d1af5a
+ * You should have received a copy of the GNU General Public License version
d1af5a
+ * 2 along with this work; if not, write to the Free Software Foundation,
d1af5a
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
d1af5a
+ *
d1af5a
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
d1af5a
+ * or visit www.oracle.com if you need additional information or have any
d1af5a
+ * questions.
d1af5a
+ */
d1af5a
+
d1af5a
+package jdk.internal.access;
d1af5a
+
d1af5a
+public interface JavaSecuritySystemConfiguratorAccess {
d1af5a
+    boolean isSystemFipsEnabled();
d1af5a
+}
d1af5a
diff --git openjdk/src/java.base/share/classes/jdk/internal/access/SharedSecrets.java openjdk/src/java.base/share/classes/jdk/internal/access/SharedSecrets.java
d1af5a
index f6d3638c3dd..5a2c9eb0c46 100644
d1af5a
--- openjdk/src/java.base/share/classes/jdk/internal/access/SharedSecrets.java
d1af5a
+++ openjdk/src/java.base/share/classes/jdk/internal/access/SharedSecrets.java
d1af5a
@@ -81,6 +81,7 @@ public class SharedSecrets {
d1af5a
     private static JavaSecuritySpecAccess javaSecuritySpecAccess;
d1af5a
     private static JavaxCryptoSealedObjectAccess javaxCryptoSealedObjectAccess;
d1af5a
     private static JavaxCryptoSpecAccess javaxCryptoSpecAccess;
d1af5a
+    private static JavaSecuritySystemConfiguratorAccess javaSecuritySystemConfiguratorAccess;
d1af5a
 
d1af5a
     public static void setJavaUtilCollectionAccess(JavaUtilCollectionAccess juca) {
d1af5a
         javaUtilCollectionAccess = juca;
d1af5a
@@ -442,4 +443,12 @@ public class SharedSecrets {
d1af5a
             MethodHandles.lookup().ensureInitialized(c);
d1af5a
         } catch (IllegalAccessException e) {}
d1af5a
     }
d1af5a
+
d1af5a
+    public static void setJavaSecuritySystemConfiguratorAccess(JavaSecuritySystemConfiguratorAccess jssca) {
d1af5a
+        javaSecuritySystemConfiguratorAccess = jssca;
d1af5a
+    }
d1af5a
+
d1af5a
+    public static JavaSecuritySystemConfiguratorAccess getJavaSecuritySystemConfiguratorAccess() {
d1af5a
+        return javaSecuritySystemConfiguratorAccess;
d1af5a
+    }
d1af5a
 }
d1af5a
diff --git openjdk/src/java.base/share/classes/sun/security/ssl/SSLContextImpl.java openjdk/src/java.base/share/classes/sun/security/ssl/SSLContextImpl.java
d1af5a
index 6ffdfeda18d..775b185fb06 100644
d1af5a
--- openjdk/src/java.base/share/classes/sun/security/ssl/SSLContextImpl.java
d1af5a
+++ openjdk/src/java.base/share/classes/sun/security/ssl/SSLContextImpl.java
d1af5a
@@ -32,6 +32,7 @@ import java.security.cert.*;
d1af5a
 import java.util.*;
d1af5a
 import java.util.concurrent.locks.ReentrantLock;
d1af5a
 import javax.net.ssl.*;
d1af5a
+import jdk.internal.access.SharedSecrets;
d1af5a
 import sun.security.action.GetPropertyAction;
d1af5a
 import sun.security.provider.certpath.AlgorithmChecker;
d1af5a
 import sun.security.validator.Validator;
d1af5a
@@ -536,22 +537,40 @@ public abstract class SSLContextImpl extends SSLContextSpi {
d1af5a
         private static final List<CipherSuite> serverDefaultCipherSuites;
d1af5a
 
d1af5a
         static {
d1af5a
-            supportedProtocols = Arrays.asList(
d1af5a
-                ProtocolVersion.TLS13,
d1af5a
-                ProtocolVersion.TLS12,
d1af5a
-                ProtocolVersion.TLS11,
d1af5a
-                ProtocolVersion.TLS10,
d1af5a
-                ProtocolVersion.SSL30,
d1af5a
-                ProtocolVersion.SSL20Hello
d1af5a
-            );
d1af5a
-
d1af5a
-            serverDefaultProtocols = getAvailableProtocols(
d1af5a
-                    new ProtocolVersion[] {
d1af5a
-                ProtocolVersion.TLS13,
d1af5a
-                ProtocolVersion.TLS12,
d1af5a
-                ProtocolVersion.TLS11,
d1af5a
-                ProtocolVersion.TLS10
d1af5a
-            });
d1af5a
+            if (SharedSecrets.getJavaSecuritySystemConfiguratorAccess()
d1af5a
+                    .isSystemFipsEnabled()) {
d1af5a
+                // RH1860986: TLSv1.3 key derivation not supported with
d1af5a
+                // the Security Providers available in system FIPS mode.
d1af5a
+                supportedProtocols = Arrays.asList(
d1af5a
+                    ProtocolVersion.TLS12,
d1af5a
+                    ProtocolVersion.TLS11,
d1af5a
+                    ProtocolVersion.TLS10
d1af5a
+                );
d1af5a
+
d1af5a
+                serverDefaultProtocols = getAvailableProtocols(
d1af5a
+                        new ProtocolVersion[] {
d1af5a
+                    ProtocolVersion.TLS12,
d1af5a
+                    ProtocolVersion.TLS11,
d1af5a
+                    ProtocolVersion.TLS10
d1af5a
+                });
d1af5a
+            } else {
d1af5a
+                supportedProtocols = Arrays.asList(
d1af5a
+                    ProtocolVersion.TLS13,
d1af5a
+                    ProtocolVersion.TLS12,
d1af5a
+                    ProtocolVersion.TLS11,
d1af5a
+                    ProtocolVersion.TLS10,
d1af5a
+                    ProtocolVersion.SSL30,
d1af5a
+                    ProtocolVersion.SSL20Hello
d1af5a
+                );
d1af5a
+
d1af5a
+                serverDefaultProtocols = getAvailableProtocols(
d1af5a
+                        new ProtocolVersion[] {
d1af5a
+                    ProtocolVersion.TLS13,
d1af5a
+                    ProtocolVersion.TLS12,
d1af5a
+                    ProtocolVersion.TLS11,
d1af5a
+                    ProtocolVersion.TLS10
d1af5a
+                });
d1af5a
+            }
d1af5a
 
d1af5a
             supportedCipherSuites = getApplicableSupportedCipherSuites(
d1af5a
                     supportedProtocols);
d1af5a
@@ -842,12 +861,23 @@ public abstract class SSLContextImpl extends SSLContextSpi {
d1af5a
             ProtocolVersion[] candidates;
d1af5a
             if (refactored.isEmpty()) {
d1af5a
                 // Client and server use the same default protocols.
d1af5a
-                candidates = new ProtocolVersion[] {
d1af5a
-                        ProtocolVersion.TLS13,
d1af5a
-                        ProtocolVersion.TLS12,
d1af5a
-                        ProtocolVersion.TLS11,
d1af5a
-                        ProtocolVersion.TLS10
d1af5a
-                    };
d1af5a
+                if (SharedSecrets.getJavaSecuritySystemConfiguratorAccess()
d1af5a
+                        .isSystemFipsEnabled()) {
d1af5a
+                    // RH1860986: TLSv1.3 key derivation not supported with
d1af5a
+                    // the Security Providers available in system FIPS mode.
d1af5a
+                    candidates = new ProtocolVersion[] {
d1af5a
+                            ProtocolVersion.TLS12,
d1af5a
+                            ProtocolVersion.TLS11,
d1af5a
+                            ProtocolVersion.TLS10
d1af5a
+                        };
d1af5a
+                } else {
d1af5a
+                    candidates = new ProtocolVersion[] {
d1af5a
+                            ProtocolVersion.TLS13,
d1af5a
+                            ProtocolVersion.TLS12,
d1af5a
+                            ProtocolVersion.TLS11,
d1af5a
+                            ProtocolVersion.TLS10
d1af5a
+                        };
d1af5a
+                }
d1af5a
             } else {
d1af5a
                 // Use the customized TLS protocols.
d1af5a
                 candidates =
d1af5a
diff --git openjdk/src/java.base/share/classes/sun/security/ssl/SunJSSE.java openjdk/src/java.base/share/classes/sun/security/ssl/SunJSSE.java
d1af5a
index 894e26dfad8..8b16378b96b 100644
d1af5a
--- openjdk/src/java.base/share/classes/sun/security/ssl/SunJSSE.java
d1af5a
+++ openjdk/src/java.base/share/classes/sun/security/ssl/SunJSSE.java
d1af5a
@@ -27,6 +27,8 @@ package sun.security.ssl;
d1af5a
 
d1af5a
 import java.security.*;
d1af5a
 import java.util.*;
d1af5a
+
d1af5a
+import jdk.internal.access.SharedSecrets;
d1af5a
 import static sun.security.util.SecurityConstants.PROVIDER_VER;
d1af5a
 
d1af5a
 /**
d1af5a
@@ -102,8 +104,13 @@ public class SunJSSE extends java.security.Provider {
d1af5a
             "sun.security.ssl.SSLContextImpl$TLS11Context", null, null);
d1af5a
         ps("SSLContext", "TLSv1.2",
d1af5a
             "sun.security.ssl.SSLContextImpl$TLS12Context", null, null);
d1af5a
-        ps("SSLContext", "TLSv1.3",
d1af5a
-            "sun.security.ssl.SSLContextImpl$TLS13Context", null, null);
d1af5a
+        if (!SharedSecrets.getJavaSecuritySystemConfiguratorAccess()
d1af5a
+                .isSystemFipsEnabled()) {
d1af5a
+            // RH1860986: TLSv1.3 key derivation not supported with
d1af5a
+            // the Security Providers available in system FIPS mode.
d1af5a
+            ps("SSLContext", "TLSv1.3",
d1af5a
+                "sun.security.ssl.SSLContextImpl$TLS13Context", null, null);
d1af5a
+        }
d1af5a
         ps("SSLContext", "TLS",
d1af5a
             "sun.security.ssl.SSLContextImpl$TLSContext",
d1af5a
             List.of("SSL"), null);