Blame SOURCES/0297-mm-Document-GRUB-internal-memory-management-structur.patch

fd0330
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
fd0330
From: Daniel Axtens <dja@axtens.net>
fd0330
Date: Thu, 25 Nov 2021 02:22:45 +1100
fd0330
Subject: [PATCH] mm: Document GRUB internal memory management structures
fd0330
fd0330
I spent more than a trivial quantity of time figuring out pre_size and
fd0330
whether a memory region's size contains the header cell or not.
fd0330
fd0330
Document the meanings of all the properties. Hopefully now no-one else
fd0330
has to figure it out!
fd0330
fd0330
Signed-off-by: Daniel Axtens <dja@axtens.net>
fd0330
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
fd0330
(cherry picked from commit a6c5c52ccffd2674d43db25fb4baa9c528526aa0)
fd0330
---
fd0330
 include/grub/mm_private.h | 28 ++++++++++++++++++++++++++++
fd0330
 1 file changed, 28 insertions(+)
fd0330
fd0330
diff --git a/include/grub/mm_private.h b/include/grub/mm_private.h
fd0330
index c2c4cb1511..203533cc3d 100644
fd0330
--- a/include/grub/mm_private.h
fd0330
+++ b/include/grub/mm_private.h
fd0330
@@ -21,15 +21,27 @@
fd0330
 
fd0330
 #include <grub/mm.h>
fd0330
 
fd0330
+/* For context, see kern/mm.c */
fd0330
+
fd0330
 /* Magic words.  */
fd0330
 #define GRUB_MM_FREE_MAGIC	0x2d3c2808
fd0330
 #define GRUB_MM_ALLOC_MAGIC	0x6db08fa4
fd0330
 
fd0330
+/* A header describing a block of memory - either allocated or free */
fd0330
 typedef struct grub_mm_header
fd0330
 {
fd0330
+  /*
fd0330
+   * The 'next' free block in this region's circular free list.
fd0330
+   * Only meaningful if the block is free.
fd0330
+   */
fd0330
   struct grub_mm_header *next;
fd0330
+  /* The block size, not in bytes but the number of cells of
fd0330
+   * GRUB_MM_ALIGN bytes. Includes the header cell.
fd0330
+   */
fd0330
   grub_size_t size;
fd0330
+  /* either free or alloc magic, depending on the block type. */
fd0330
   grub_size_t magic;
fd0330
+  /* pad to cell size: see the top of kern/mm.c. */
fd0330
 #if GRUB_CPU_SIZEOF_VOID_P == 4
fd0330
   char padding[4];
fd0330
 #elif GRUB_CPU_SIZEOF_VOID_P == 8
fd0330
@@ -48,11 +60,27 @@ typedef struct grub_mm_header
fd0330
 
fd0330
 #define GRUB_MM_ALIGN	(1 << GRUB_MM_ALIGN_LOG2)
fd0330
 
fd0330
+/* A region from which we can make allocations. */
fd0330
 typedef struct grub_mm_region
fd0330
 {
fd0330
+  /* The first free block in this region. */
fd0330
   struct grub_mm_header *first;
fd0330
+
fd0330
+  /*
fd0330
+   * The next region in the linked list of regions. Regions are initially
fd0330
+   * sorted in order of increasing size, but can grow, in which case the
fd0330
+   * ordering may not be preserved.
fd0330
+   */
fd0330
   struct grub_mm_region *next;
fd0330
+
fd0330
+  /*
fd0330
+   * A grub_mm_region will always be aligned to cell size. The pre-size is
fd0330
+   * the number of bytes we were given but had to skip in order to get that
fd0330
+   * alignment.
fd0330
+   */
fd0330
   grub_size_t pre_size;
fd0330
+
fd0330
+  /* How many bytes are in this region? (free and allocated) */
fd0330
   grub_size_t size;
fd0330
 }
fd0330
 *grub_mm_region_t;