|
 |
903fa7 |
commit 32d72eb22fdf00c759df50e5fce49292d15be5ed
|
|
|
903fa7 |
Author: Andrew Price <anprice@redhat.com>
|
|
|
903fa7 |
Date: Fri Nov 8 16:59:44 2013 +0000
|
|
|
903fa7 |
|
|
|
903fa7 |
fsck.gfs2: Fix block size validation
|
|
|
903fa7 |
|
|
|
903fa7 |
The previous patch had an off-by-one error when looping over
|
|
|
903fa7 |
sdp->sd_heightsize. This fixes that and adds an explicit sanity check
|
|
|
903fa7 |
for sb_bsize. Some new tests are added to cover both valid and invalid
|
|
|
903fa7 |
block size cases.
|
|
|
903fa7 |
|
|
|
903fa7 |
Resolves: bz#1028388
|
|
|
903fa7 |
|
|
|
903fa7 |
Signed-off-by: Andrew Price <anprice@redhat.com>
|
|
|
903fa7 |
|
|
|
903fa7 |
diff --git a/gfs2/libgfs2/super.c b/gfs2/libgfs2/super.c
|
|
|
903fa7 |
index 8ffd144..d074236 100644
|
|
|
903fa7 |
--- a/gfs2/libgfs2/super.c
|
|
|
903fa7 |
+++ b/gfs2/libgfs2/super.c
|
|
|
903fa7 |
@@ -67,6 +67,9 @@ int read_sb(struct gfs2_sbd *sdp)
|
|
|
903fa7 |
sdp->gfs1 = 1;
|
|
|
903fa7 |
sdp->sd_fsb2bb_shift = sdp->sd_sb.sb_bsize_shift - GFS2_BASIC_BLOCK_SHIFT;
|
|
|
903fa7 |
sdp->bsize = sdp->sd_sb.sb_bsize;
|
|
|
903fa7 |
+ if (sdp->bsize < 512 || sdp->bsize != (sdp->bsize & -sdp->bsize)) {
|
|
|
903fa7 |
+ return -1;
|
|
|
903fa7 |
+ }
|
|
|
903fa7 |
if (sdp->gfs1) {
|
|
|
903fa7 |
sdp->sd_diptrs = (sdp->sd_sb.sb_bsize -
|
|
|
903fa7 |
sizeof(struct gfs_dinode)) /
|
|
|
903fa7 |
@@ -88,7 +91,7 @@ int read_sb(struct gfs2_sbd *sdp)
|
|
|
903fa7 |
sdp->sd_hash_ptrs = sdp->sd_hash_bsize / sizeof(uint64_t);
|
|
|
903fa7 |
sdp->sd_heightsize[0] = sdp->sd_sb.sb_bsize - sizeof(struct gfs2_dinode);
|
|
|
903fa7 |
sdp->sd_heightsize[1] = sdp->sd_sb.sb_bsize * sdp->sd_diptrs;
|
|
|
903fa7 |
- for (x = 2; x <= GFS2_MAX_META_HEIGHT; x++){
|
|
|
903fa7 |
+ for (x = 2; x < GFS2_MAX_META_HEIGHT; x++){
|
|
|
903fa7 |
space = sdp->sd_heightsize[x - 1] * sdp->sd_inptrs;
|
|
|
903fa7 |
/* FIXME: Do we really need this first check?? */
|
|
|
903fa7 |
if (space / sdp->sd_inptrs != sdp->sd_heightsize[x - 1] ||
|
|
|
903fa7 |
diff --git a/tests/fsck.at b/tests/fsck.at
|
|
|
903fa7 |
index 34c5bd5..d7a8357 100644
|
|
|
903fa7 |
--- a/tests/fsck.at
|
|
|
903fa7 |
+++ b/tests/fsck.at
|
|
|
903fa7 |
@@ -1,8 +1,10 @@
|
|
|
903fa7 |
AT_TESTED([fsck.gfs2])
|
|
|
903fa7 |
AT_BANNER([fsck.gfs2 tests])
|
|
|
903fa7 |
|
|
|
903fa7 |
-AT_SETUP([Zeroed block size])
|
|
|
903fa7 |
-GFS_LANG_CHECK(
|
|
|
903fa7 |
- [mkfs.gfs2 -O -p lock_nolock $GFS_TGT],
|
|
|
903fa7 |
- [set sb { sb_bsize: 0 }])
|
|
|
903fa7 |
+AT_SETUP([Fix invalid block sizes])
|
|
|
903fa7 |
+GFS_LANG_CHECK([mkfs.gfs2 -O -p lock_nolock $GFS_TGT], [set sb { sb_bsize: 0 }])
|
|
|
903fa7 |
+GFS_LANG_CHECK([mkfs.gfs2 -O -p lock_nolock $GFS_TGT], [set sb { sb_bsize: 1 }])
|
|
|
903fa7 |
+GFS_LANG_CHECK([mkfs.gfs2 -O -p lock_nolock $GFS_TGT], [set sb { sb_bsize: 513 }])
|
|
|
903fa7 |
+GFS_LANG_CHECK([mkfs.gfs2 -O -p lock_nolock $GFS_TGT], [set sb { sb_bsize: 4095 }])
|
|
|
903fa7 |
+GFS_LANG_CHECK([mkfs.gfs2 -O -p lock_nolock $GFS_TGT], [set sb { sb_bsize: 4097 }])
|
|
|
903fa7 |
AT_CLEANUP
|
|
|
903fa7 |
diff --git a/tests/mkfs.at b/tests/mkfs.at
|
|
|
903fa7 |
index aff6a0d..a3973af 100644
|
|
|
903fa7 |
--- a/tests/mkfs.at
|
|
|
903fa7 |
+++ b/tests/mkfs.at
|
|
|
903fa7 |
@@ -31,6 +31,13 @@ GFS_FSCK_CHECK([mkfs.gfs2 -O -p lock_nolock $GFS_TGT])
|
|
|
903fa7 |
GFS_FSCK_CHECK([mkfs.gfs2 -O -p lock_dlm -t foo:bar $GFS_TGT])
|
|
|
903fa7 |
AT_CLEANUP
|
|
|
903fa7 |
|
|
|
903fa7 |
+AT_SETUP([Valid block sizes 512-4096])
|
|
|
903fa7 |
+GFS_FSCK_CHECK([mkfs.gfs2 -O -p lock_nolock -b 512 $GFS_TGT])
|
|
|
903fa7 |
+GFS_FSCK_CHECK([mkfs.gfs2 -O -p lock_nolock -b 1024 $GFS_TGT])
|
|
|
903fa7 |
+GFS_FSCK_CHECK([mkfs.gfs2 -O -p lock_nolock -b 2048 $GFS_TGT])
|
|
|
903fa7 |
+GFS_FSCK_CHECK([mkfs.gfs2 -O -p lock_nolock -b 4096 $GFS_TGT])
|
|
|
903fa7 |
+AT_CLEANUP
|
|
|
903fa7 |
+
|
|
|
903fa7 |
AT_SETUP([Max. blocks, min. block size])
|
|
|
903fa7 |
GFS_FSCK_CHECK([mkfs.gfs2 -O -p lock_nolock -b 512 $GFS_TGT $(gfs_max_blocks 512)])
|
|
|
903fa7 |
AT_CLEANUP
|