Blame SOURCES/0033-manager-correct-display-confusion.patch

400dab
From 05e49542a9de81731fce68614babe22d437e8fff Mon Sep 17 00:00:00 2001
400dab
From: Ray Strode <rstrode@redhat.com>
400dab
Date: Mon, 1 Oct 2018 11:05:57 -0400
400dab
Subject: [PATCH 33/51] manager: correct display confusion
400dab
400dab
commit c5c5bf1f reworked autologin and broke it.
400dab
400dab
This commit addresses the breakage by accessing
400dab
the proper display variable.
400dab
400dab
Closes https://gitlab.gnome.org/GNOME/gdm/issues/426
400dab
---
400dab
 daemon/gdm-manager.c | 2 +-
400dab
 1 file changed, 1 insertion(+), 1 deletion(-)
400dab
400dab
diff --git a/daemon/gdm-manager.c b/daemon/gdm-manager.c
400dab
index 228cec6ff..4c81dac7f 100644
400dab
--- a/daemon/gdm-manager.c
400dab
+++ b/daemon/gdm-manager.c
400dab
@@ -1711,61 +1711,61 @@ on_start_user_session (StartUserSessionOperation *operation)
400dab
                 if (doing_initial_setup) {
400dab
                         g_debug ("GdmManager: closing down initial setup display");
400dab
                         gdm_display_stop_greeter_session (display);
400dab
                         gdm_display_unmanage (display);
400dab
                         gdm_display_finish (display);
400dab
                 } else {
400dab
                         g_debug ("GdmManager: session has its display server, reusing our server for another login screen");
400dab
                 }
400dab
 
400dab
                 /* The user session is going to follow the session worker
400dab
                  * into the new display. Untie it from this display and
400dab
                  * create a new session for a future user login. */
400dab
                 allowed_uid = gdm_session_get_allowed_user (operation->session);
400dab
                 g_object_set_data (G_OBJECT (display), "gdm-user-session", NULL);
400dab
                 g_object_set_data (G_OBJECT (operation->session), "gdm-display", NULL);
400dab
                 create_user_session_for_display (operation->manager, display, allowed_uid);
400dab
 
400dab
                 /* Give the user session a new display object for bookkeeping purposes */
400dab
                 create_display_for_user_session (operation->manager,
400dab
                                                  operation->session,
400dab
                                                  session_id);
400dab
 
400dab
                 if ((g_strcmp0 (operation->service_name, "gdm-autologin") == 0) &&
400dab
                     !gdm_session_client_is_connected (operation->session)) {
400dab
                         /* remove the unused prepared greeter display since we're not going
400dab
                          * to have a greeter */
400dab
                         gdm_display_store_remove (self->priv->display_store, display);
400dab
                         g_object_unref (display);
400dab
 
400dab
                         self->priv->automatic_login_display = g_object_get_data (G_OBJECT (operation->session), "gdm-display");
400dab
-                        g_object_add_weak_pointer (G_OBJECT (display), (gpointer *) &self->priv->automatic_login_display);
400dab
+                        g_object_add_weak_pointer (G_OBJECT (self->priv->automatic_login_display), (gpointer *) &self->priv->automatic_login_display);
400dab
                 }
400dab
         }
400dab
 
400dab
         start_user_session (operation->manager, operation);
400dab
 
400dab
  out:
400dab
         return G_SOURCE_REMOVE;
400dab
 }
400dab
 
400dab
 static void
400dab
 queue_start_user_session (GdmManager *manager,
400dab
                           GdmSession *session,
400dab
                           const char *service_name)
400dab
 {
400dab
         StartUserSessionOperation *operation;
400dab
 
400dab
         operation = g_slice_new0 (StartUserSessionOperation);
400dab
         operation->manager = manager;
400dab
         operation->session = g_object_ref (session);
400dab
         operation->service_name = g_strdup (service_name);
400dab
 
400dab
         operation->idle_id = g_idle_add ((GSourceFunc) on_start_user_session, operation);
400dab
         g_object_set_data (G_OBJECT (session), "start-user-session-operation", operation);
400dab
 }
400dab
 
400dab
 static void
400dab
 start_user_session_if_ready (GdmManager *manager,
400dab
                              GdmSession *session,
400dab
                              const char *service_name)
400dab
 {
400dab
-- 
400dab
2.27.0
400dab