|
 |
2c2fa1 |
commit 9e0aa64f5510861b2517c5841b59adde8e423540
|
|
|
2c2fa1 |
Author: Jan Kratochvil <jan.kratochvil@redhat.com>
|
|
|
2c2fa1 |
Date: Mon May 19 20:20:27 2014 +0200
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
Fix gdbserver qGetTLSAddr for x86_64 -m32
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
gdbserver makes libthread_db to access uninitialized memory. Surprisingly it
|
|
|
2c2fa1 |
does not harm normally, even -fsanitize=address works with current gdbserver.
|
|
|
2c2fa1 |
I have found just valgrind detects it as a very first warning for gdbserver:
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
Syscall param ptrace(addr) contains uninitialised byte(s)
|
|
|
2c2fa1 |
at 0x3721EECEBE: ptrace (ptrace.c:45)
|
|
|
2c2fa1 |
by 0x436EE5: ps_get_thread_area (linux-x86-low.c:252)
|
|
|
2c2fa1 |
by 0x5559D02: __td_ta_lookup_th_unique (td_ta_map_lwp2thr.c:157)
|
|
|
2c2fa1 |
by 0x5559EC3: td_ta_map_lwp2thr (td_ta_map_lwp2thr.c:207)
|
|
|
2c2fa1 |
by 0x43F87D: find_one_thread (thread-db.c:281)
|
|
|
2c2fa1 |
by 0x440038: thread_db_get_tls_address (thread-db.c:505)
|
|
|
2c2fa1 |
by 0x40F6D0: handle_query (server.c:2004)
|
|
|
2c2fa1 |
by 0x4124CF: process_serial_event (server.c:3445)
|
|
|
2c2fa1 |
by 0x4136B6: handle_serial_event (server.c:3889)
|
|
|
2c2fa1 |
by 0x419571: handle_file_event (event-loop.c:434)
|
|
|
2c2fa1 |
by 0x418D38: process_event (event-loop.c:189)
|
|
|
2c2fa1 |
by 0x419AB7: start_event_loop (event-loop.c:552)
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
Reproducible with:
|
|
|
2c2fa1 |
cd gdb/testsuite
|
|
|
2c2fa1 |
g++ -o gdb.threads/tls gdb.threads/tls{,2}.c -m32 -pthread
|
|
|
2c2fa1 |
../gdbserver/gdbserver :1234 gdb.threads/tls
|
|
|
2c2fa1 |
../gdb -batch gdb.threads/tls -ex 'target remote :1234' -ex 'b spin' -ex c -ex 'p a_thread_local'
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
It is more easily reproducible even without valgrind using s/0x00/0xff/ in the
|
|
|
2c2fa1 |
attached patch. It will then turn the output of reproducer above:
|
|
|
2c2fa1 |
$1 = 0
|
|
|
2c2fa1 |
->
|
|
|
2c2fa1 |
Cannot find thread-local storage for Thread 29044, executable file .../gdb/testsuite/gdb.threads/tls:
|
|
|
2c2fa1 |
Remote target failed to process qGetTLSAddr request
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
gdb/gdbserver/
|
|
|
2c2fa1 |
2014-05-19 Jan Kratochvil <jan.kratochvil@redhat.com>
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
Fix gdbserver qGetTLSAddr for x86_64 -m32.
|
|
|
2c2fa1 |
* linux-x86-low.c (X86_64_USER_REGS): New.
|
|
|
2c2fa1 |
(x86_fill_gregset): Call memset for BUF first in x86_64 -m32 case.
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
Message-ID: <20140410114901.GA16411@host2.jankratochvil.net>
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
Index: gdb-7.6.1/gdb/gdbserver/linux-x86-low.c
|
|
|
2c2fa1 |
===================================================================
|
|
|
2c2fa1 |
--- gdb-7.6.1.orig/gdb/gdbserver/linux-x86-low.c
|
|
|
2c2fa1 |
+++ gdb-7.6.1/gdb/gdbserver/linux-x86-low.c
|
|
|
2c2fa1 |
@@ -144,6 +144,7 @@ static const int x86_64_regmap[] =
|
|
|
2c2fa1 |
};
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
#define X86_64_NUM_REGS (sizeof (x86_64_regmap) / sizeof (x86_64_regmap[0]))
|
|
|
2c2fa1 |
+#define X86_64_USER_REGS (GS + 1)
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
#else /* ! __x86_64__ */
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
@@ -275,6 +276,10 @@ x86_fill_gregset (struct regcache *regca
|
|
|
2c2fa1 |
collect_register (regcache, i, ((char *) buf) + x86_64_regmap[i]);
|
|
|
2c2fa1 |
return;
|
|
|
2c2fa1 |
}
|
|
|
2c2fa1 |
+
|
|
|
2c2fa1 |
+ /* 32-bit inferior registers need to be zero-extended.
|
|
|
2c2fa1 |
+ Callers would read uninitialized memory otherwise. */
|
|
|
2c2fa1 |
+ memset (buf, 0x00, X86_64_USER_REGS * 8);
|
|
|
2c2fa1 |
#endif
|
|
|
2c2fa1 |
|
|
|
2c2fa1 |
for (i = 0; i < I386_NUM_REGS; i++)
|