|
 |
c923ac |
From b005000525ab0a5116d21217c41fb1da5bd03796 Mon Sep 17 00:00:00 2001
|
|
|
c923ac |
From: Jonathan Wakely <jwakely@redhat.com>
|
|
|
c923ac |
Date: Fri, 6 May 2022 21:19:17 +0100
|
|
|
c923ac |
Subject: [PATCH] libstdc++: Fix deserialization for std::normal_distribution
|
|
|
c923ac |
[PR105502]
|
|
|
c923ac |
|
|
|
c923ac |
This fixes a regression in std::normal_distribution deserialization that
|
|
|
c923ac |
caused the object to be left unchanged if the __state_avail value read
|
|
|
c923ac |
from the stream was false.
|
|
|
c923ac |
|
|
|
c923ac |
libstdc++-v3/ChangeLog:
|
|
|
c923ac |
|
|
|
c923ac |
PR libstdc++/105502
|
|
|
c923ac |
* include/bits/random.tcc
|
|
|
c923ac |
(operator>>(basic_istream<C,T>&, normal_distribution<R>&)):
|
|
|
c923ac |
Update state when __state_avail is false.
|
|
|
c923ac |
* testsuite/26_numerics/random/normal_distribution/operators/serialize.cc:
|
|
|
c923ac |
Check that deserialized object equals serialized one.
|
|
|
c923ac |
|
|
|
c923ac |
(cherry picked from commit 909ef4e2727ddc50a32d6ad379a1f1ccc1043c6a)
|
|
|
c923ac |
---
|
|
|
c923ac |
libstdc++-v3/include/bits/random.tcc | 2 +-
|
|
|
c923ac |
.../operators/serialize.cc | 36 ++++++++++++++++++-
|
|
|
c923ac |
2 files changed, 36 insertions(+), 2 deletions(-)
|
|
|
c923ac |
|
|
|
c923ac |
diff --git a/libstdc++-v3/include/bits/random.tcc b/libstdc++-v3/include/bits/random.tcc
|
|
|
c923ac |
index 0a299baedc5..0f758671f69 100644
|
|
|
c923ac |
--- a/libstdc++-v3/include/bits/random.tcc
|
|
|
c923ac |
+++ b/libstdc++-v3/include/bits/random.tcc
|
|
|
c923ac |
@@ -1941,7 +1941,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
|
|
|
c923ac |
bool __saved_avail;
|
|
|
c923ac |
if (__is >> __mean >> __stddev >> __saved_avail)
|
|
|
c923ac |
{
|
|
|
c923ac |
- if (__saved_avail && (__is >> __x._M_saved))
|
|
|
c923ac |
+ if (!__saved_avail || (__is >> __x._M_saved))
|
|
|
c923ac |
{
|
|
|
c923ac |
__x._M_saved_available = __saved_avail;
|
|
|
c923ac |
__x.param(typename normal_distribution<_RealType>::
|
|
|
c923ac |
diff --git a/libstdc++-v3/testsuite/26_numerics/random/normal_distribution/operators/serialize.cc b/libstdc++-v3/testsuite/26_numerics/random/normal_distribution/operators/serialize.cc
|
|
|
c923ac |
index a65d4004161..8cc70886bc7 100644
|
|
|
c923ac |
--- a/libstdc++-v3/testsuite/26_numerics/random/normal_distribution/operators/serialize.cc
|
|
|
c923ac |
+++ b/libstdc++-v3/testsuite/26_numerics/random/normal_distribution/operators/serialize.cc
|
|
|
c923ac |
@@ -25,6 +25,7 @@
|
|
|
c923ac |
|
|
|
c923ac |
#include <random>
|
|
|
c923ac |
#include <sstream>
|
|
|
c923ac |
+#include <testsuite_hooks.h>
|
|
|
c923ac |
|
|
|
c923ac |
void
|
|
|
c923ac |
test01()
|
|
|
c923ac |
@@ -37,10 +38,43 @@ test01()
|
|
|
c923ac |
str << u;
|
|
|
c923ac |
|
|
|
c923ac |
str >> v;
|
|
|
c923ac |
+ VERIFY( u == v );
|
|
|
c923ac |
+}
|
|
|
c923ac |
+
|
|
|
c923ac |
+void
|
|
|
c923ac |
+test_pr105502()
|
|
|
c923ac |
+{
|
|
|
c923ac |
+ // PR libstdc++/105502 std::normal_distribution deserialization issue
|
|
|
c923ac |
+ std::stringstream str;
|
|
|
c923ac |
+ std::normal_distribution<> d{1, 2}, d2;
|
|
|
c923ac |
+ std::minstd_rand0 g;
|
|
|
c923ac |
+ str << d;
|
|
|
c923ac |
+ VERIFY( str );
|
|
|
c923ac |
+ str >> d2;
|
|
|
c923ac |
+ VERIFY( str );
|
|
|
c923ac |
+ VERIFY( d == d2 );
|
|
|
c923ac |
+
|
|
|
c923ac |
+ (void) d(g); // sets d._M_saved_available = true
|
|
|
c923ac |
+ str.str("");
|
|
|
c923ac |
+ str.clear();
|
|
|
c923ac |
+ str << d;
|
|
|
c923ac |
+ VERIFY( str );
|
|
|
c923ac |
+ str >> d2;
|
|
|
c923ac |
+ VERIFY( str );
|
|
|
c923ac |
+ VERIFY( d == d2 );
|
|
|
c923ac |
+
|
|
|
c923ac |
+ (void) d(g); // sets d._M_saved_available = false
|
|
|
c923ac |
+ str.str("");
|
|
|
c923ac |
+ str.clear();
|
|
|
c923ac |
+ str << d;
|
|
|
c923ac |
+ VERIFY( str );
|
|
|
c923ac |
+ str >> d2;
|
|
|
c923ac |
+ VERIFY( str );
|
|
|
c923ac |
+ VERIFY( d == d2 );
|
|
|
c923ac |
}
|
|
|
c923ac |
|
|
|
c923ac |
int main()
|
|
|
c923ac |
{
|
|
|
c923ac |
test01();
|
|
|
c923ac |
- return 0;
|
|
|
c923ac |
+ test_pr105502();
|
|
|
c923ac |
}
|
|
|
c923ac |
--
|
|
|
c923ac |
2.31.1
|
|
|
c923ac |
|