Blame SOURCES/gdb-runtest-pie-override.patch

79b363
From FEDORA_PATCHES Mon Sep 17 00:00:00 2001
79b363
From: Fedora GDB patches <invalid@email.com>
79b363
Date: Fri, 27 Oct 2017 21:07:50 +0200
79b363
Subject: gdb-runtest-pie-override.patch
79b363
79b363
;; Hack for proper PIE run of the testsuite.
79b363
;;=fedoratest
79b363
79b363
make check//unix/-fPIE/-pie RUNTESTFLAGS=solib-display.exp
79b363
79b363
gcc -fpic -c  -fPIE -pie -o x.o x.c
79b363
/usr/lib/gcc/x86_64-redhat-linux/4.6.1/../../../../lib64/Scrt1.o: In function `_start':
79b363
(.text+0x20): undefined reference to `main'
79b363
79b363
=> Change the order for overrides.
79b363
79b363
One has to also use -fPIC rather than -fPIE, -fPIC is stronger.
79b363
79b363
The correct way would be:
79b363
make check//unix RUNTESTFLAGS='CC_FOR_TARGET=gcc\ -fPIC\ -pie CXX_FOR_TARGET=g++\ -fPIC\ -pie solib-display.exp'
79b363
79b363
But there is a problem with testsuite.unix non-unique subdir name and also
79b363
a problem with make -j parallelization of the testsuite.
79b363
79b363
diff --git a/gdb/testsuite/lib/future.exp b/gdb/testsuite/lib/future.exp
79b363
--- a/gdb/testsuite/lib/future.exp
79b363
+++ b/gdb/testsuite/lib/future.exp
79b363
@@ -197,6 +197,10 @@ proc gdb_default_target_compile_1 {source destfile type options} {
79b363
     set ldflags ""
79b363
     set dest [target_info name]
79b363
 
79b363
+    if {[board_info $dest exists multilib_flags]} {
79b363
+	append add_flags " [board_info $dest multilib_flags]"
79b363
+    }
79b363
+
79b363
     if {[info exists CFLAGS_FOR_TARGET]} {
79b363
 	append add_flags " $CFLAGS_FOR_TARGET"
79b363
     }
79b363
@@ -531,10 +535,6 @@ proc gdb_default_target_compile_1 {source destfile type options} {
79b363
 	}
79b363
     }
79b363
 
79b363
-    if {[board_info $dest exists multilib_flags]} {
79b363
-	append add_flags " [board_info $dest multilib_flags]"
79b363
-    }
79b363
-
79b363
     verbose "doing compile"
79b363
 
79b363
     set sources ""