Blame SOURCES/gdb-runtest-pie-override.patch

ab2726
From FEDORA_PATCHES Mon Sep 17 00:00:00 2001
ab2726
From: Fedora GDB patches <invalid@email.com>
ab2726
Date: Fri, 27 Oct 2017 21:07:50 +0200
ab2726
Subject: gdb-runtest-pie-override.patch
ab2726
ab2726
;; Hack for proper PIE run of the testsuite.
ab2726
;;=fedoratest
ab2726
ab2726
make check//unix/-fPIE/-pie RUNTESTFLAGS=solib-display.exp
ab2726
ab2726
gcc -fpic -c  -fPIE -pie -o x.o x.c
ab2726
/usr/lib/gcc/x86_64-redhat-linux/4.6.1/../../../../lib64/Scrt1.o: In function `_start':
ab2726
(.text+0x20): undefined reference to `main'
ab2726
ab2726
=> Change the order for overrides.
ab2726
ab2726
One has to also use -fPIC rather than -fPIE, -fPIC is stronger.
ab2726
ab2726
The correct way would be:
ab2726
make check//unix RUNTESTFLAGS='CC_FOR_TARGET=gcc\ -fPIC\ -pie CXX_FOR_TARGET=g++\ -fPIC\ -pie solib-display.exp'
ab2726
ab2726
But there is a problem with testsuite.unix non-unique subdir name and also
ab2726
a problem with make -j parallelization of the testsuite.
ab2726
ab2726
diff --git a/gdb/testsuite/lib/future.exp b/gdb/testsuite/lib/future.exp
ab2726
--- a/gdb/testsuite/lib/future.exp
ab2726
+++ b/gdb/testsuite/lib/future.exp
ab2726
@@ -197,6 +197,10 @@ proc gdb_default_target_compile_1 {source destfile type options} {
ab2726
     set ldflags ""
ab2726
     set dest [target_info name]
ab2726
 
ab2726
+    if {[board_info $dest exists multilib_flags]} {
ab2726
+	append add_flags " [board_info $dest multilib_flags]"
ab2726
+    }
ab2726
+
ab2726
     if {[info exists CFLAGS_FOR_TARGET]} {
ab2726
 	append add_flags " $CFLAGS_FOR_TARGET"
ab2726
     }
ab2726
@@ -531,10 +535,6 @@ proc gdb_default_target_compile_1 {source destfile type options} {
ab2726
 	}
ab2726
     }
ab2726
 
ab2726
-    if {[board_info $dest exists multilib_flags]} {
ab2726
-	append add_flags " [board_info $dest multilib_flags]"
ab2726
-    }
ab2726
-
ab2726
     verbose "doing compile"
ab2726
 
ab2726
     set sources ""